git cl: insert "Review-Url" instead "Review URL" footer like CQ.

R=sergiyb@chromium.org

Change-Id: I2df867e381ceb1035add84563d3b444b0ee0ea94
Reviewed-on: https://chromium-review.googlesource.com/417267
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
changes/67/417267/2
Andrii Shyshkalov 9 years ago committed by Commit Bot
parent 768f1d88a0
commit f01be229a7

@ -4586,7 +4586,7 @@ def SendUpstream(parser, args, cmd):
# after it. Add a period on a new line to circumvent this. Also add a space
# before the period to make sure that Gitiles continues to correctly resolve
# the URL.
commit_desc.append_footer('Review URL: %s .' % cl.GetIssueURL())
commit_desc.append_footer('Review-Url: %s .' % cl.GetIssueURL())
if options.contributor:
commit_desc.append_footer('Patch from %s.' % options.contributor)

@ -749,7 +749,7 @@ class TestGitCl(TestCase):
((['git', 'reset', '--soft', 'fake_ancestor_sha'],), ''),
((['git', 'commit', '-m',
'Issue: 12345\n\nR=john@chromium.org\n\n'
'Review URL: https://codereview.example.com/12345 .'],),
'Review-Url: https://codereview.example.com/12345 .'],),
''),
((['git', 'config', 'rietveld.force-https-commit-url'],), ''),
((['git',
@ -1011,7 +1011,7 @@ class TestGitCl(TestCase):
((['git', 'reset', '--soft', 'fake_ancestor_sha'],), ''),
((['git', 'commit', '-m',
'Issue: 123\n\nR=john@chromium.org\n\n'
'Review URL: https://codereview.chromium.org/123 .'],), ''),
'Review-Url: https://codereview.chromium.org/123 .'],), ''),
((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
((['git', 'config', 'branch.feature.remote'],), 'origin'),
((['git', 'config', '--get', 'remote.origin.url'],),
@ -1115,8 +1115,7 @@ class TestGitCl(TestCase):
((['git', 'commit', '--amend', '-m',
'Issue: 123\n\nR=john@chromium.org\n'
'\n'
'Review URL: https://codereview.chromium.org/123 .\n'
'\n'
'Review-Url: https://codereview.chromium.org/123 .\n'
'Cr-Commit-Position: refs/heads/master@{#544}\n'
'Cr-Branched-From: refs/svn/2014@{#2208}'],), ''),
@ -1130,8 +1129,7 @@ class TestGitCl(TestCase):
((['update_description', 123,
'Issue: 123\n\nR=john@chromium.org\n'
'\n'
'Review URL: https://codereview.chromium.org/123 .\n'
'\n'
'Review-Url: https://codereview.chromium.org/123 .\n'
'Cr-Commit-Position: refs/heads/master@{#544}\n'
'Cr-Branched-From: refs/svn/2014@{#2208}\n'
'Committed: '

Loading…
Cancel
Save