Update VC++ packaging script to not package vctip.exe

Some build machines end up running vctip.exe for some reason and then
it doesn't shut down in a timely manner, leaving locks on directories.
This changes the packaging script so that vctip.exe is not packaged, and
therefore won't be run.

vctip.exe is the "Microsoft VC compiler and tools experience
improvement data uploader" and it presumably runs automatically as part
of running the compiler. It's not clear what triggers it to run,
however omitting it should be safe.

BUG=735226

Change-Id: Ie6af562def6214a5bb130ccc09c732efc1769bcd
Reviewed-on: https://chromium-review.googlesource.com/544395
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
changes/95/544395/4
Bruce Dawson 8 years ago committed by Commit Bot
parent 9756104b69
commit b983ac1ae2

@ -135,6 +135,11 @@ def BuildFileList(override_dir):
raise Exception('%s not a directory.' % combined)
for root, _, files in os.walk(combined):
for f in files:
# vctip.exe doesn't shutdown, leaving locks on directories. It's
# optional so let's avoid this problem by not packaging it.
# https://crbug.com/735226
if f.lower() =='vctip.exe':
continue
final_from = os.path.normpath(os.path.join(root, f))
if isinstance(path, tuple):
assert final_from.startswith(combined)

Loading…
Cancel
Save