owners: Use DepotToolsClient while code-owners plugin is fixed.

Bug: 1183447
Change-Id: I11c67b13ace08eb5bafb90756bd45af6ff39f12f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727569
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
changes/69/2727569/5
Edward Lesmes 4 years ago committed by LUCI CQ
parent a9805d0e8b
commit b87cca8444

@ -234,6 +234,6 @@ def GetCodeOwnersClient(root, host, project, branch):
Defaults to GerritClient, and falls back to DepotToolsClient if code-owners
plugin is not available."""
if gerrit_util.IsCodeOwnersEnabled(host):
return GerritClient(host, project, branch)
# TODO(crbug.com/1183447): Use code-owners plugin if available on host once
# code-owners plugin issues have been fixed.
return DepotToolsClient(root, branch)

@ -313,10 +313,9 @@ class GetCodeOwnersClientTest(unittest.TestCase):
self.addCleanup(mock.patch.stopall)
def testGetCodeOwnersClient_GerritClient(self):
gerrit_util.IsCodeOwnersEnabled.return_value = True
self.assertIsInstance(
owners_client.GetCodeOwnersClient('root', 'host', 'project', 'branch'),
owners_client.GerritClient)
# TODO(crbug.com/1183447): Check that code-owners is used if available once
# code-owners plugin issues have been fixed.
pass
def testGetCodeOwnersClient_DepotToolsClient(self):
gerrit_util.IsCodeOwnersEnabled.return_value = False

Loading…
Cancel
Save