Rollback UpgradeToHttps for viewvc links

- Many chrome-internal viewvc links do not support https.  UpgradeToHttps
  was added 10 months ago  and continues to generate broken viewvc links.

Reverts part of crrev.com/9214004

BUG=107838

Review URL: https://chromiumcodereview.appspot.com/11412161

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169815 0039d316-1c4b-4281-b951-d872f2087c98

gcl.py

@@ -1031,7 +1031,7 @@ def CMDcommit(change_info, args):
     if change_info.issue:
       revision = re.compile(".*?\nCommitted revision (\d+)",
                             re.DOTALL).match(output).group(1)
-      viewvc_url = gclient_utils.UpgradeToHttps(GetCodeReviewSetting('VIEW_VC'))
+      viewvc_url = GetCodeReviewSetting('VIEW_VC')
       change_info.description += '\n'
       if viewvc_url and revision:
         change_info.description += "\nCommitted: " + viewvc_url + revision

git_cl.py

@@ -349,8 +349,7 @@ class Settings(object):
 
   def GetViewVCUrl(self):
     if not self.viewvc_url:
-      self.viewvc_url = gclient_utils.UpgradeToHttps(
-          self._GetConfig('rietveld.viewvc-url', error_ok=True))
+      self.viewvc_url = self._GetConfig('rietveld.viewvc-url', error_ok=True)
     return self.viewvc_url
 
   def GetDefaultCCList(self):

tests/gcl_unittest.py

@@ -582,7 +582,7 @@ class CMDCommitUnittest(GclTestsBase):
     retval = gcl.CMDcommit(['naame'])
     self.assertEquals(retval, 0)
     self.assertEquals(change_info.description,
-        'deescription\n\nCommitted: https://view/12345')
+        'deescription\n\nCommitted: http://view/12345')
     # pylint: disable=W0212
     self.assertTrue(change_info._deleted)
     self.assertTrue(change_info._closed)