Add some differentiating details to gerrit step names.

R=phajdan.jr@chromium.org

Recipe-Manual-Change: release_scripts
Recipe-Nontrivial-Roll: release_scripts
Change-Id: I4c3ca01bad7e5158565a8abc8d7fc5b4b77b0d4f
Reviewed-on: https://chromium-review.googlesource.com/666977
Commit-Queue: Michael Moss <mmoss@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
changes/77/666977/5
Michael Moss 8 years ago committed by Commit Bot
parent 410907fe59
commit 7d7c4840b7

@ -39,7 +39,7 @@ class GerritApi(recipe_api.RecipeApi):
'--commit', commit, '--commit', commit,
'--json_file', self.m.json.output() '--json_file', self.m.json.output()
] ]
step_name = 'create_gerrit_branch' step_name = 'create_gerrit_branch (%s %s)' % (project, branch)
step_result = self(step_name, args, **kwargs) step_result = self(step_name, args, **kwargs)
ref = step_result.json.output.get('ref') ref = step_result.json.output.get('ref')
return ref return ref
@ -60,7 +60,7 @@ class GerritApi(recipe_api.RecipeApi):
'--branch', branch, '--branch', branch,
'--json_file', self.m.json.output() '--json_file', self.m.json.output()
] ]
step_name='get_gerrit_branch' step_name = 'get_gerrit_branch (%s %s)' % (project, branch)
step_result = self(step_name, args, **kwargs) step_result = self(step_name, args, **kwargs)
revision = step_result.json.output.get('revision') revision = step_result.json.output.get('revision')
return revision return revision

@ -20,7 +20,7 @@
"PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]" "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
}, },
"infra_step": true, "infra_step": true,
"name": "gerrit create_gerrit_branch", "name": "gerrit create_gerrit_branch (v8/v8 test)",
"~followup_annotations": [ "~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@{@@@", "@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"can_delete\": true, @@@", "@@@STEP_LOG_LINE@json.output@ \"can_delete\": true, @@@",
@ -49,7 +49,7 @@
"PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]" "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
}, },
"infra_step": true, "infra_step": true,
"name": "gerrit get_gerrit_branch", "name": "gerrit get_gerrit_branch (v8/v8 master)",
"~followup_annotations": [ "~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@{@@@", "@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"ref\": \"refs/heads/master\", @@@", "@@@STEP_LOG_LINE@json.output@ \"ref\": \"refs/heads/master\", @@@",

@ -50,11 +50,11 @@ def GenTests(api):
yield ( yield (
api.test('basic') api.test('basic')
+ api.step_data( + api.step_data(
'gerrit create_gerrit_branch', 'gerrit create_gerrit_branch (v8/v8 test)',
api.gerrit.make_gerrit_create_branch_response_data() api.gerrit.make_gerrit_create_branch_response_data()
) )
+ api.step_data( + api.step_data(
'gerrit get_gerrit_branch', 'gerrit get_gerrit_branch (v8/v8 master)',
api.gerrit.make_gerrit_get_branch_response_data() api.gerrit.make_gerrit_get_branch_response_data()
) )
+ api.step_data( + api.step_data(

Loading…
Cancel
Save