git cl: temporary stop using project~number on Gerrit.

Broke release process.

R=ehmaldonado, mmoss

Bug: 876964, 876910
Change-Id: I02ea424632f5c5522af0010adce1c993e2610b48
Reviewed-on: https://chromium-review.googlesource.com/1187548
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
changes/48/1187548/2
Andrii Shyshkalov 7 years ago committed by Commit Bot
parent b16da6a2a9
commit 6365bc4446

@ -2419,8 +2419,10 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):
Not to be confused by value of "Change-Id:" footer. Not to be confused by value of "Change-Id:" footer.
""" """
return gerrit_util.ChangeIdentifier( # TODO(tandrii): undo this once a fix is in place for crbug/876964.
self._GetGerritProject(), self.GetIssue()) # return gerrit_util.ChangeIdentifier(
# self._GetGerritProject(), self.GetIssue())
return str(self.GetIssue())
@classmethod @classmethod
def IssueConfigKey(cls): def IssueConfigKey(cls):

@ -1327,7 +1327,7 @@ class TestGitCl(TestCase):
if squash: if squash:
calls += [ calls += [
(('AddReviewers', (('AddReviewers',
'chromium-review.googlesource.com', 'my%2Frepo~123456', 'chromium-review.googlesource.com', '123456',
sorted(reviewers), sorted(reviewers),
['joe@example.com', 'chromium-reviews+test-more-cc@chromium.org'] + ['joe@example.com', 'chromium-reviews+test-more-cc@chromium.org'] +
cc, notify), ''), cc, notify), ''),
@ -1351,7 +1351,7 @@ class TestGitCl(TestCase):
}), }),
(('SetReview', (('SetReview',
'chromium-review.googlesource.com', 'chromium-review.googlesource.com',
'my%2Frepo~123456', '123456',
'Self-approving for TBR', 'Self-approving for TBR',
{'Code-Review': 2}, None), ''), {'Code-Review': 2}, None), ''),
] ]

Loading…
Cancel
Save