aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Replace python3 with vpython3 in gclient/api.py

Browse Source 
For context see comments 5 and 6 here: https://bugs.chromium.org/p/chromium/issues/detail?id=1298922#c6

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Bug: chromium:1298922
Change-Id: Id424cec27ca64ac0c2e746d54edf044820915cd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3480835
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>
changes/35/3480835/6
Ravi Mistry 3 years ago committed by LUCI CQ
parent 42cf2acbae
commit 32645dfee9
8 changed files with 32 additions and 32 deletions
Show Stats Download Patch File Download Diff File

2
recipes/recipe_modules/gclient/api.py
Unescape Escape View File

@ -100,7 +100,7 @@ class GclientApi(recipe_api.RecipeApi):
self.m.buildbucket.build.builder.builder, self.m.buildbucket.build.builder.builder,
self.m.buildbucket.build.id) self.m.buildbucket.build.id)
with self.m.context(env=env, env_suffixes=env_suffixes): with self.m.context(env=env, env_suffixes=env_suffixes):
cmd = ['python3', '-u', self.repo_resource('gclient.py')] + cmd cmd = ['vpython3', '-u', self.repo_resource('gclient.py')] + cmd
return self.m.step(prefix + name, return self.m.step(prefix + name,
cmd, cmd,
infra_step=infra_step, infra_step=infra_step,

18
recipes/recipe_modules/gclient/examples/full.expected/basic.json
Unescape Escape View File

@ -1,7 +1,7 @@
[ [
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"config", "config",
@ -18,7 +18,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"sync", "sync",
@ -55,7 +55,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",
@ -74,7 +74,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",
@ -93,7 +93,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"config", "config",
@ -111,7 +111,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"sync", "sync",
@ -155,7 +155,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",
@ -175,7 +175,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",
@ -220,7 +220,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"runhooks" "runhooks"

18
recipes/recipe_modules/gclient/examples/full.expected/revision.json
Unescape Escape View File

@ -1,7 +1,7 @@
[ [
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"config", "config",
@ -33,7 +33,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"sync", "sync",
@ -87,7 +87,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",
@ -121,7 +121,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",
@ -155,7 +155,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"config", "config",
@ -188,7 +188,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"sync", "sync",
@ -247,7 +247,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",
@ -282,7 +282,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",
@ -354,7 +354,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"runhooks" "runhooks"

18
recipes/recipe_modules/gclient/examples/full.expected/tryserver.json
Unescape Escape View File

@ -1,7 +1,7 @@
[ [
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"config", "config",
@ -33,7 +33,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"sync", "sync",
@ -85,7 +85,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",
@ -119,7 +119,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",
@ -153,7 +153,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"config", "config",
@ -186,7 +186,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"sync", "sync",
@ -245,7 +245,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",
@ -280,7 +280,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",
@ -352,7 +352,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"runhooks" "runhooks"

2
recipes/recipe_modules/gclient/tests/diff_deps.expected/basic.json
Unescape Escape View File

@ -27,7 +27,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",

2
recipes/recipe_modules/gclient/tests/diff_deps.expected/dont have revision yet.json
Unescape Escape View File

@ -27,7 +27,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",

2
recipes/recipe_modules/gclient/tests/diff_deps.expected/no change, exception.json
Unescape Escape View File

@ -27,7 +27,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gclient.py", "RECIPE_REPO[depot_tools]/gclient.py",
"recurse", "recurse",

2
recipes/recipe_modules/gclient/tests/diff_deps.expected/windows.json
Unescape Escape View File

@ -27,7 +27,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python3", "vpython3",
"-u", "-u",
"RECIPE_REPO[depot_tools]\\gclient.py", "RECIPE_REPO[depot_tools]\\gclient.py",
"recurse", "recurse",

Write Preview
Loading…
Cancel
Save