Don't fetch tags when fetching to deapply a patch.

Bug: 1019824 Change-Id: Ibec0b47067345150dbd2083265c49fb9b6769a3a Recipe-Nontrivial-Roll: build Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1894408 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
6 years ago · 23247b9932
parent 2fa5e57114
commit 23247b9932
18 changed files with 36 additions and 21 deletions
--- a/recipes/recipe_modules/bot_update/api.py
+++ b/recipes/recipe_modules/bot_update/api.py
@ -510,7 +510,5 @@ class BotUpdateApi(recipe_api.RecipeApi):
        bot_update_json['properties'][rev_property])
    self._resolve_fixed_revisions(bot_update_json)

-    # TODO(crbug.com/1019824): Pass |no_fetch_tags=True| here to prevent
-    # fetching 10k+ tags for chromium. This operation shouldn't need tags, it is
-    # removing a previously applied patch.
-    self.ensure_checkout(patch=False, update_presentation=False)
+    self.ensure_checkout(
+        patch=False, no_fetch_tags=True, update_presentation=False)
--- a/recipes/recipe_modules/bot_update/examples/full.expected/clobber.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/clobber.json
@ -119,7 +119,8 @@
      "--output_json",
      "/path/to/tmp/json",
      "--revision",
-      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9"
+      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/deprecated_got_revision_mapping.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/deprecated_got_revision_mapping.json
@ -125,7 +125,8 @@
      "--output_json",
      "/path/to/tmp/json",
      "--revision",
-      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9"
+      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_rebase_patch_ref.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_rebase_patch_ref.json
@ -119,7 +119,8 @@
      "--output_json",
      "/path/to/tmp/json",
      "--revision",
-      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9"
+      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_reset.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_reset.json
@ -119,7 +119,8 @@
      "--output_json",
      "/path/to/tmp/json",
      "--revision",
-      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9"
+      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/input_commit_with_id_without_repo.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/input_commit_with_id_without_repo.json
@ -118,7 +118,8 @@
      "--output_json",
      "/path/to/tmp/json",
      "--revision",
-      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9"
+      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/multiple_patch_refs.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/multiple_patch_refs.json
@ -122,7 +122,8 @@
      "--output_json",
      "/path/to/tmp/json",
      "--revision",
-      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9"
+      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/no_apply_patch_on_gclient.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/no_apply_patch_on_gclient.json
@ -169,7 +169,8 @@
      "--revision",
      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
      "--revision",
-      "src/third_party/angle@fac9503c46405f77757b9a728eb85b8d7bc6080c"
+      "src/third_party/angle@fac9503c46405f77757b9a728eb85b8d7bc6080c",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/refs.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/refs.json
@ -120,7 +120,8 @@
      "--output_json",
      "/path/to/tmp/json",
      "--revision",
-      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9"
+      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/reset_root_solution_revision.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/reset_root_solution_revision.json
@ -118,7 +118,8 @@
      "--output_json",
      "/path/to/tmp/json",
      "--revision",
-      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9"
+      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_angle.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_angle.json
@ -169,7 +169,8 @@
      "--revision",
      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
      "--revision",
-      "src/third_party/angle@fac9503c46405f77757b9a728eb85b8d7bc6080c"
+      "src/third_party/angle@fac9503c46405f77757b9a728eb85b8d7bc6080c",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_branch_heads.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_branch_heads.json
@ -166,7 +166,8 @@
      "--output_json",
      "/path/to/tmp/json",
      "--revision",
-      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9"
+      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_feature_branch.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_feature_branch.json
@ -166,7 +166,8 @@
      "--output_json",
      "/path/to/tmp/json",
      "--revision",
-      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9"
+      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_v8_feature_branch.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_v8_feature_branch.json
@ -169,7 +169,8 @@
      "--revision",
      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
      "--revision",
-      "src/v8@801ada225ddc271c132c3a35f03975671d43e399"
+      "src/v8@801ada225ddc271c132c3a35f03975671d43e399",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json
@ -169,7 +169,8 @@
      "--revision",
      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
      "--revision",
-      "src/third_party/webrtc@HEAD"
+      "src/third_party/webrtc@HEAD",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8.json
@ -169,7 +169,8 @@
      "--revision",
      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
      "--revision",
-      "src/v8@801ada225ddc271c132c3a35f03975671d43e399"
+      "src/v8@801ada225ddc271c132c3a35f03975671d43e399",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8_head_by_default.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8_head_by_default.json
@ -169,7 +169,8 @@
      "--revision",
      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
      "--revision",
-      "src/v8@801ada225ddc271c132c3a35f03975671d43e399"
+      "src/v8@801ada225ddc271c132c3a35f03975671d43e399",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [
--- a/recipes/recipe_modules/bot_update/examples/full.expected/with_tags.json
+++ b/recipes/recipe_modules/bot_update/examples/full.expected/with_tags.json
@ -119,7 +119,8 @@
      "--output_json",
      "/path/to/tmp/json",
      "--revision",
-      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9"
+      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+      "--no_fetch_tags"
    ],
    "env_suffixes": {
      "PATH": [