[git_common] Add type annotations

Bug: b/351071334
Change-Id: I876db267bdd8d876a22d4582bd6505705d1c38ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5754254
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
changes/54/5754254/4
Allen Li 7 months ago committed by LUCI CQ
parent 29838db8fe
commit 0cb94fcfa9

@ -358,7 +358,9 @@ def blame(filename, revision=None, porcelain=False, abbrev=None, *_args):
return run(*command) return run(*command)
def branch_config(branch, option, default=None): def branch_config(branch: str,
option: str,
default: Optional[str] = None) -> Optional[str]:
return get_config('branch.%s.%s' % (branch, option), default=default) return get_config('branch.%s.%s' % (branch, option), default=default)
@ -402,7 +404,7 @@ def branches(use_limit=True, *args):
yield line.split()[-1] yield line.split()[-1]
def get_config(option, default=None): def get_config(option: str, default: Optional[str] = None) -> Optional[str]:
return scm.GIT.GetConfig(os.getcwd(), option, default) return scm.GIT.GetConfig(os.getcwd(), option, default)
def get_config_int(option, default=0): def get_config_int(option, default=0):
@ -581,17 +583,17 @@ def get_branch_tree(use_limit=False):
return skipped, branch_tree return skipped, branch_tree
def get_or_create_merge_base(branch, parent=None): def get_or_create_merge_base(branch, parent=None) -> str:
"""Finds the configured merge base for branch. """Finds the configured merge base for branch.
If parent is supplied, it's used instead of calling upstream(branch). If parent is supplied, it's used instead of calling upstream(branch).
""" """
base = branch_config(branch, 'base') base: Optional[str] = branch_config(branch, 'base')
base_upstream = branch_config(branch, 'base-upstream') base_upstream = branch_config(branch, 'base-upstream')
parent = parent or upstream(branch) parent = parent or upstream(branch)
if parent is None or branch is None: if parent is None or branch is None:
return None return None
actual_merge_base = run('merge-base', parent, branch) actual_merge_base: str = run('merge-base', parent, branch)
if base_upstream != parent: if base_upstream != parent:
base = None base = None
@ -616,6 +618,7 @@ def get_or_create_merge_base(branch, parent=None):
base = actual_merge_base base = actual_merge_base
manual_merge_base(branch, base, parent) manual_merge_base(branch, base, parent)
assert isinstance(base, str)
return base return base

Loading…
Cancel
Save