5685 Commits (f6c50564cd5f2314ee3b6ef449519bd193910b1b)
 

Author SHA1 Message Date
Adriaan de Groot b23f4f3bb0 Merge branch 'issue-1164'
FIXES #1164
6 years ago
Adriaan de Groot 4f221b41d1 [libcalamares] Close stdin on process jobs
- This avoids processes that wait on stdin, and e.g. improves
   reaction to having just "cat" (no file) in a command, or
   a package manager that asks for input.
6 years ago
Adriaan de Groot 4e13f780f1 [libcalamares] Expand tests for runCommand
- try both with and without a working-directory set, this would have
   shown up the problem with bad indentation much earlier.
6 years ago
Adriaan de Groot 7be33b8196 [libcalamares] runCommand doesn't need queue or settings
- JobQueue is only needed to get global settings, which are needed
   when running in the target; for host commands, allow running
   without a queue.
 - Settings is needed for the value of debugsettings; assume if
   there's no settings object, that we're in a test and should
   print debugging information.
6 years ago
Adriaan de Groot 5a835f32b8 [libcalamares] Start extending tests to runCommand() 6 years ago
Adriaan de Groot 07a59bd09c [libcalamares] All commands with workingDirectory failed
- This is the same as EFAIL: a block is indented as if it's a multi-
   line else block. This isn't Python though, and the return always
   applies.
 - Add the necessary braces.
 - Apparently noone uses this code path (until ProcessJob was re-
   factored to do so).
6 years ago
Adriaan de Groot d7f5134121 [libcalamares] Be more verbose in error situations
- runCommand can return NoWorkingDirectory in multiple places,
   make sure the log contains a more specific reason.
6 years ago
Adriaan de Groot b587d77e31 [libcalamares] Fix untranslatable string.
- This would substitue an untranslated "in chroot" into the
   translated string, which is weird.
6 years ago
Adriaan de Groot 6055f08aff [libcalamares] Refactor ProcessJob
- Use the system runCommand() instead of a 90% copy of it.
   This **does** change the overall command to `env /bin/sh -c`
   rather than running only `/bin/sh -c`, though.
6 years ago
Adriaan de Groot 92d03c2cf7 [libcalamares] Introduce enum class for special process exit values
- Replace magic numbers like -3 with named enum values
   (NoWorkingDirectory, for -3).
 - Downside is big-ugly static_casts, but that's what you get
   for having an int as return value for processes.
6 years ago
Adriaan de Groot 61b78d8895 [libcalamares] Stop job threads before exit
- This solves a crash where the thread is destroyed while still
   running (e.g. cancelling during install).
 - The thread might not cooperate in being terminated, but then we
   have a bigger problem anyway (and Calamares will still crash on
   exit).

FIXES #1164
6 years ago
Adriaan de Groot e49beaea91 CMake: switch WITH_PYTHONQT default to OFF 6 years ago
Adriaan de Groot 0619f19536 CMake: post-release housekeeping 6 years ago
Calamares CI a7e5488f77 i18n: [python] Automatic merge of Transifex translations 6 years ago
Calamares CI bbc0edecd3 i18n: [dummypythonqt] Automatic merge of Transifex translations 6 years ago
Calamares CI 21f6ff0e60 i18n: [calamares] Automatic merge of Transifex translations 6 years ago
Adriaan de Groot 40d1856bb1 Changes: remove reference to QML loading, add some issue numbers 6 years ago
Adriaan de Groot 3335c2003e [fsresizer] Fix tests
- Again? The checks on the job name (using filesystem or device
   name) all looked very bogus, unless it was previously not
   setting them at all.
6 years ago
Adriaan de Groot 6dc83d692c CMake: pre-release housekeeping 6 years ago
Adriaan de Groot de34cacadd Document (hoped-for) speedups in slideshow loading. 6 years ago
Calamares CI bdac6d1e30 i18n: [python] Automatic merge of Transifex translations 6 years ago
Calamares CI 8f553c0b61 i18n: [calamares] Automatic merge of Transifex translations 6 years ago
Adriaan de Groot 2b5cf9e613 [libcalamaresui] There is code in Qt for setting up QML widgets
- The not-publicly documented setContent() method does all the
   parenting and resizing needed; some of this isn't available
   from outside of the widget either.

The QML slideshow now sizes and re-sizes correctly.
6 years ago
Adriaan de Groot f52d62034b [libcalamaresui] Manual QML loading trickery
- The slideshow item needs a parent to be visible,
 - QML gets size 0,0 unless explicitly sized to the surrounding widget.
6 years ago
Adriaan de Groot 103decab68 [libcalamaresui] Create the slideshow on activation
- Load QML on startup, compile async
 - Create QML component when the page is reached.
 - On leave, stop the slideshow (otherwise, e.g. timers will keep running)

This should move some of the delay from loading a large
slideshow forward as the engine is already initialized when
we reach the install / slideshow page.
6 years ago
Adriaan de Groot daf2e55246 [branding] Be more chatty in example slideshow
- Log when the timer fires and the slide advances
 - Add a start() function (unused at this moment, will be
   called from C++ at the right time)
6 years ago
Adriaan de Groot ff03235e33 [libcalamaresui] Load QML on startup 6 years ago
Adriaan de Groot 5973dbf74c [libcalamaresui] Shuffle code for QML slideshow
- Create widgets earlier
 - Group layouting code
 - Add retranslator only once, not on every activate
 - Load QML only once, preferably at activation
6 years ago
Adriaan de Groot cbe14bbf03 [libcalamaresui] Rename m_slideShow -> m_qmlShow
- It could be any QML, so it's not a slideshow per se.
 - Minor prep-work for fixing up loading times.
6 years ago
Adriaan de Groot 8506949ecd Changes: Document new welcome-theming 6 years ago
Adriaan de Groot 4c6218f005 Merge branch 'brand-language' 6 years ago
Adriaan de Groot f54b7dee9f [welcome] Use convenience image loader from Branding 6 years ago
Adriaan de Groot 07c638ed48 [welcome] Allow theming the international language-select icon 6 years ago
Adriaan de Groot 75ce391e7e [libcalamaresui] Add branding-aware function for loading image by name 6 years ago
Adriaan de Groot 1438729b72 [libcalamaresui] Do filename checks more sanely
- check directory exists before trying to open file from it
 - re-use the componentDir already found for later tests.
6 years ago
Adriaan de Groot 69dabcae32 [libcalamares] Avoid static destructor
- The static destructor issues a warning on exit:
       QBasicTimer::start: QBasicTimer can only be used with threads
       started with QThread
   so instead, heap-allocate the model. This leaks memory, but
   it's a singleton *and* we're exiting anyway.
6 years ago
Adriaan de Groot a263381996 [partition] Avoid an assert when running Calamares as user. 6 years ago
Adriaan de Groot 1ef902a41f Merge branch 'issue-1141'
FIXES #1141
6 years ago
Adriaan de Groot 4a6b9f3528 [partition] Call update from init() in BootLoaderModel
- update() (might) add some extra rows for boot and root,
   which otherwise vanish temporarily when calling init.
6 years ago
Adriaan de Groot d5f0bdd28c [partition] Simplify negative logic
- Instead of multiple continue statements to avoid negative cases,
   state the one positive case instead.
6 years ago
Adriaan de Groot 3bdbfe6bff [partition] Avoid crash if combobox is gone and model resets
- Since the lambda is connected to the model only, it should
   check that the target combo exists as well.
6 years ago
Adriaan de Groot 2ce2b08027 [partition] Indent lambdas to tab-stop.
- Lambdas are all over the place in this codebase, formulate
   a standard and start adjusting code to it in passing.
6 years ago
Adriaan de Groot 353e713f81 [partition] Complain loudly on dangling Partition pointers
- Don't crash if a bad pointer gets into colorutils.
6 years ago
Adriaan de Groot 2bc95d11d3 [partition] Unrelated typo in comment 6 years ago
Adriaan de Groot f1f5b6c1bb [partition] Restore BootLoader path in Choice Page
- after model resets, restore what was previously selected.
 - This avoids having an **empty** combobox, SEE #1141 but does
   not actually set it back to the value the user had previously
   picked (e.g. changing swap settings **still** breaks the
   selection).
6 years ago
Adriaan de Groot 0ebabfafd4 [partition] Move BootLoaderModel convenience functions
- These were hidden inside PartitionPage, but are useful elsewhere.
6 years ago
Adriaan de Groot a2e54fcf65 Changes: prep for release 6 years ago
Philip Müller b9686a8a84
[Authors] Philip only needs to be listed once
I don't need to be listed more then one time ;)
6 years ago
Adriaan de Groot 8d451622db [partition] Idiomatic use of Calamares::JobList 6 years ago
Adriaan de Groot e2b71e669e [partition] When running UNSAFE, no-install-partition is a warning 6 years ago