3983 Commits (dcebb1ae9b91a1833626bfc74ee6dd7eada6304d)

Author SHA1 Message Date
Adriaan de Groot 432b8848ab [libcalamares] Make #include guards consistent 7 years ago
Adriaan de Groot f076dd76ad [libcalamares] Rename YamlUtils.h
- Since we have the utils/ filesystem namespace, and use CalamaresUtils::
   as C++ namespace, simplify naming.
7 years ago
Adriaan de Groot 090aee9196 Modules: adjust to split-out utils/Variant.h
- Most modules only needed the variant support, not the "whole"
   CalamaresUtils header.
 - While here improve ordering of headers as well.
7 years ago
Adriaan de Groot 6e0e06078b [libcalamares] Split out the variant-manipulation bits
- We already have utils/ as the filesystem namespace, may as well
   make clearer what the various parts are.
 - Adjust CommandList to the moved API.
7 years ago
Adriaan de Groot 3e011d1419 [libcalamares] Don't link with PythonQt
- PythonQt is only needed (and used) from the GUI library.
7 years ago
Adriaan de Groot d2dd4fd76b Modules: Improve error reporting
- Remaining modules [networkcfg] [openrcdmcryptcfg] [rawfs] with
   code that throws on bad configuration. Replace with meaningful
   error messages, to better check cases of SyntaxError &c.
7 years ago
Adriaan de Groot 7d0874e23b [mount] Bail on bad config
- One might argue whether an empty list of partitions to mount is
   a bad thing. It suggests that the partition module wasn't used,
   and so we're in an OEM situation -- but then everything should
   already be mounted anyway. That's why I choose empty -> bail.
7 years ago
Adriaan de Groot ec0fe2ccd3 Modules: Improve error reporting
- [initcpio] remove superfluous inner function
 - [initcpio] catch errors from mkinitcpio itself and report them in a nice
   readable format.

 - Save translators the effort of doing a dozen messages
   with just the name of the module changed. All of these modules
   bail out on bad configurations with a meaningful message.
   - [initcpiocfg]
   - [fstab]
   - [initramfscfg]
   - [localecfg]
   - [luksbootkeyfile]
   - [luksopenswaphookcfg]

 - [machineid] Warn on bad config. It's conceivable that this is run
   with an empty rootMountPoint (i.e. "") to modify the running system,
   so only bail on None.
7 years ago
Adriaan de Groot 1f7dfafe9a [libcalamares] Provide accessor to error code.
- Document meaning of error codes.
 - The test-loader considers internal errors a real (test) failure,
   while errors returned normally by the modules (e.g. because the
   configuration is broken) to be ok for testing purposes.
7 years ago
Adriaan de Groot 7149b80146 [libcalamares] Distinguish kinds of errors
- errors can now carry an integer what-am-I code apart from
   the message; all errors have a code != 0 (and ok has code 0).
7 years ago
Adriaan de Groot b8be07573b [initramfs] Fix syntax error 7 years ago
Adriaan de Groot e072b76fea [shellprocess] [contextualprocess] Unneeded module.desc
- C++ modules should have a CMakeLists.txt which does the
   right thing, e.g. calamares_add_plugin() , and don't need
   a textual module.desc
7 years ago
Adriaan de Groot 6f9548af34 CMake: Check module interfaces
- Only allow meaningful interface strings
 - Improve documentation of which interfaces work for
   which module types.
7 years ago
Adriaan de Groot f8bc40ba91 [calamares] (test-app) loadmodule exit code 1 on failures
- If the module fails to load, or runs with an error, exit
   with code 1.
7 years ago
Adriaan de Groot 9700359cab [calamares] In (test-app) loadmodule, log failure as error
- Errors were being logged as debug output, which is normally
   hidden (e.g. unless -D6 is passed to turn on debugging).
7 years ago
Adriaan de Groot cf08e59501 [localecfg] Add missing import 7 years ago
Adriaan de Groot ca3110d429 [partition] Drop extra ; (warnings--) 7 years ago
Adriaan de Groot e8264a4503 [partition] Prefer GPT on EFI systems for new partition table 7 years ago
Adriaan de Groot a68a381481 [license] Fix compiler warnings
- out-of-order and incomplete initialization
 - documentation style
 - missing assignment operator
7 years ago
Adriaan de Groot 516b3b4b6c [partition] Adjust to logging-API changes
- missed due to #ifdef on a KPMcore API version I don't have on
   my main workstation.
7 years ago
Adriaan de Groot 3ddb49afb7 Merge branch 'issue-1061'
FIXES #1061
7 years ago
Adriaan de Groot 74d42fe229 [summary] Tidy scrollbar handling
- Handle different window-expansion strategies
7 years ago
Adriaan de Groot 3533bb3c2d Merge branch 'master' into issue-1061 7 years ago
Adriaan de Groot 52f824289e Changes: document license module changes
- also document applicable stylesheet ids
7 years ago
Adriaan de Groot 3ab9c0efdf Merge branch 'issue-1052'
FIXES #1052
7 years ago
Adriaan de Groot 58770037f4 [license] Allow more things locally
- If it says file:, it's local (don't require a specific file
   extension).
 - Report actual path loaded.
7 years ago
Adriaan de Groot ca870a6d41 [license] Update example
- Explain that the GPLv3 isn't actually a proprietary license, but
   is used as convenient text for the license page.
 - Invent a Calamares, Inc.
7 years ago
Adriaan de Groot 3608f62ec0 [license] Adjust tooltip and button texts
- Handle various states of the link and tool buttons,
   give them appropriate texts and tooltips.
7 years ago
Adriaan de Groot 4ce6fdbd90 [license] Make area scrollable
- Since the list of license entries may be long (especially
   if the text is expanded) make it scrollable.
7 years ago
Adriaan de Groot f0d26a74b7 [license] Set object names
- This is prep-work now that the CSS styling branch has merged
7 years ago
Adriaan de Groot e9a295dfe5 [branding] Add example (empty) CSS file 7 years ago
Adriaan de Groot 08e4090354 Merge remote-tracking branch 'origin/raurodse-branding'
FIXES #961
7 years ago
Adriaan de Groot 982a3fb372 [license] Apply stylesheet so displayed text is nicer. 7 years ago
Adriaan de Groot 4bdae0cab0 [license] Load full license text if local
- Load full text, toggle display
 - Swap Up and Down arrow semantics on button, to match usual
   text-editor display (down means it's expanded, displayed)
7 years ago
Adriaan de Groot 92a3666dce [license] Simplify isLocal() by using Qt method 7 years ago
Adriaan de Groot ddf541774b [license] Make local and external links more consistent
- Capitalization of message
 - Add a right-pointing "open" button to external links as well
7 years ago
Adriaan de Groot a216b5ca76 [libcalamaresui] Misplaced const 7 years ago
Adriaan de Groot c696b5c19d [license] Add show-license toggle button
- Non-functional as yet
 - Toggles expand / collapse arrow and tooltip
7 years ago
Adriaan de Groot b7ddb39105 [libcalamaresui] Massage disable-cancel code
- Even when Cancel is hidden, also disable it (prevents DBUS
   triggers, for instance),
 - Re-enable it when exec is over, if it's disabled then.
 - simplify code a little.
7 years ago
Adriaan de Groot d506296aa7 [libcalamares] Adjust code to changed name
- renamed setting in the configuration file, but not in the code
 - add documentation to getters
7 years ago
Adriaan de Groot 10727c7bd9
Merge pull request #1126 from feren/patch-3
Patch to add 'dont-cancel' setting to disable Cancel only during the installation phase
7 years ago
Adriaan de Groot 3b7b0d6f04
Merge branch 'master' into patch-1 7 years ago
Adriaan de Groot 32ed3f6db6 [license] Add GPLv3 as an example in the license.conf 7 years ago
Adriaan de Groot cb80d47682 [license] Move translation / retranslation to LicenseWidget
- Language change didn't otherwise apply to the license items
7 years ago
Adriaan de Groot 1235207ead [license] Refactor LicenseWidget
- Move all the widget code into its own file
7 years ago
Adriaan de Groot 35f23c86c6 [license] Add stub LicenseWidget files
- Prepare for refactoring
 - Clean up weirdness in the CMakeLists.txt
7 years ago
Adriaan de Groot d2957fbad3 [license] Handle the case where all the licenses are optional
- If all of the licenses are optional, you should be able to
   continue without accepting. Refactor to a single visible
   slot to check the conditions.
 - Always set the globalsettings value; to "false" on entry
   to make sure it's there.
 - When setting the list of entries, check the conditions
   (because if the list is empty, or all of them are optional,
   then it's ok to continue).

FIXES #1124
FIXES #1125
7 years ago
Adriaan de Groot c245238b89 [license] Use standard algorithms, simplify code
- Introduce isRequired() for readability later
 - Use std::any_of instead of rolling own loop
7 years ago
Adriaan de Groot 937f332441 [license] Refactor LicenseEntry
- Follow Calamares conventions for member naming
 - Switch to struct since everything is public anyway
7 years ago
Adriaan de Groot dc006d58b2 [license] Use NamedEnum 7 years ago
Adriaan de Groot 614bd3c6de [license] Move logic to LicenseEntry class 7 years ago
Adriaan de Groot 81016667ae [license] Change to enum class
- non-functional change, just chasing modern C++
7 years ago
Adriaan de Groot f299b86a3b [license] start to document license.conf
- document keys and values in a way consistent with other modules
 - document **intended** use of local URLs.
7 years ago
Adriaan de Groot e326b658ef Enable translation in Python modules
- covers all the remaining Python modules
 - most only get a translatable pretty name, some also return
   error messages
7 years ago
Adriaan de Groot c364e4fc38 [dracut] [fstab] Translate module names and error messages 7 years ago
Adriaan de Groot ff6a3608a6 [mount] [networkcfg] [openrcdmcryptcfg] Translate module name 7 years ago
Adriaan de Groot dd5c0d1629 [bootloader] Log when the bootloader-module does nothing 7 years ago
Adriaan de Groot 333f0d9215 [bootloader] Simplify finding the ESP 7 years ago
Adriaan de Groot df37c51c1e [bootloader] [hwclock] Translate module name 7 years ago
Adriaan de Groot c44e221fb6 Merge branch 'issue-1107'
FIXES #1107
7 years ago
Adriaan de Groot cb5825a521 [libcalamares] English label with country 7 years ago
Adriaan de Groot 81acc496dc [welcome] Introduce a delegate for drawing the languages list
- Show the native name left, English name right
7 years ago
Adriaan de Groot 0b833b1e75 [welcome] Switch model to a list model
- There doesn't seem to be a real benefit to providing the
   name and label as separate columns.
7 years ago
Adriaan de Groot 53fd1590b8 [welcome] Don't use combobox itemdata for locale information 7 years ago
Adriaan de Groot e5d1c0ae27 [welcome] Fix matched-with-a-locale
- Previously the matchLocale() function set the index in the
   combobox; do it separately now.
7 years ago
Adriaan de Groot 57452b8c38 [locale] [welcome] Adjust to moved LocaleLabel
- Adjust #includes
 - In [welcome], use find() on the model rather than querying
   the combo-box.
7 years ago
Adriaan de Groot 58aa9f4989 [libcalamares] Move LocaleLabel from libcalamaresui to libcalamares
- This isn't a UI-dependent class
 - Doesn't make much sense in CalamaresUtilsGui either
7 years ago
Adriaan de Groot 242d756731 [libcalamaresui] Add convenience name() to LocaleLabel 7 years ago
Adriaan de Groot 0c868dbd17 [welcome] Another find() overload
- Also find a specific locale
 - While here, apply Calamares coding style
7 years ago
Adriaan de Groot 314aee8d68 [welcome] Switch to QVector
- QVector is a better match with passing in QStringList, otherwise
   you end up dealing with Qt's int indexes vs. std::vector's uint
   indexes everywhere.
 - Introduce find()
7 years ago
Adriaan de Groot bd0af4bb77 [libcalamaresui] Give LocaleLabel a default constructor
- Needed for use in containers
 - While here refactor building the english label
7 years ago
Adriaan de Groot 94765d40cd [welcome] Switch to using LocaleModel for language combobox
- Use the model instead of inserting items
 - While here, tidy includes and documentation
7 years ago
Adriaan de Groot 589168685e [welcome] Complete LocaleModel implementation
- It's a table with two columns (localized name and english name)
7 years ago
Adriaan de Groot 7f8411c3b7 [welcome] Add standard language-chooser icon
- After discussion with Red Hat UI advice, switch to standard icon
 - Tooltip as well
7 years ago
Adriaan de Groot f04d084548 [welcome] Start on a model for the locale choices 7 years ago
Adriaan de Groot c99742bc70
Merge pull request #1127 from a-wai/partition-layout-size-checks
Add various checks for partition layout configuration
7 years ago
Adriaan de Groot cf51eb7aab [keyboard] Apply source formatting
- Move errant attribution line to the copyright headers;
   unsure of the year though.
 - Apply Calamares coding style.
7 years ago
Adriaan de Groot 118f9255fd [keyboard] Refactor sectioning
- Look for section in a consistent fashion
 - Simplify parsing loops
7 years ago
Adriaan de Groot fa70b3aa60 [keyboard] Refactor keyboard model loading
- Don't need private static methods
 - Pass char* if that's what we've got
7 years ago
Adriaan de Groot 3c014a868c [keyboard] Make keyboard preview more robust
- Replace #define with static const char
 - Handle FreeBSD as well (for testing purposes)
7 years ago
Adriaan de Groot b704933b58 [keyboard] Avoid crash with unconfigured keyboards
- If there's no items at all, ->currentItem() can return nullptr,
   so don't dereference that.

Found on FreeBSD.
7 years ago
Adriaan de Groot 3e88b408fa [calamares] Remove unused item Role 7 years ago
Adriaan de Groot 3ccbcdc1bd [libcalamares] Don't moc on JobQueue
- There is no reason for JobThread to have a Q_OBJECT macro,
   so drop the moccing (this also stops some warnings from
   the generated moc code).
 - Define the (virtual) destructor out-of-line to avoid vtable
   warnings.
7 years ago
Adriaan de Groot a1e08d2236 [keyboard] Don't use useless rvalue-ref
- Weird && usage here made redundant through RVO, just return
   something normally instead.
7 years ago
Adriaan de Groot 123c774a47 Use new automoc options 7 years ago
Adriaan de Groot bdb7bf71a8 Reduce warnings from moc-generated code
- The auto-generated code produces a lot of warnings from
   Clang 8; this obscures the more meaningful warnings from
   actual Calamares code, so tone the warnings down.
 - For Clang, set CALAMARES_MOC_OPTIONS.
 - Add convenience CMake function for automoccing. It applies
   the options as needed to a given target.
7 years ago
Adriaan de Groot cef2f50510 Reduce warnings about extra ;
- Trailing ; after Q_UNUSED
 - Trailing ; after CALAMARES_RETRANSLATE
7 years ago
Adriaan de Groot c83395ff6d Reduce warnings for yaml-cpp
- Use only utils/YamlUtils.h to pull in yaml-cpp and supporting code.
 - When compiling with clang, turn off warnings that the system header
   for yaml-cpp would generate.
7 years ago
Adriaan de Groot 27140ff5bb [libcalamares] Reduce warnings in KDAB code
- This is an older copy of kdsingleapplicationguard, now updated for
   C++11 warnings; removed __ in header guards, fixed up last of 0-for-
   nullptr, signedness mismatch.
7 years ago
Arnaud Ferraris 123222c0a8 Add global checks for partition layout
This commit adds several checks while reading the configuration of the
`partition` module, in case the partition layout configuration is
misformed. If an error is encountered, an message is printed to the
console and the module reverts to the default partition layout.

Checks are also added when implementing the partition layout, in case a
problem occurs that couldn't be anticipated (for example, when a
partition size is in %, checking its absolute value require knowing the
total device size, which is not the case when the configuration is
being read).

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
7 years ago
Arnaud Ferraris d32733bf59 Switch to using PartSize class for partition sizes
Every call of `ParseStringSize` is replaced by using an instance of the
`PartUtils::PartSize` class.

This commit also removes the now-unused previous size parsing functions.

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
7 years ago
Arnaud Ferraris 3a58ae5e8b Introduce new partition size class based on NamedSuffix
In order to maintain consistency, and make use, create a new PartSize
class in the PartUtils namespace, which inherits from NamedSuffix for
easier parsing and handling of size strings.

The switch to using this class instead of the previous functions will be
done in a follow-up commit.

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
7 years ago
Arnaud Ferraris 680b0bc472 Add missing header to NamedEnum
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
7 years ago
Adriaan de Groot 92b60dac65 [libcalamares] Warnings-- over extra ; 7 years ago
Adriaan de Groot 620940c75b [libcalamaresui] Drop now-unused sortKey from LocaleLabel
- sortKey is unused
 - add englishLabel for reverse-i18n
7 years ago
The feren OS Dev a7ac046b3d
Update copyright headers 7 years ago
The feren OS Dev 9cafd0a495
Update copyright headers 7 years ago
The feren OS Dev 455505ba78
Update copyright header 7 years ago
The feren OS Dev 825c92582a
Update ViewManager.cpp 7 years ago
The feren OS Dev 700e6f0ec6
Update Settings.h 7 years ago
The feren OS Dev 6d6c152f70
Update Settings.cpp 7 years ago
The feren OS Dev d31f2d2116
Update Settings.cpp 7 years ago
The feren OS Dev 02d6e1a946
Update Settings.cpp 7 years ago
The feren OS Dev a79dfa4135
Added myself to the copyright header 7 years ago
The feren OS Dev c0d61b666d
Made amendments based on review
Fixed 'prepend' terminology in comments, restored old loop as it seems to work for me now in overwriting the file as one overall multiline instead of overwriting the file with each line at a time, code simplification based on review comments... credits-adding will come in the next commit.
7 years ago
Adriaan de Groot 5e951466df [libcalamaresui] Sort languages by ISO code
- this puts the Englishes together, and is less confusing than
   sorting with American first.
7 years ago
Adriaan de Groot 329bd36929 [libcalamares] Sanitize logging 7 years ago
Adriaan de Groot 93be1a6582 [partition] Remove confusing spaces in logging 7 years ago
Adriaan de Groot dbac9ecf7b [partition] Remove unused code
- The name table is in PartitionActions::Choices
7 years ago
Adriaan de Groot d2404851cd [partition] Reduce warnings (shadow, ;, types) 7 years ago
Adriaan de Groot 1a4a265262 [partition] Refactor check for ISO9660 7 years ago
Adriaan de Groot 75f1a05fec [partition] No copy-constructor for CDebug 7 years ago
Adriaan de Groot 009dfd7de5 [locale] Reduce warnings (shadowed global) 7 years ago
The feren OS Dev 3ecd031d9d
Better LightDM Autologin Support
This change fixes a few issues and adds a few improvements to the LightDM Autologin configuration process:

Fixes:

- Fixes malforming of configuration file out of the box, as without `[SeatDefaults]`, `[Seat:*]` or similar in the configuration file LightDM will break on a lot of distributions using LightDM

- Preserves the intended lightdm.conf file settings outside of `autologin-user` if the distribution has an /etc/lightdm/lightdm.conf file of its own

Misc. changes:

- Small spelling fix
7 years ago
Adriaan de Groot ef3b4c387c [libcalamaresui] Remove unused AbstractPage 7 years ago
Adriaan de Groot 4fec6731ba [calamares] [libcalamaresui] Improve includes
- avoid useless ../
 - sort alphabetically and by kind
7 years ago
Adriaan de Groot 520478847c Make logging more consistent.
- Across all the C++ modules, use Logger::SubEntry for sub/continues
   log lines, instead of somewhat-random indent strings.
7 years ago
Adriaan de Groot d6cf0617f6 [libcalamaresui] Make logging more consistent 7 years ago
Adriaan de Groot aaeea16871 [libcalamares] Make logging more consistent 7 years ago
Adriaan de Groot 8bb07528e2 [calamares] Make logging output more consistent
- Use Logger::SubEntry instead of various indents
 - Improve wording of message
7 years ago
Adriaan de Groot 5677a4bb28 [finished] Fix up string arguments
- The "set up" message only uses one argument.
7 years ago
Adriaan de Groot 63b317902d [libcalamares] [partition] Adjust to logging changes
- Use the un-paren'ed Continuation and SubEntry
7 years ago
Adriaan de Groot d72e3b3c22 [libcalamares] Simplify writing of logging continuations
- Instead of Continuation(), write just Continuation
 - All that futzing with overloads and tag-classes isn't needed
   since the whole point is to output some constant string. Leave
   cleverness for later, if it's needed.
7 years ago
Adriaan de Groot 198acadd23 [partition] [fsresizer] Fix KPMCore API versions
- tests need the defines as well
 - scandevices API changed with API 3.3.1
7 years ago
Adriaan de Groot c844188907 [partition] Fix build w/ "3.3.1" API
- Need older-style scanning, but new-style iteration
7 years ago
Adriaan de Groot 4e24ea29e2 [partition] [fsresizer] Adjust to post-3.3.0 API
- KDE neon ships a post-3.3.0 KPMCore, with deprecations, but not yet
   the KPMCore 4 API, so add another API-version check to handle the
   deprecations. Keeps warnings down.
7 years ago
Adriaan de Groot c0710cabe4 [partition] [fsresizer] Adjust to new #define
- Using KPMCORE4API is clearer than just relying on a version number
7 years ago
Adriaan de Groot 9159761171 [partition] [fsresizer] Fix KPMCore API detection
- There will be a 3.3.1 which still has the "old" API,
   so look at 3.3.80 (pre-4.0) instead. Make the way
   compile flags are passed consistent.
7 years ago
Adriaan de Groot 9917bc27fc
Merge pull request #1119 from cjlcarvalho/master
[partition] Fixing LVM scanning according to new kpmcore API
7 years ago
Adriaan de Groot 1a063a9b5d [partition] Use modern tr() annotation 7 years ago
Adriaan de Groot e664370b28 [libcalamaresui] Use modern tr() annotation 7 years ago
Adriaan de Groot b6cd1c576a [plasmalnf] Don't translate placeholder text 7 years ago
Adriaan de Groot 78d6b51c3c [partition] Don't translate placeholder --- 7 years ago
Adriaan de Groot 369c5f4619 [tracking] Don't translate placeholder text 7 years ago
Adriaan de Groot d0e1e46df2 [users] Don't translate CSS 7 years ago
Adriaan de Groot 95897bf83b [users] Mark as not-translated 7 years ago
Adriaan de Groot 5a95bf507f [libcalamaresui] Improve WindowDimensions class
- Make sure the class knows its own suffixes
7 years ago
Adriaan de Groot 6560c194ad [libcalamaresui] Reduce 0-for-nullptr warnings in 3rd party code
- replace = 0 with = nullptr to reduce warnings; not a meaningful
   or copyrightable change.
7 years ago
Adriaan de Groot 1008a91eba [libcalamaresui] Reduce warnings
- getting a (sensible) uint from an int is tougher than you might think
7 years ago
Adriaan de Groot 8dd22dcbbf [libcalamaresui] bail() is a [[noreturn]] function 7 years ago
Adriaan de Groot 365f83b789 [libcalamares] Reduce warnings in KDAB code
- Use nullptr and suitable include guards
7 years ago
Adriaan de Groot 2777b5dd30 [libcalamares] Reduce copying and warnings 7 years ago
Adriaan de Groot 5279e78c9f [libcalamares] Reduce warnings
- improve variable names, don't shadow
7 years ago
Adriaan de Groot c13c7c4891 [libcalamares] Don't use (bare) endl
- Use '\n' instead of endl (which should have been std::endl).
7 years ago
Adriaan de Groot d2941d335e [libcalamares] Reduce unused-parameter warnings
- The tag-class "parameters" are empty anyway
7 years ago
Adriaan de Groot b416842c20 [calamares] Reduce compile warnings in tests
- Switch debug-level to unsigned
 - Don't shadow usings; the first TR type is enough
 - The (bogus) return values were commented as // NOTREACHED,
   but still yield unreachable code warnings. Drop them
   instead, and rely on the compiler understanding [[noreturn]]
   on parser.usage().
7 years ago
Adriaan de Groot b10c7ad9c6 [locale] Reduce warnings for gcount()
- The read is at most sizeof(arr), so int is fine. Do
   the cast explicitly.
7 years ago
Adriaan de Groot 620d2a769a [users] Reduce compile warnings
- Avoid C-style casts
 - Unfortunately needs some verbose casting machinery to do
   it "right" wrt. C++ type system.
7 years ago
Adriaan de Groot 189e192c83 [shellprocess] Reduce warnings
- The old-style cast still causes a warning, but do the
   more idiomatic (void) rather then casting to (void*)
7 years ago
Adriaan de Groot 6cfb5a9c88 [welcome] Reduce unused-parameter warnings
- Don't use this if we don't need it (QObject::tr is static).
 - C++14 allows (copy) binding to arbitrary expresstions in lambda's,
   so detach from this.
7 years ago