Commit Graph

7848 Commits (c22e0a345103659d293d9708670c5dc8e123b95f)
 

Author SHA1 Message Date
Adriaan de Groot c22e0a3451 [netinstall][users][tracking] Warnings--, extra ;
Adriaan de Groot e2f6817536 Merge branch 'issue-1176' into calamares
This doesn't actually implement the job-weight work, but lays important
groundwork in module instances and descriptors.

SEE 
FIXES 
FIXES 
Adriaan de Groot f73f94da27 Repait module.desc
- a handful of modules had an unused *requires* key in module.desc;
  this is probably from previous intentions around
  prerequisites-testing. Since the settings were empty anyway,
  they have been removed.
- [unpackfs] Compacted the way *requiredModules* list is written
Adriaan de Groot efd7145f76 [libcalamares] Implement the interface-specific fields for descriptor
Adriaan de Groot c8b96c278b [libcalamares] Complete the generic module descriptor
- loads emergency, noconfig, requiredModules keys
- warns (and marks descriptor invalid) if there are unused / unknown
  keys left over in the descriptor data.
Adriaan de Groot e406ae1967 [libcalamares] Add name to module descriptor
- introduce basic tests of the data structure
- interpret name when passed in as descriptor data
Adriaan de Groot e1e81bb133 [libcalamaresui] Warnings--, don't shadow a parameter
Adriaan de Groot f1bb70269f [libcalamares] Improve warning/error logging
- the lack of a space after the : was inconsistent with most of the
  rest of the logging.
Adriaan de Groot 65273a262b [libcalamares] Start putting data into the module Descriptor
Adriaan de Groot 60fbf04594 [calamares] Adjust module test-loader for changed API
- the test-loader needs to create modules (and does so hackishly,
  outside of the ModuleManager) so it needs to chase the API as well.
Adriaan de Groot 3c6e53ecb9 [libcalamaresui] Chase the change in Module descriptor
- most of the code becomes **simpler** because the requirement
  to handle unstructured data is now in the descriptor itself,
  rather than in consumers.
Adriaan de Groot ee834a7abb [libcalamares] Define interface for Module descriptor
- add fields -- all const, all bogus -- to the descriptor,
  introduce a stub method to load the descriptor from
  YAML data (e.g. read from module.desc)
- lighten the type-naming in Module a little, with usings
Adriaan de Groot f0c4164515 [libcalamares] Add a more convenient find() to NamedEnum
- In most cases, you **know** the table covers all the enum
  values, and the extra parameter *ok* is just annoying.
  Provide a convenience that doesn't distinguish empty
  from empty-but-valid.
Adriaan de Groot 197cb9982c [libcalamares] Sort the tests by subdir
Adriaan de Groot bdd6bdc3b2 [libcalamares] Migrate module type and interface to descriptor
- move the enums
- expose the named-enum functions for them
- **start** replacing Descriptor with something stronger; this fails
  zero tests so it obviously wasn't tested at all
Adriaan de Groot 215cd0d1c3 [users] Repair test on openSUSE
Adriaan de Groot 7cef99605f [libcalamares] Distinguish instances with an explicit weight
- setting the weight in *instances* should be different from letting
  the default weight (of 1) stand; explicitly saying 1 should
  carry some weight (ha!)
Adriaan de Groot c8964717c7 [calamares] Bail out on invalid settings
Adriaan de Groot d81d585c32 [libcalamares] Add isValid() to Settings
- settings can be invalid (missing data, whatever) and that
  can be used to shut things down early. Validity must be
  checked explicitly, though.
Adriaan de Groot 4cd2a4ae91 [libcalamares] Produce warnings while reading settings
- any invalid instance key will cause a complaint
- "new" custom instances in sequence get a complaint, but
  the instance description added to the list is valid
Adriaan de Groot a8075fba5f [libcalamares] Chase API change in settings
Adriaan de Groot 253e5610af [libcalamares] Better type for the list of InstanceKeys
- *sequence* lists module instance keys; make the stored type of
  those keys InstanceKey instead of QString
Adriaan de Groot b23dbd47c7 [libcalamaresui] Chase changes in instanceDescriptor
- this is mostly about deleting code, since the special-cases
  now live in libcalamares where `settings.conf` is interpreted.
Adriaan de Groot 57f5a92d96 [libcalamares] Build complete instanceDescriptor list
- there's no reason to ignore custom instances that are **not**
  mentioned in the *instances* section: it may be useful to
  name more that one even without distinct config files.
Adriaan de Groot 4968efdaa7 [libcalamares] Simplify constructors of InstanceDescription
- no more weights in constructors; do that in fromSettings() only.
- simplify test to drop those constructors
- set config file also for "normal" descriptors; fix test
Adriaan de Groot e507338f4c [libcalamares] Test config filenames as well (custom vs standard)
Adriaan de Groot 1f57a99ff2 [libcalamares] Rename moduleInstances() and fix tests
- "custom" is a misnomer, so drop that from the name
- tests adjusted: all instances are returned, not just the "custom"
  ones.
Adriaan de Groot 6f7234e4ac [libcalamares] Add all mentioned instances to the instanceList
- "custom" instances is now a misnomer, since all the instances
  go into it; they are distinguished by `isCustom()` on the descriptor
Adriaan de Groot f157d9c459 [libcalamares] Refactor data-loading in Settings
- expose, for testing purposes, the load-from-YAML-data part
  alongside the public constructor that reads a YAML file
- add test for building the list of instances
Adriaan de Groot 34e31d4331 [libcalamares] Revert PRIVATETEST
- looks funny
- is hard to get clang-format to respect this; it's intended as an
  access-modifier, but those are baked into the code rather than
  being configurable.
- is probably rare enough that #ifdef is acceptable
Adriaan de Groot 53eb6c614a [libcalamares] Make InstanceDescription a class
- switch from dumb struct to a class; use a structured InstanceKey
- expand testing of InstanceKey and InstanceDescription
Adriaan de Groot 9c382e3555 [libcalamares] Support switching public/private during tests
Adriaan de Groot e96198e61c Merge branch 'calamares' into issue-1176
Adriaan de Groot 8518a5037d Changes: post-release housekeeping
Adriaan de Groot 1c2cceb3b8 Mention both of the fixed bugs
Adriaan de Groot 9413b28209 [libcalamares] Improve logging - report correct number of jobs left
Adriaan de Groot e9f2c57442 [users] Missing ! makes install always fail
FIXES 
Adriaan de Groot 31cfdf926c [libcalamares] Apply SPDX to utils/
Adriaan de Groot 172859dc2d Changes: pre-release housekeeping
Adriaan de Groot c48ec6bf94
Merge pull request from demmm/calamares
[welcomeq] language bar icon configurable
Adriaan de Groot 03871db597 [users] **keep** the create users job
- need to add the job to the list rather than just leaking it
Adriaan de Groot cac3e042d8 [libcalamares] Improve logging in runCommand() (less chatty)
Adriaan de Groot 3a0155b69d [calamares] Fix up multiple-moc of KDSAG
- was getting multiple definitions of moc-related code due to automoc
  combined with KDSAG having its own #include moc, comment-out the include.
- while here, simplify the CMake bits for building KDSAG
Adriaan de Groot 3227658475 [calamares] Fix up multiple-moc of KDSAG
- was getting multiple definitions of moc-related code due to automoc
  combined with KDSAG having its own #include moc, comment-out the include.
- while here, simplify the CMake bits for building KDSAG
demmm 01f0367459 [localeq] use image instead of theme icon
Adriaan de Groot 483c0a84f8 [libcalamares] Update SPDX in modulesystem/
Adriaan de Groot 21b4a36a91 [libcalamares] Remove empty .cpp file
- Requirement.cpp was there "just in case" the header grew
  functions that need an implementation, but that seems
  unlikely (the header is just a struct of POD).
Adriaan de Groot d83543d904 Merge branch 'calamares' into issue-1176
Adriaan de Groot 740d723ec0 CMake: add SPDX identifiers to top-level CMakeLists.txt
- This is kind of bogus, since the file has existed for much longer
  than the identifier says, but I don't want to do spelunking now.
Adriaan de Groot a873badf87 [libcalamares] Update SPDX identifiers in locale/