35 Commits (5d577371e70c5e443241d68ca94cb51509ded8d0)

Author SHA1 Message Date
Adriaan de Groot 5d577371e7 [welcome] Name widgets for styling
Widgets are easier to style if they have a name, and easier to spot
in the widget tree as well. Give the requirements-checker
parts meaningful names.

SEE #1685
4 years ago
Adriaan de Groot 9341a84820 [libcalamares] Make the RETRANSLATE macros more statement-line
Require a ; after RETRANSLATE macros. They are statement-like;
this makes it easier for some of them to be recognized by
clang-format and resolves some existing weird formatting.
4 years ago
Adriaan de Groot 2126be6d6d Warnings-- (~T() override)
Consistently use
	~T() override;
in class declarations (so no virtual in front, and avoid
warnings due to the missing override in back).
5 years ago
Adriaan de Groot 1cd9b93a22 REUSE: Giant boilerplate cleanup
- point to main Calamares site in the 'part of' headers instead
  of to github (this is the "this file is part of Calamares"
  opening line for most files).
- remove boilerplate from all source files, CMake modules and completions,
  this is the 3-paragraph summary of the GPL-3.0-or-later, which has
  a meaning entirely covered by the SPDX tag.
5 years ago
Adriaan de Groot 30a85668b7 REUSE: (GPL-3.0-or-later) C++ modules 5 years ago
Adriaan de Groot 0f5db0ba5e [libcalamares] Remove direct access to model internals
- This was just for the ResultsListWidget, which can also use
  normal role-based model access.
5 years ago
Adriaan de Groot 7d1800a0d7 [welcome] Apply coding style 5 years ago
Adriaan de Groot 70054e5db4 [welcome] Chase Branding API change 5 years ago
Adriaan de Groot ca7733c8e4 [welcome] Drop RequirementsModel
- Use the one from libcalamares
- Massage warning message into Config after it was removed from the model
5 years ago
Adriaan de Groot cf59e2884a [welcome] Reduce warnings from moc-generated code 5 years ago
Adriaan de Groot 2eb84e2de1 [partition] [tracking] [welcome] Missing Q_OBJECT
- These aren't strictly necessary for the code, but they
  help with translations.
5 years ago
Camilo Higuita d7f7c16958 [welcome] using config for both qcc2 or qwidgets 5 years ago
Adriaan de Groot ad4ac1d25c [welcome] Update copyrights 5 years ago
Adriaan de Groot 9d69d0a893 [welcome] Remove unused variables 5 years ago
Adriaan de Groot 1ac4786365 [welcome] Move all the translation work to the slot
- this needs to (re)check the satisfaction states to figure out the
   message, but that's useful if the state of the checks changes
   (e.g. in #1106)
5 years ago
Adriaan de Groot 221a79b64c [welcome] Simplify logic
- \not mandatorySatisfied \implies \not requirementsSatisfied,
   so the ifs can be combined and simplified
5 years ago
Adriaan de Groot 28d91979c3 [welcome] Make resultWidgets less error-prone
- instead of counting and needing to keep track of the predicate
   applied while creating the widgets, push nullptrs to the widget
   list instead reflecting "this entry did not satisfy the predicate
   for widget creation".
5 years ago
Adriaan de Groot 39534325e6 [welcome] Re-use widget creation code
- for the list, the code can be the same as for the dialog,
   only the predicate is different.
 - while here, implement retranslate() since there's no text on
   the list widgets otherwise.
5 years ago
Adriaan de Groot 38d58e5b16 [welcome] Hoist explanatory-label code
- Create the label once, and it's ok for it to respond to links
   even if there's none in the code.
 - Turn into a member variable in preparation for retranslation-refactor.
5 years ago
Adriaan de Groot b476e4b386 [welcome] Refactor link-clicking
- remove intermediate lambda
 - rename dialog slot to one handling links in general (which now
   **only** does the dialog link)
5 years ago
Adriaan de Groot ecc7719abd [welcome] Hoist checking for requirements-satisfied
- lift it out of the loop that creates the widgets
 - some lambda-wankery, but the compiler hammers this down to
   simple loops and you can read the resulting code as

	none_of  [the list]  isUnSatisfied
	none_of  [the list]  isMandatoryAndUnSatisfied
5 years ago
Adriaan de Groot f5c0e57f17 [welcome] Improve variable naming
- these two are about whether all the checkEntries are satisfied
   (in general, and the mandatory ones) so make the names reflect that.
5 years ago
Adriaan de Groot 5795801be5 [welcome] Remove unneeded member variables.
- local to the constructor, only needed to be members because
   of the weird split between constructor and init()
5 years ago
Adriaan de Groot 5aae736ced [welcome] Create ResultWidget in separate method 5 years ago
Adriaan de Groot bede280f91 [welcome] Refactor ResultsListWidget
- no point in having init() called immediately after the constructor,
   if it only makes sense to have one call to init() ever to create
   the widget.
 - while here, give it the same kind of structure as the dialog,
   holding on to a reference to the list.
5 years ago
Adriaan de Groot 320dcac946 [welcome] Drop unneeded member variable 5 years ago
Adriaan de Groot ed1b3b576f [welcome] Refactor ResultsListDialog
- drop useless debugging
 - add documentation
 - move to its own spot in the file (not mixed in with ResultsListWidget)
5 years ago
Adriaan de Groot 41ac21bdcd [welcome] Refactor results-details dialog
- Factor out the "details" dialog into a separate class
   with a translation slot. This resolves the crash reported in #1307.
5 years ago
Adriaan de Groot 6dfcbd757b [welcome] Remove superfluous call to QColor::value() 5 years ago
bill-auger ee85f6bfa7 replace hard-coded bg color of requirements failure notice with relative tint 5 years ago
Adriaan de Groot 8ee2375ee6 [welcome] Adjust welcome message to setup-mode 6 years ago
Adriaan de Groot 4d8acdf425 [welcome] Code-formatting
- Update copyright headers
 - Apply calamaresstyle
6 years ago
Adriaan de Groot 54ba0aaf13 [welcome] Use convenience function
- Introduce a hasDetails() for RequirementEntry, which is just
   a short-cut, but makes code more readable.
6 years ago
Adriaan de Groot bfb5a4efb9 [welcome] Chase file renaming
- Rename classes inside
 - Rename include guards
6 years ago
Adriaan de Groot 1240f63a39 [welcome] Rename files to reflect their purpose 6 years ago