1246 Commits (4acf63fd9adbca56e6431bc1d317db2e110f179a)

Author SHA1 Message Date
Adriaan de Groot 3d543e9063 [partition] Refactor to use current config-reading methods 7 years ago
Adriaan de Groot caa4b8ab53 [partition] Document intention of new-style swap config 7 years ago
Adriaan de Groot 2a61116b3c [partition] Disable swap choice for replace & alongside 7 years ago
Adriaan de Groot 779542a5d1 Merge branch 'master' into fix-swap-ui 7 years ago
Adriaan de Groot bb586de056 [partition] Remove some slowdown methods when debugging is off
- Running lsblk and mount for debugging purposes can be
   skipped when the debugging is going to be suppressed anyway.
   This will speed things up just a little for regular users.
7 years ago
Adriaan de Groot 74ab06e20a [partition] Drop redundant logging 7 years ago
Adriaan de Groot 02a6b7dd12 [partition] Log the newly-created partition table
- Log individual partitions instead of printing QObject(<ptr>)
7 years ago
Adriaan de Groot 4757496c3d [partition] Improve partition-UUID logging. 7 years ago
Adriaan de Groot 7515386cf8 CMake: clean up test setup
- Remove redundant searches for ECM and Qt::Test, move
   them to top-level.
7 years ago
Adriaan de Groot a33b0c4f24 [partition] Log the flags that are used to create a partition 7 years ago
Adriaan de Groot 292bc57523 [partition] Fix build with suitable operator << 7 years ago
Adriaan de Groot b38316365e [partition] Be more verbose about why UI buttons appear 7 years ago
Adriaan de Groot 800f9d34f9 [partition] In logging, distinguish more cases
- While winnowing devices, the zram and nullptr cases
   were mixed together; split them, for the sake of
   logging more accurately.
 - While here, fix up some coding-style issues.
7 years ago
Adriaan de Groot 29bae61610 Merge branch 'master' into fix-swap-ui 7 years ago
Adriaan de Groot 869357a89c Merge branch 'master' into oem-resizer 7 years ago
Adriaan de Groot 35ca813064 [partition] Use "" for including from current directory 7 years ago
Adriaan de Groot 88c973f7cc [partition] Simplify space calculations
- Q_ASSERT doesn't work in constexpr functions because it's not
 - May as well calculate bytes at compile-time, no need to give
   the runaround via number-of-MiB
7 years ago
Adriaan de Groot e3bf9fc220 [partition] Fix build with KPMCore <= 3.3.0
- Reported by Philip Mueller
7 years ago
Adriaan de Groot d2f4079a18 [partition] Move partitioning options into a class
- As (auto) partitioning grows more options, the parameter
   list becomes more unwieldy. Add some structure to it.
7 years ago
Adriaan de Groot 3f09857cb7
Merge pull request #1013 from cjlcarvalho/master
Some RAID fixes
7 years ago
Adriaan de Groot 5136021416 [partition] Move SwapChoice to another namespace
- The choice of swap needs to be handled in more places,
   so make the enum available in the partition module core instead
   of just inside the choice page.
7 years ago
Adriaan de Groot 846e496d76 [partition] Tidy includes 7 years ago
Adriaan de Groot 8c79c981b1 [partition] Simplify space calculations
- Q_ASSERT doesn't work in constexpr functions because it's not
 - May as well calculate bytes at compile-time, no need to give
   the runaround via number-of-MiB
7 years ago
Adriaan de Groot 959cd7b224 [partition] Simplify creation of comboboxes for swap choices 7 years ago
Adriaan de Groot cfa940b35c [partition] Support translations of swap choices
- Introduce enum to indicate what is selected
 - Support translations
 - Fill selections for erase
7 years ago
Adriaan de Groot 7d0451fe69 [partition] Rename Choice -> InstallChoice
- There are more choices to be made (or to come) when partitioning,
   so don't take the most generic term for one enum.
7 years ago
Adriaan de Groot 10f7bac2df [partition] Reorder initialization 7 years ago
Adriaan de Groot c3f3276188 [partition] Improve presentation of swap options 7 years ago
Adriaan de Groot dc492b301c [partition] Drop label on swap-options box 7 years ago
Adriaan de Groot a791818a65 [partition] Add swap drop-down
- This is WIP; the drop-down contents should be customised,
   depending on configuration and the state of the device being
   installed-to.
7 years ago
Adriaan de Groot c813375908 [partition] Prepare for swap options
- Extend PrettyRadioButton with options (combo-boxes which may
   be added later).
7 years ago
Adriaan de Groot e0cd90cab1 Update the documentation and implementation of swap calculation.
Make the ramps consistent between suspend-to-disk and not,
and don't do the weird drop from 8GiB swap down to 4GiB for
large-memory systems.
7 years ago
Adriaan de Groot c104d14086 [partition] Call the helpers in the right order.
This fixes the crash by calling the model-reset first, then
refreshing. Previously, the destructors that do the work
were still being called in the wrong order.

FIXES #1019
7 years ago
Adriaan de Groot fe662345bd [partition] Extra helper classes for doing reset and refresh
- The ResetHelper only finalized changes to the module on
   destruction, but calls to refresh() assumed it was already
   done. This leads to crashes when refresh() uses an intermediate
   state of the model.

Introduce extra helpers, and rename refresh() to avoid calling the
old implementation from any code. The new helper just creates and
destroys a ResetHelper, before creating and destroying an object
that calls the new refreshAfterModelChange().

FIXES #1019
7 years ago
Adriaan de Groot 42d606171d
Merge pull request #1020 from apachelogger/esp-eq-boot
do not set boot flag on ESP (thanks @philmmanjaro for testing)
7 years ago
Harald Sitter 84ad2852bf do not set boot flag on ESP
ESP == boot. at best this is duplicated information, at worst kpmcore may
implode if you try to set a boot flag since that is technically an MBR
type flag and means nothing within the context of GPT where ESP is the flag
to set.
7 years ago
Harald Sitter 81cab43701 do not set active flags on the to-be ESP
having ESP as active flag AND then trying to set ESP means nothing is
set since kpmcore will think ESP is already set (it is listed as active
after all). this ultimately meant that nothing was set since there was
no delta between the requested flags and the already active flags.
7 years ago
Adriaan de Groot 08d41f745b [partition] Remove superfluous null check
delete is specified to handle nullptr gracefully.

FIXES #1012
7 years ago
Caio Carvalho 01a972c6ea [partition] Fixing LVM LV name line edit visibility. 7 years ago
Caio Carvalho b5a2a5bbdd [partition] Don't show erase button for inactive RAID. 7 years ago
Caio Carvalho 7fd0ad5795 [partition] Disabling partition buttons for inactive RAID. 7 years ago
Andrius Štikonas 22aa6dc132 [partition] fix build with latest kpmcore. 7 years ago
Simon Quigley 5c50587f89
Fix LUKS deployment link. 7 years ago
Adriaan de Groot bf40f3bd23 Merge branch 'master' into requirements-checking 7 years ago
Adriaan de Groot 3b82e655d7 Merge remote-tracking branch 'origin/update-lvm-support' 7 years ago
Adriaan de Groot 238a1e812f [partition] Reduce the fudge-factor for swap size
- Reported by Bill Auger (I think), a 15GiB disk wouldn't hold
   a 8.9GiB root plus 4GiB swap -- due to 10% overprovisioning
   of swap, plus the 2.1GiB fudge factor.
7 years ago
Adriaan de Groot f10bab8a3a [partition] Minor code-styling 7 years ago
Adriaan de Groot 8ed26e537f [partition] Fix swap maximum size
- The existing calculation comment says "maximum 10% of disk"
   but the calculation itself uses 110%.
7 years ago
Adriaan de Groot 59fea041b6 [partition] Fix up calculations of sectors in auto-partition
- Calculating first free sector had an off-by-one so that
   partitioning would start at 2049.
 - EFI boot partition grew 1 sector larger than desired.
 - While here, align everything to 1MiB boundaries as well.

FIXES #1008
7 years ago
Adriaan de Groot 1cbfa9d693 [partition] Simplify code for sizing 7 years ago
Adriaan de Groot 5d5feeb0ab Merge branch 'master' of https://github.com/cjlcarvalho/calamares into lvm-update 7 years ago
Caio Carvalho 589628bb9a [partition] Removing unnecessary horizontal spacer on Partition Page. 7 years ago
Caio Carvalho 67d9ebbfc0 [partition] Setting revertButton enabled after deactivating VG. 7 years ago
Caio Carvalho 295e14530e [partition] Adding resizing, deactivating and removing procedures for LVM VGs. 7 years ago
Adriaan de Groot 9d17e7210a [partition] Change shortcut for "Create" to 'a'
Untangle the shortcuts; Create and Cancel had an overlap.
Skip 'r' (Revert all changes) and 'e' (Edit) and settle on
'a' (which might also mean "Add").

FIXES #977
7 years ago
Adriaan de Groot 5643ee4b8f Merge branch 'master' into secureboot 7 years ago
Adriaan de Groot fa08e0ad73 Copyright: fix bad email address 7 years ago
Adriaan de Groot dd8e53dc22 Copyright: update copyright lines on files touched in 2018
Contributions from:
  Adriaan de Groot <groot@kde.org>
  Gabriel Craciunescu <crazy@frugalware.org>
  AlmAck <gluca86@gmail.com>
  Andrius Štikonas <andrius@stikonas.eu>
  Caio Carvalho <caiojcarvalho@gmail.com>
  Raul Rodrigo Segura <raurodse@gmail.com>
7 years ago
Caio Carvalho 98a158c6e5 [partition] kpmcore latest release doesn't support FileSystem::Type::Luks2 7 years ago
Caio Carvalho 3b6c764f75 [partition] Fixing revert device loop error in PartitionCoreModule::revertAllDevices. 7 years ago
Caio 0465cc4214 [partition] Including revert on creation of LVM VGs. 7 years ago
Caio f8897e0e0b [partition] Including new LVM PVs in LVM VG creation GUI. 7 years ago
Caio e5351cdf3c [partition] Don't show capacity of new LVM VGs in DeviceModel. 7 years ago
Caio 208d58bcd9 [partition] Including CreateVolumeGroupDialog and fixing some of its GUI issues. 7 years ago
Caio d15ce56c97 [partition] Initial implementation of VolumeGroupBaseDialog. 7 years ago
Adriaan de Groot cbd62fbeb1 Merge branch 'master' into secureboot 7 years ago
Adriaan de Groot 47805209c6 Merge branch 'branding' of https://github.com/raurodse/calamares into raurodse-branding 7 years ago
Adriaan de Groot 5bcd6eaef8 [partition] Reduce warnings by removing unused code 7 years ago
Raul Rodrigo Segura 1636f665c3 Set Object name to graphical elements to thematize by qss 7 years ago
Raul Rodrigo Segura 4c6f42ecfa Set Object name to graphical elements to thematize by qss 7 years ago
Adriaan de Groot 90a2e482be [partition] Check for available partition type before creating
- Avoid situation where you make 5 or more primaries in an
   MSDOS partition table.

FIXES #953
7 years ago
Adriaan de Groot bd57f1f2f1 [partition] Fix re-editing a newly created partition
- If there is a partition already (newly) created, then pass that
   to the dialog so that it can use the setings previously applied
   (e.g. mount point and flags).
 - This avoids the case where you create or format a partition,
   then click on it again to edit it and the previous settings are lost.
7 years ago
Adriaan de Groot ca03dad67b [partition] Refactor setting the flags UI
- Setup the lsit of flags consistently, by providing the available
   and to-be-checked flags.
 - In CreatePartitionDialog, assume that ~0 is all the flags.
7 years ago
Adriaan de Groot 4f451eece5 [partition] Refactor getting the checked flags 7 years ago
Adriaan de Groot 950cc9070d [partition] Rename MountPoints to PartitionDialogHelpers
This file is full of helper functions for the partition-editing
dialogs. At first it was just mount-point helper functions,
but there is other functionality that can be refactored.
7 years ago
Adriaan de Groot 336b8c758a [partition] Consider the future flags when checking EFI bootability
- If we're changing the flags to enable EFI boot, then that's
   enough to satisfy the (future) EFI bootability check.
   This is for issue #622 as well. Fixes #884.
7 years ago
Adriaan de Groot 0df304b206 [partition] Preserve desired partition flags
- Use the desired (future) flags, if set, to initialize the
   flags checkboxes. If there are no future flags set, this
   returns active flags as before.
 - This fixes the situation where editing a partition, changing
   flags, then editing it *again* re-starts with the original
   flags instead of the modified flags.
7 years ago
Adriaan de Groot 6739b81c2a [partition] Tell PartitionInfo about desired flags
- When creating a partition, or changing flags, tell
   the PartitionInfo about those desired flags.
7 years ago
Adriaan de Groot 7df143f64a [partition] Add flags to PartitionInfo
- PartitionInfo maintains information on "what is desired" for
   a given Partition. Now we can set desired flags, alongside
   the flags already supported by Partition (where activeFlags()
   gives you the flags currently set on that partition).
7 years ago
Adriaan de Groot 5b4668822d [partition] Also update combo box index when setting up
- Avoids case where you edit a partition with a mountpoint
   set; previously, calling setText() would update the text
   but leave the selected index unchanged (usually 0), so that
   later calling selectedMountPoint() would return empty.
7 years ago
Adriaan de Groot 323d20d1a5 [partition] Avoid sneaking an empty string into the mount points combo 7 years ago
Adriaan de Groot 255a99d714 [partition] Drop now-unneeded debugging 7 years ago
Adriaan de Groot 310555f16b [partition] Add /srv to standard mount-points list. 7 years ago
Adriaan de Groot 4402198b37 [partition] Centralize setting-of-mountpoint
- map empty to the 0'th index
 - add new entries as needed

This avoids having selected index 0, but a different text.
7 years ago
Adriaan de Groot a49c39bb53 [partition] Unmap mount-point special strings
- Reverse "(no mount point)" to the empty string
 - Provide convenience pointer-taking function
7 years ago
Adriaan de Groot a4997c4be8 [partition] Convenience for selecting default mount point
- map blank to the "(no mount point)" string for UI purposes
7 years ago
Adriaan de Groot fda2e54e0f [partition] Refactor filling combobox with moint points
- Move to one place which handles the standard mount points
 - While here, introduce explicit "(no mount point)" string
   into the combo box. This is prep-work for issue #951.
7 years ago
Caio Carvalho f72f7bd8fe [partition] Only bootloader model should ignore devices that are not of Disk_Device type. 7 years ago
Caio Carvalho 77d2667b53 [partition] Checking if there is LUKS creation support and if partition is not Extended before enabling encryption in CreatePartitionDialog. 7 years ago
Caio Carvalho f561f04591 [partition] Changing PartUtils::getDevices to ignore devices that aren't of Disk_Device type. 7 years ago
Caio Carvalho 8726b70574 [partition] Ignoring LVM devices in PartUtils::getDevices to prevent installing bootloader in LVM VG. 7 years ago
Andrius Štikonas 1b21668bff [partition] Switch to scoped Device enums. 7 years ago
Adriaan de Groot 6bb72d173d [libcalamares] Drop generic cLog()
- Use cWarning or cError() for errors
 - Use cDebug(level) for other uses (but there aren't any)
7 years ago
Adriaan de Groot c7629182e4 Merge branch 'master' into requirements-checking 7 years ago
Adriaan de Groot a72bdfac52 Merge branch 'master' into requirements-checking 7 years ago
Adriaan de Groot 092529da45 [partition] WIP: EFI partition search
- Add some logging (not even sure it compiles) because
   my openSUSE Krypton Secureboot-enabled VM says
   "no EFI system partitions found".
7 years ago
Adriaan de Groot 3ae126f589 [modules] Use cError() as well
- Switch KPMHelpers to using Calamares logging instead of qDebug()
7 years ago
Adriaan de Groot 3315df5df1 [modules] Use new convenience logging methods across the board 7 years ago
Adriaan de Groot 0b03d56a40 i18n: Massage code to help lupdate understand 7 years ago
Adriaan de Groot 58252fc16d [partition] Handle missing requirements by disabling the module 7 years ago
Adriaan de Groot e3b7a2884b [partition] Relax check with UI-level warning message, too 7 years ago
Adriaan de Groot 637d6ad752 [partition] Find Esp partition with modern flags. 7 years ago
Adriaan de Groot 94b6c95c44 [partition] Introduce function for checking various flag-combinations for ESP boot. 7 years ago
Adriaan de Groot 05967311de [partition] Be defensive against no device-device-available.
Scenario is this: you have no suitable installation devices on
your system (everything is mounted, or HDD has died), click through
to partition page, where you have all the buttons available, but no
devices in the list. The following actions then cause a crash:

 - clicking "back"
 - clicking any button

Prevent that:
 - you can click "back", but if there is no device selected
   nothing happens to the device state (no nullptr deref,
   and no crash)
 - button code is now more resilient to this scenario
 - buttons are hidden until a device is available, so you
   can't even click on them to trigger the code.
7 years ago
Adriaan de Groot 1a42b8af41 Merge branch 'kpmcore-3.2'
- Bumps requireed KPMCore to 3.3 (in spite of the branch name)
 - Cleans up some dependencies

Thanks to Andrius Stikonas.
7 years ago
Andrius Štikonas 2027a5538e Fix propagation of new partition table to global storage. 7 years ago
Philip 1cffa9fafc [partition] Rename slots, to avoid recursion
- see also https://github.com/calamares/calamares/issues/880
- missed within 7ce52ecda7
7 years ago
Philip 8f32aad3fa [partition] Rename slots, to avoid recursion
- see also https://github.com/calamares/calamares/issues/880
- missed within 7ce52ecda7
7 years ago
Adriaan de Groot dc255e161e [partition] Rename slots, to avoid recursion 7 years ago
Andrius Štikonas 806b84973a Convert CreatePartitionTableJob to KPMcore operation. 7 years ago
Andrius Štikonas 1b3ce39ffb Convert FormatPartitionJob to KPMcore's CreateFileSystemOperation. 7 years ago
Andrius Štikonas 638117efa0 Cleanup unnecessary kpmcore includes. 7 years ago
Adriaan de Groot 7ce52ecda7 [partition] Rename slots, to avoid recursion 7 years ago
Adriaan de Groot 762ad54344 Documentation: change http links to GitHub to https 7 years ago
Adriaan de Groot cc15dd9ec7 Merge branch 'master' into kpmcore-3.2
- Pull in Master, merge README, to simplify merging this
   branch into master (soon-ish, once kpmcore 3.3 becomes available
   in builders)
7 years ago
Andrius Štikonas a2e3af2b3d Require KPMcore 3.3 7 years ago
Adriaan de Groot 55ed2ba4c0 [partition] Introduce convenience translation for progress. 7 years ago
Adriaan de Groot 5c4286eebf [partition] Switch to convenience function for MiB 7 years ago
Adriaan de Groot 38688bab47 [partition] code style (minor followup to #872) 7 years ago
Adriaan de Groot 0729bdd0be
Merge pull request #872 from stikonas/3.1.x-stable
Use KPMcore SetPartFlags operation.
7 years ago
Adriaan de Groot 29e532a790 [partition] Insert annoying 3-sec delay
This is intended for testing -- it helps debug where a slow
requirement check blocks the UI.
7 years ago
Andrius Štikonas 139f5a9e86 Use KPMcore SetPartFlags operation. 7 years ago
Adriaan de Groot 4566e53d01 [partition] Delay requirements checking until pmcore is initialized 7 years ago
Adriaan de Groot ba21a221df [partition] C++ style 7 years ago
Adriaan de Groot 16fbe4dc8c [partition] Sample of requirement checking
- There should be at least device to select, overwise we can't continue.
   The check currently **always** fails, so it blocks installation.
7 years ago
Chantara Tith 2a785bdf89 Disable newPartitionTableButton for LVM device. 8 years ago
Andrius Štikonas 652ffaedd5 Remove unnecessary kpmcore includes. 8 years ago
Andrius Štikonas 1620f6a668 Merge branch 'master' into lvm2 8 years ago
Adriaan de Groot 105e06798e CMake: look for ECM at top-level, add to search path if found. 8 years ago
Adriaan de Groot b303acf12a Merge branch '3.1.x-stable'
- KPMCore code moved
 - Small fixes
8 years ago
Adriaan de Groot 5474dc6d2b [partition] allow KPMcore 3.0.2 (with warning) 8 years ago
Andrius Štikonas fb1522f6ca Use KPMcore Resize Operation. 8 years ago
Andrius Štikonas 274025d04e Fix reported partition size. 8 years ago
Adriaan de Groot 5e101bcbf9 Document KPMCore versions that make sense
- KPMCore 3.0.2 works, but contains specific bugs
8 years ago
Adriaan de Groot e7c51aa00b Document defaultFileSystemType
- this applies to new partitions; existing documentation erroneously
   said this happens with Replace as well,
 - follow up on Andrius manual-partition PR with documentation that
   manual mode doesn't switch to this FS when editing existing partitions.
8 years ago
Andrius Štikonas 38c3f8bb52 Clarify defaultFileSystem documentation. 8 years ago
Andrius Štikonas ceba157459 Use KPMcore DeleteOperation to delete partitions. 8 years ago
Andrius Štikonas 70573543f2 Use KPMcore NewOperation to create partitions. 8 years ago
Andrius Štikonas 4912d8a6c2 Fix create partition job to work with LVM devices. 8 years ago
Adriaan de Groot 3f739563ef Drop KService requirements (it's still there in InteractiveTerminal) 8 years ago
Andrius Štikonas 68e940f0bf Remove unnecessary KIO and KIconThemes dependencies. 8 years ago
Andrius Štikonas 9f05c236d8 KPMcore: Pass QStringList to fs->name() instead of QString. 8 years ago
Adriaan de Groot ff2947060d KPMCore: use the translation system for filesystem names from KPMCore 8 years ago
Adriaan de Groot 96c3f7def3 KPMCore: drop conditional code 8 years ago
Adriaan de Groot ca037af6ca KPMCore: update required version to 3.2
- drop extra checks for blkid and atasmart, those are kpmcore's
   concern, not ours (and it might have other backends, anyway)
8 years ago
Adriaan de Groot d2cce926de Merge pull request #821 from calamares/luks-colors
Use the LUKS filesystem's outer UUID for the color index.
8 years ago
Adriaan de Groot e3e519c06f Clang: reduce warnings, nullptr, unused parameters 8 years ago
Adriaan de Groot 337903db09 Clang: reduce warnings about overriden destructors 8 years ago
Adriaan de Groot 9693d7a5bd Memory: clean up interface used to get memory (RAM) size 8 years ago
Adriaan de Groot d23818b27c Fix code using re-imported spinner 8 years ago
Adriaan de Groot 13807ceabf Licensing: add self
- to all the files I've touched recently
 - to (very incomplete) AUTHORS list

Licensing: add license info to top-level CMakeLists.txt
8 years ago
Adriaan de Groot ca60a7fc16 Clang: warnings-- 8 years ago
Adriaan de Groot 342b819a1d Fix build (warnings--, but breakage++ is not good) 8 years ago
Adriaan de Groot c6297f1db5 Clang: warnings-- 8 years ago
Adriaan de Groot 9f1cca5ec7 FS: use untranslated name to identify filesystem
Resolves issue where 'linuxswap' is translated to 'Linux-Swap',
for instance. FileSystem::name() provides a translated name,
not an untranslated one.

This should move to KPMCore.

FIXES #797
8 years ago
Adriaan de Groot ec86922839 Find KPMCore 3.2 quietly, less frightening 8 years ago
Adriaan de Groot 9116718448 Clang: warnings-reduction 8 years ago
Adriaan de Groot 0b39e50cdc Clang: explicit char-initialization of ByteArray 8 years ago
Adriaan de Groot bd3786ebeb Clang: reduce warnings in various places 8 years ago
Adriaan de Groot a06911e9aa Clang: refactor units-converters, reduce warnings 8 years ago
Adriaan de Groot 31fa9e4251 Clang: fix warnings on partition splitter
- initialize all the fields
 - member-initialization order
 - silence warnings about double<->int
 - drop unused parameter to setSplitPartition
8 years ago
Adriaan de Groot 3e5916157f A mounted partition cannot be resized or replaced
- add check for isMounted()
 - a device with a mounted partition cannot be (entirely) erased

FIXES #639
8 years ago
Adriaan de Groot 851379628c Reduce Qt runtime warnings.
- deleteLater() doesn't like nullptr (produces a warning, but is harmless)
 - reparenting across threads doesn't work, comment on that but leave
   it in, since this may be relevant for memory management.
8 years ago
Andrius Štikonas 252006ea25 kpmcore now requires passing sector size to FileSystem. 8 years ago
Adriaan de Groot 360a114ed4 Be more explicit on why a device is winnowed from the list 8 years ago
Adriaan de Groot 0e96621b94 Don't leak memory when winnowing disk devices
- Improve logging a little
 - Don't leak Device*, but delete the raw pointer when erasing
 - Document that DeviceInfo takes ownership and doesn't leak
8 years ago
Adriaan de Groot d5dca07e22 Fix uninitialized values (valgrind report) 8 years ago
Adriaan de Groot 1ea79efce8 Uninitialized value 8 years ago
Adriaan de Groot c5abfd6371 Having a mounted partition should not disqualify the entire device.
FIXES #780
(should reopen #639 for double-checking)
8 years ago
Adriaan de Groot 85595b4e04 #780: check for isMounted(), not for where-would-it-be-mounted 8 years ago
Adriaan de Groot 7791c3cb19 DeviceInfo: refactor translation of DeviceInfoPage
- For Boot and Device info widgets, add a retranslateUi() method,
   since the labels change not only in response to translation
   events but also UI events.

FIXES #779
8 years ago
Adriaan de Groot 7e66499f36 Refactor check for EFI system.
The TODO stands, to delegate this to KPMCore.
8 years ago
Adriaan de Groot 2fdccdf090 Merge branch 'simplify-module-desc' 8 years ago
Adriaan de Groot 196b1567db Modules: remove boilerplate module.desc 8 years ago
Andrius Štikonas 1131fdce4c Port away from deprecated qSort. 8 years ago
Adriaan de Groot 3cd18fd285 Partitions: extend getDevices() with minimum size.
This is preparatory work for making the available-space check consistent with
what the partition module will allow for installation. Right now, the check
for available space will allow a mounted drive, even /, to satisfy the check.
8 years ago
Adriaan de Groot 18a1f459db Partition: reduce code duplications 8 years ago
Adriaan de Groot 7d49255a78 Partitions: use an enum with clear semantics instead of bool 8 years ago
Adriaan de Groot 730e0d885f Partitions: use KPMCore-defined default backend 8 years ago
Adriaan de Groot 55c6cfa1ca Partitions: improve wording of debug messages 8 years ago
Adriaan de Groot 102bed1805 Partitions: split device-listing (and winnowing) into separate source file.
The grab-list-of-writable-devices code is usable for the partition module, but
also useful for welcome module, so reduce its footprint.
8 years ago
Adriaan de Groot 33bca6d71d Merge commit 'partitions' 8 years ago
Adriaan de Groot 5bf03cc515 Partitions: shuffle some device-detection code off to PartUtils.cpp 8 years ago
Adriaan de Groot aeb0cd0d3f Partitions: drop devices with mounted partitions.
FIXES #639
8 years ago
Adriaan de Groot cc7631dd99 Partitions: code-formatting 8 years ago
Adriaan de Groot c66807282b CMake: remove editorializing from CMakeLists.txt 8 years ago
Lisa Vitolo 9be15e68b6 Change both size box suffices to MiB. 8 years ago
Lisa Vitolo 925d3a61a7 Add "MB" suffix to the "edit partition" size box.
Makes it easier to know which unit Calamares is using when
resizing a partition. The "Create partition" dialog has
it already.
8 years ago
Adriaan de Groot 3c3c0f99f8 C++ trickery, part two: shorten code 8 years ago
Adriaan de Groot 232bbe18bc Be more verbose while scanning devices 8 years ago
Adriaan de Groot ee4e4dfccc C++ trickery to make the code shorter to read. 8 years ago
Adriaan de Groot 79595eb532 Coverity: explicitly initialize 8 years ago
Adriaan de Groot c0b3f3fe9d Clang: reduce warnings; make enum-switch explicit 8 years ago
Adriaan de Groot 8ea14d7957 Release: add copyright to files I've touched 8 years ago
Adriaan de Groot 6616315269 Partitionmanager: minor docs edit 8 years ago
Adriaan de Groot 8708260689 Partitionmanager: fix PM-tests build 8 years ago
Adriaan de Groot 7ebbcc33b2 Partitionmanager: remove unused code files 8 years ago
Adriaan de Groot ea44021cb4 Partitionmanager: partly fix PM-tests build 8 years ago
Adriaan de Groot 46a2503c87 PartitionModule: skip nullptr devices, and report count
FIXES #686
8 years ago
Adriaan de Groot 92a2c7aa70 PartitionModule: avoid nullptr crashes
Fix up iterator code so that it handles nullptr better.
This avoids part of #686.
8 years ago
Adriaan de Groot 3677708d3e PartitionModule: look for atasmart and blkid, to avoid link-time failure.
This just puts a warning in the cmake log, but will help diagnose
situations where libatasmart.so.4 is installed, but libatasmart.so
is not -- in which case -latasmart fails.
8 years ago
Adriaan de Groot e92d82c5db Cleanup: add copyright lines 8 years ago
Adriaan de Groot fc5522741a Bump required KPMCore to 3.0.3
The newer release resolves (upstream) a problem with NVMe encryption.

FIXES #697
8 years ago
Adriaan de Groot aea73b982e Cleanup: require ECM 5.10 or later (released 2015) 8 years ago
Adriaan de Groot 5382a510a9 Cleanup: switch to C++11 user-defined literals 8 years ago
Adriaan de Groot 4fab3c93c2 Docs: document effect of ensureSuspendToisk more thoroughly 8 years ago
Adriaan de Groot 829f72363e Cleanup: remove duplicate #define 8 years ago
Rohan Garg bba2f65079
Add additional variables to help improve readability 8 years ago
Teo Mrnjavac 6545443b24 Documentation++ 8 years ago
Teo Mrnjavac 80beb87ae9 Documentation++ 8 years ago
Teo Mrnjavac 6c7cdb5f50 Documentation++ 8 years ago
Teo Mrnjavac 3aebb79d30 Add optional config value neverCreateSwap in partition module.
CAL-458 #close The feature has landed in master, please test.
8 years ago
Ramon Buldó f0b4a21b2d partition: use always double click to activate a partition tree view item
Using activated signal may use single or double click depending on environment settings
8 years ago
Teo Mrnjavac 06b1d4abd2 Don't hardcode /dev/sd* as device path. 8 years ago
Teo Mrnjavac f4732de975 Always write bootloader path. 8 years ago
Teo Mrnjavac 45adde11e1 Do not write bootloader install path if the system is EFI. 8 years ago
Teo Mrnjavac 4f1317d1b7 Force the correct flags for EFI system partition. 8 years ago
Teo Mrnjavac a59a79a816 bootloaderInstallPath only applies if !isEfi. 8 years ago
Teo Mrnjavac 3285ebae67 Bump KPMcore dependency to 3.0.2. 8 years ago
Teo Mrnjavac f3848cd428 The sender QObject should be in scope so the bootloader path is written.
CAL-388
CAL-417
CAL-441
8 years ago
Teo Mrnjavac c158893b22 Style + translation. 8 years ago
Teo Mrnjavac 2aeadf9682 Better to keep font style manipulation to a minimum. 8 years ago
Teo Mrnjavac e9f113a6a8 Translate user-visible strings! 8 years ago
Teo Mrnjavac 028f56d94a Better to keep font style manipulation to a minimum. 8 years ago
Teo Mrnjavac 3ec7c6f881 Style. 8 years ago
Lisa 02abc0d0a7 Merge pull request #276 from shainer/mountpoint
Disallow assigning the same mountpoint to two partitions
8 years ago
Teo Mrnjavac 40eba50821 Improve debug output. 8 years ago
Teo Mrnjavac 244b4dff83 Improve debug output. 8 years ago
Teo Mrnjavac 457172df66 Do not dereference nullptr. 8 years ago
Teo Mrnjavac e2b2d761c2 Do not LINK_PUBLIC by default. 8 years ago
Teo Mrnjavac 45315e6ae9 Improve debug output for bootloader code path. 8 years ago
Teo Mrnjavac e10034c670 Bump KPMcore requirement. 8 years ago
Teo Mrnjavac 2230cd6941 Use the LUKS filesystem's outer UUID for the color index. 8 years ago
Teo Mrnjavac 0ad819e301 Make sure we write the inner fs type to globalstorage. 8 years ago
shainer 2759529841 Remove current partition's mountpoint from used list.
This means that when we edit a partition, we don't consider
its current mountpoint invalid because it is already in-use.

We need to do this for both "edit existing partition" and
"edit a partition that we are still creating".
9 years ago
shainer 349470ae71 Check mountpoints when editing a partition too. 9 years ago
shainer 8c1199df2d Check first selection of mountpoint too.
When opening the dialog.
9 years ago
shainer f51b05e8aa Get the mountpoint from PartitionInfo.
The Partition object includes the root mountpoint in
the partition mountpoint, which is not what we want.
9 years ago
shainer c8dbeb5341 Avoid creating a new partition with a used mountpoint.
We get the mountpoints already used by other partitions, and
disable the Ok button in the "Create new partition" dialog if
the user selects/writes a mountpoint which is already used.

We are going to do the same in the Edit partition dialog
after testing.
9 years ago
Teo Mrnjavac 83b51a5867 Show warning. 9 years ago
Teo Mrnjavac 17fe2d82f4 Oops. 9 years ago
Teo Mrnjavac a55bef5d2d Warn user about encrypted root with unencrypted /boot. 9 years ago
Philip e8f694fe02 [partition] Bump kpmcore requirements 9 years ago
Kevin Kofler 1548fe4810 [partition] Use FlagEsp instead of sgdisk to scan for ESPs.
Address an old FIXME in
PartitionCoreModule::scanForEfiSystemPartitions(): Check the FlagEsp on
the Partition object (that KPMcore has been supporting since 2.1.0)
instead of running sgdisk.
9 years ago
Kevin Kofler 5377003f89 Set the ESP flag in partition rather than bootloader.
The manual partitioning setup was already requiring the user to check
the ESP flag for the EFI System Partition. Now the autopartitioning also
sets it directly (a one-line change). The sgdisk call in the bootloader
module is thus no longer necessary (it was only a workaround because
kpmcore < 2.1.0 did not support FlagEsp), so remove that snippet.

This fixes configurations such as NVME disks where splitting boot_device
into boot_device[-1:] and boot_device[:-1] is not the correct split
(because the partition gets a 2-letter suffix) (reported by demmm on
IRC).
9 years ago
Teo Mrnjavac fbe72b3663 Improve user-visible strings in SetPartFlagsJob. 9 years ago
Teo Mrnjavac 6e7dc0b437 Use the target system's boot name in partitioning summary widget. 9 years ago
Teo Mrnjavac 5796b05fda Allow disabling automated LUKS modes. 9 years ago
Chantara Tith 64db6d5ba1 Use device's immutable copy instead of rescanning. 9 years ago
Teo Mrnjavac c316d22b08 Keep an immutable copy for every scanned Device* to avoid rescans. 9 years ago