[partition] Avoid heap-wrangling

- The CreatePartitionDialog doesn't need to be on the heap, it's
   modal here. Avoid QPointer weirdness as well.

src/modules/partition/gui/PartitionPage.cpp

@@ -362,18 +362,18 @@ PartitionPage::onCreateClicked()
     if ( !checkCanCreate( model->device() ) )
         return;
 
-    QPointer< CreatePartitionDialog > dlg = new CreatePartitionDialog( model->device(),
+    CreatePartitionDialog dlg(
+        model->device(),
         partition->parent(),
         nullptr,
         getCurrentUsedMountpoints(),
         this );
-    dlg->initFromFreeSpace( partition );
+    dlg.initFromFreeSpace( partition );
-    if ( dlg->exec() == QDialog::Accepted )
+    if ( dlg.exec() == QDialog::Accepted )
     {
-        Partition* newPart = dlg->createPartition();
+        Partition* newPart = dlg.createPartition();
-        m_core->createPartition( model->device(), newPart, dlg->newFlags() );
+        m_core->createPartition( model->device(), newPart, dlg.newFlags() );
     }
-    delete dlg;
 }
 
 void