[netinstall] Sanitize PackageTreeItem::data()

- Use of != nullptr for QString just a bad idea
- Massage code so structure for packages resembles that of groups
main
Adriaan de Groot 6 years ago
parent 201c5ddfe1
commit 3d68c74a19

@ -108,22 +108,27 @@ PackageTreeItem::row() const
QVariant QVariant
PackageTreeItem::data( int column ) const PackageTreeItem::data( int column ) const
{ {
if ( packageName() != nullptr ) // package if ( !packageName().isEmpty() ) // packages have a packagename, groups don't
{ {
if ( !column ) switch ( column )
{ {
case 0:
return QVariant( packageName() ); return QVariant( packageName() );
default:
return QVariant();
} }
return QVariant();
} }
switch ( column ) // group else
{ {
case 0: switch ( column ) // group
return QVariant( prettyName() ); {
case 1: case 0:
return QVariant( description() ); return QVariant( prettyName() );
default: case 1:
return QVariant(); return QVariant( description() );
default:
return QVariant();
}
} }
} }

Loading…
Cancel
Save