aiden
/
yuzu
mirror of https://github.com/yuzu-mirror/yuzu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,606 Commits
2 Branches
1 Tag
107 MiB
master
revert-23-master
poc-windows-build
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'f08b4cbbc8'
${ noResults }
Commit Graph

34 Commits (f08b4cbbc889b09aa628f586018f1119b3cbd7ce)

Author SHA1 Message Date
David Marcec c440e8b8e1 Implemented CalculateStandardUserSystemClockDifferenceByUser 
Seems pokemon calls this sometimes and it caused "random crashes"
 7 years ago
David Marcec 48cd61d9c8 Added maybe_unused 7 years ago
David Marcec ddc242dd51 Added ToPosixTime & ToPosixTimeWithMyRule 
Added instead of using a seperate PR to prevent conflicts
 7 years ago
David Marcec 84c6134264 Added consts and static 7 years ago
David Marcec 4f78f5c0df Implement GetClockSnapshot 
Needed by megaman 11
 7 years ago
Lioncash 6ac955a0b4 hle/service: Default constructors and destructors in the cpp file where applicable 
When a destructor isn't defaulted into a cpp file, it can cause the use
of forward declarations to seemingly fail to compile for non-obvious
reasons. It also allows inlining of the construction/destruction logic
all over the place where a constructor or destructor is invoked, which
can lead to code bloat. This isn't so much a worry here, given the
services won't be created and destroyed frequently.

The cause of the above mentioned non-obvious errors can be demonstrated
as follows:

------- Demonstrative example, if you know how the described error happens, skip forwards -------

Assume we have the following in the header, which we'll call "thing.h":

\#include <memory>

// Forward declaration. For example purposes, assume the definition
// of Object is in some header named "object.h"
class Object;

class Thing {
public:
    // assume no constructors or destructors are specified here,
    // or the constructors/destructors are defined as:
    //
    // Thing() = default;
    // ~Thing() = default;
    //

    // ... Some interface member functions would be defined here

private:
    std::shared_ptr<Object> obj;
};

If this header is included in a cpp file, (which we'll call "main.cpp"),
this will result in a compilation error, because even though no
destructor is specified, the destructor will still need to be generated by
the compiler because std::shared_ptr's destructor is *not* trivial (in
other words, it does something other than nothing), as std::shared_ptr's
destructor needs to do two things:

1. Decrement the shared reference count of the object being pointed to,
   and if the reference count decrements to zero,

2. Free the Object instance's memory (aka deallocate the memory it's
   pointing to).

And so the compiler generates the code for the destructor doing this inside main.cpp.

Now, keep in mind, the Object forward declaration is not a complete type. All it
does is tell the compiler "a type named Object exists" and allows us to
use the name in certain situations to avoid a header dependency. So the
compiler needs to generate destruction code for Object, but the compiler
doesn't know *how* to destruct it. A forward declaration doesn't tell
the compiler anything about Object's constructor or destructor. So, the
compiler will issue an error in this case because it's undefined
behavior to try and deallocate (or construct) an incomplete type and
std::shared_ptr and std::unique_ptr make sure this isn't the case
internally.

Now, if we had defaulted the destructor in "thing.cpp", where we also
include "object.h", this would never be an issue, as the destructor
would only have its code generated in one place, and it would be in a
place where the full class definition of Object would be visible to the
compiler.

---------------------- End example ----------------------------

Given these service classes are more than certainly going to change in
the future, this defaults the constructors and destructors into the
relevant cpp files to make the construction and destruction of all of
the services consistent and unlikely to run into cases where forward
declarations are indirectly causing compilation errors. It also has the
plus of avoiding the need to rebuild several services if destruction
logic changes, since it would only be necessary to recompile the single
cpp file.
 7 years ago
Lioncash 20c976ff2a service/time: Amend command IDs of ToPosixTime() and ToPosixTimeWithMyRule() 
Updates the ID of these based off the information on Switch Brew.
 7 years ago
Mat M 1e4935c3a0
Merge pull request #801 from lioncash/time 
time: Add the time:a service
 7 years ago
Lioncash 3c1cb3b11e time: Add the time:a service 
Given we already have time:s and time:u, we should also have time:a
 7 years ago
Lioncash a61124a9e7 time: Simplify interface creation 
We can use one instance of the interface instead of duplicating code.
 7 years ago
MerryMage 44646e2ea0 core_timing: Split off utility functions into core_timing_util 7 years ago
James Rowe 638956aa81 Rename logging macro back to LOG_* 8 years ago
mailwl 11568c2ea3 Service/time: implement posix time to calendar conversion 8 years ago
Lioncash 7c9644646f
general: Make formatting of logged hex values more straightforward 
This makes the formatting expectations more obvious (e.g. any zero padding specified
is padding that's entirely dedicated to the value being printed, not any pretty-printing
that also gets tacked on).
 8 years ago
Lioncash 0197e28cc9
core_timing: Namespace all functions and constants in core_timing's header 
All of these variables and functions are related to timings and should be within the namespace.
 8 years ago
Lioncash bd9c2aa51f
time: Move logging macros over to new fmt-compatible ones 8 years ago
Lioncash ccca5e7c28 service: Use nested namespace specifiers where applicable 
Tidies up namespace declarations
 8 years ago
Hexagon12 e52a87b98a Various service name fixes - part 2 (rebased) (#322) 
* Updated ACC with more service names

* Updated SVC with more service names

* Updated set with more service names

* Updated sockets with more service names

* Updated SPL with more service names

* Updated time with more service names

* Updated vi with more service names
 8 years ago
N00byKing ef875d6a35 Clean Warnings (?) 8 years ago
shinyquagsire23 944132dbe5 time: Add GetStandardLocalSystemClock, used by libnx 8 years ago
mailwl 335096e19a Service: stub some functions in am, audio, time, vi services 8 years ago
bunnei 8e1dbb26bd logger: Add Time service logging category. 8 years ago
bunnei 3258db29da time: Implement ISteadyClock::GetCurrentTimePoint. 8 years ago
bunnei f0b6baf3ad time: Stub GetSystemClockContext function. 8 years ago
bunnei 1b1d399e5f hle: Rename RequestBuilder to ResponseBuilder. 8 years ago
bunnei f9dae99006 service: Fix all incorrect IPC response headers. 8 years ago
gdkchan 703be1931a Fix time returning epoch time in milliseconds rather than in seconds 8 years ago
Subv b0489c9a64 Services: Added a todo about returning interfaces as domain objects in lm, hid and time. 8 years ago
Subv 7efa6e8801 Time: Don't create unnecessary ports when retrieving the clock service sessions. 8 years ago
bunnei e27accc15d time: Stub out GetTotalLocationNameCount and some cleanup. 8 years ago
Rozlette 378cea2ae2 time: Fix use of CamelCase in ToCalendarTimeWithMyRule 8 years ago
Rozlette c7c180fdf1 time: Refactor time:* to use a single shared module 8 years ago
Rozlette 6f22471a72 TIME: consolidate time:* interfaces, stub functions and structs 8 years ago
bunnei 7bedea73a8 time: Implement GetStandardUserSystemClock, GetCurrentTime. 8 years ago