Lioncash
ffc66f089d
decoder/texture: Eliminate narrowing conversion in GetTldCode()
...
The assignment was previously truncating a u64 value to a bool.
4 years ago
Lioncash
362e2940be
audio_core/command_generator: Use const references where applicable
...
In a lot of cases, we can make use of const references rather than
non-const references.
While we're in the area we can silence some truncation and sign
conversion warnings.
4 years ago
Lioncash
9539e4d8fd
audio_core/command_generator: Avoid an unnecessary copy in GenerateFinalMixCommand()
4 years ago
Lioncash
aca3621146
nfp: Eliminate two unnecessary copies
...
GetAmiiboBuffer() returns by const reference, so we can use a reference
instead of taking the returned buffer by value.
4 years ago
Lioncash
1ee9ceb5af
arm_dynarmic_cp15: Initialize member variables
...
Ensures that the member variables are always initialized to a
deterministic value on creation.
4 years ago
bunnei
382bf1faf4
Merge pull request #4668 from lioncash/port
...
control_metadata: Resolve typo in Portuguese language name
4 years ago
Lioncash
02b8b6677a
control_metadata: Resolve typo in Portuguese language name
...
This isn't used anywhere, so this is a trivial fix.
4 years ago
Lioncash
8bbd82863d
service: Remove unused funcation
...
This is now completely unused, so it can be removed.
4 years ago
Lioncash
057aa6275d
service/sm: Slightly more efficient string name validation
...
We can check the end of the string first for null-termination, rather
than the beginning of the string.
4 years ago
Lioncash
78b1bc3b61
service/sm: Eliminate dependency on the global system instance
4 years ago
bunnei
fcd0925ecf
Merge pull request #4653 from ReinUsesLisp/gc-warns
...
gc_adapter: Disable MSVC nonstandard extension warning on libusb.h
4 years ago
bunnei
1eae35621e
Merge pull request #4663 from ReinUsesLisp/wswitch
...
video_core: Enforce -Werror=switch
4 years ago
Rodrigo Locatti
62de0220fe
Merge pull request #4662 from lioncash/factory
...
bis_factory/romfs_factory: Eliminate dependencies on the global system instance
4 years ago
Lioncash
a62c1999c5
file_sys/romfs_factory: Eliminate usage of the global system accessor
4 years ago
Lioncash
0e80567bef
file_sys/bis_factory: Eliminate usage of the global system accessor
4 years ago
Lioncash
aa8d6fc041
loader/nso: Remove unnecessary [[maybe_unused]]
4 years ago
Rodrigo Locatti
b0ae8265ea
Merge pull request #4661 from lioncash/system-loader
...
core/loader: Remove dependencies on the global system instance
4 years ago
ReinUsesLisp
eb914b6c50
video_core: Enforce -Werror=switch
...
This forces us to fix all -Wswitch warnings in video_core.
4 years ago
Lioncash
113a3972a6
core/loader: Remove dependencies on the global system instance
...
Now all that remains is:
18 instances in file_sys code
14 instances in GDB stub code (this can be tossed wholesale)
4 instances in HLE code
2 instances in settings code.
4 years ago
Rodrigo Locatti
004bfefeb5
Merge pull request #4658 from lioncash/copy3
...
nca_patch: Reduce stack usage size within SearchBucketEntry()
4 years ago
Rodrigo Locatti
9cd1ea338b
Merge pull request #4657 from lioncash/cheatparser
...
cheat_engine: Remove unnecessary system argument to CheatParser's Parse function
4 years ago
Lioncash
66fc037ef2
nca_patch: Significantly reduce the stack usage size within SearchBucketEntry()
...
Previously this function was using ~16KB of stack (16528 bytes), which
was caused by the function arguments being taken by value rather than by
reference.
We can make this significantly lighter on the stack by taking them by
reference.
4 years ago
Lioncash
99b372a6c5
nca_patch: Make SearchBucketEntry() internally linked
...
This is only used internally and doesn't depend on any class state, so
we can make it fully internal.
4 years ago
Lioncash
3a8464cde2
cheat_engine: Convert ExtractName into a non-template function
...
We don't need to create two separate instantiations of the same code, we
can simply make the character template argument a regular function
parameter.
4 years ago
Lioncash
ba7eb5abf4
cheat_engine: Remove unnecessary system argument to CheatParser's Parse function
...
This isn't used within the function at all in any implementations, so we
can remove it entirely.
4 years ago
Rodrigo Locatti
b5f4221c3d
Merge pull request #4655 from lioncash/internal2
...
patch_manager: Minor cleanup
4 years ago
Lioncash
33e4a0b6c1
patch_manager: Resolve implicit truncations in FormatTitleVersion()
...
We make it explicit that we're truncating arithmetic here to resolve
compiler warnings (even if the sizes weren't u32/u64 arithmetic
generally promotes to int :<)
4 years ago
Lioncash
a4392c24cf
patch_manager: Make use of type aliases
...
We can use these to avoid typing the same type redundantly. This way, if
these ever change, only a single location needs to be modified.
4 years ago
Lioncash
637ab14ae6
patch_manager: Make a few functions internally linked
...
These functions are only used within this translation unit, so we can
make them internally linked.
4 years ago
ReinUsesLisp
bc8ace9917
gc_adapter: Disable MSVC nonstandard extension warning on libusb.h
...
Pragma disable zero-sized array nonstandard extension warning on MSVC.
4 years ago
Rodrigo Locatti
0bac7b6a95
Merge pull request #4652 from lioncash/crypto
...
crypto/key_manager: Remove dependency on the global system accessor
4 years ago
Lioncash
e0dd440b1f
crypto/key_manager: Remove dependency on the global system accessor
...
We can supply the content provider as an argument instead of hardcoding
a global accessor in the implementation.
4 years ago
Rodrigo Locatti
1a9774f824
Merge pull request #4651 from lioncash/kernel-global
...
kernel: Remove all dependencies on the global system instance
4 years ago
Lioncash
ec2a6e5ba8
kernel: Remove all dependencies on the global system instance
...
With this, the kernel finally doesn't depend directly on the global
system instance anymore.
4 years ago
bunnei
042567e4b2
Merge pull request #4636 from lioncash/kernel-hle
...
service: Remove two usages of the global system accessor
4 years ago
bunnei
5fc6bf96d8
Merge pull request #4323 from ReinUsesLisp/no-spin
...
kernel/scheduler: Use std::mutex instead of spin lock
4 years ago
bunnei
508f2072a9
Merge pull request #4645 from v1993/lgtm-less-packages
...
Remove bad and useless packages from LGTM build
4 years ago
bunnei
f4400f3ba2
Merge pull request #4638 from Morph1984/qt-5.12.8
...
cmake: Update to Qt 5.12.8
4 years ago
bunnei
ec634b6a88
Merge pull request #4634 from lioncash/blocking
...
bsd: Resolve a few warnings
4 years ago
bunnei
324029d4f9
Merge pull request #4310 from ogniK5377/apollo-1-prod
...
audio_core: Apollo Part 1, AudioRenderer refactor
4 years ago
Valeri
9f6892271f
Remove bad and useless packages from LGTM build
...
It still fails due to CMake version being 3.13.4, but at
least we are not ones to blame now.
4 years ago
bunnei
03179ecafe
Merge pull request #4597 from Morph1984/mjolnir-p2
...
Project Mjölnir: Part 2 - Controller Applet
4 years ago
bunnei
41b8ecdeb6
Merge pull request #4608 from lioncash/sign3
...
configure_input_player: Resolve sign conversion warnings in UpdateMappingWithDefaults()
4 years ago
FearlessTobi
57162e1df3
Test: Decrease pad_update_ns
...
There have been reports of quite heavy input lag in the past.
Compared to Citra for example, our pad_update_ns value is very high.
So let's decrease it and see if it helps with this problem.
4 years ago
Rodrigo Locatti
663ea382da
Merge pull request #4633 from ReinUsesLisp/gpu-init
...
video_core: Remove all Core::System references in renderer
4 years ago
bunnei
d90961122c
Merge pull request #4635 from lioncash/gc-adap
...
gc_adapter: Make DeviceConnected() a const member function
4 years ago
Morph
09126f3a4a
cmake: Update to Qt 5.12.8
4 years ago
Lioncash
ffdf8c0cb3
service: Remove two usages of the global system accessor
...
Removes more instances of reliance on global state.
4 years ago
Lioncash
c715fc4c5e
gc_adapter: Make DeviceConnected() a const member function
...
This doesn't modify instance state, so it can be made const.
4 years ago
Lioncash
40968e3993
bsd: Resolve unused value within SendToImpl
...
Previously the address provided to SendToImpl would never be propagated
to SendTo(). This fixes that.
4 years ago