Commit Graph

16702 Commits (368b3ee227b9956901b82e97340638a5153e55e3)
 

Author SHA1 Message Date
Lioncash edcbd47800 gl_shader_decompiler: Elide unnecessary copies within DeclareConstantBuffers()
Resolves a -Wrange-loop-analysis warning.
4 years ago
bunnei 5cd051eced
Merge pull request #5149 from comex/xx-map-interval
map_interval: Change field order to address uninitialized field warning
4 years ago
Rodrigo Locatti 12f3b13995
Merge pull request #5159 from lioncash/move-amend
shader_ir: std::move node within DeclareAmend()
4 years ago
Rodrigo Locatti 3ef35207c1
Merge pull request #5160 from lioncash/buffer-header
buffer_block: Remove unnecessary includes
4 years ago
Lioncash 5d2f18fbcd buffer_block: Mark interface as nodiscard where applicable
Prevents logic errors from occurring from unused values.
4 years ago
Lioncash 3954f14c6d buffer_block: Remove unnecessary includes
Reduces the amount of dependencies the header pulls in.
4 years ago
Rodrigo Locatti 9ae6224f12
Merge pull request #5158 from lioncash/video-fmt
video_core: Remove unnecessary enum class casting in logging messages
4 years ago
bunnei a58d57a60d
Merge pull request #5148 from comex/xx-unused-fields
core: Mark unused fields as [[maybe_unused]]
4 years ago
bunnei 24cabf5e2f
Merge pull request #5154 from comex/xx-ipc
hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cpp
4 years ago
Lioncash 7234f436aa shader_ir: std::move node within DeclareAmend()
Same behavior, but elides an unnecessary atomic reference count
increment and decrement.
4 years ago
Lioncash 4c5f5c9bf3 video_core: Remove unnecessary enum class casting in logging messages
fmt now automatically prints the numeric value of an enum class member
by default, so we don't need to use casts any more.

Reduces the line noise a bit.
4 years ago
LC 8a00a0ade6
Merge pull request #5147 from comex/xx-purevirt
nvdrv: Remove useless re-declaration of pure virtual methods that were already declared in the superclass
4 years ago
LC 43f0b42088
Merge pull request #5150 from comex/xx-boxcat
boxcat: Avoid unnecessary object copy
4 years ago
LC 23aabe85e6
Merge pull request #5152 from comex/xx-override
renderer_vulkan: Add missing `override` specifier
4 years ago
LC 69af6ada2f
Merge pull request #5136 from lioncash/video-shadow3
video_core: Resolve more variable shadowing scenarios pt.3
4 years ago
Lioncash 9e7a1f1351 maxwell_3d: Move member variables to end of class
Follows our established coding style.
4 years ago
Lioncash ce0712bf95 maxwell_3d: Resolve -Wdocumentation warning
Removes a documentation comment for a non-existent member.
4 years ago
Lioncash bcc5c4403a maxwell_3d: Remove unused dirty_pointer array
This is unused and removing it shrinks the structure by 3584 bytes.
4 years ago
comex 2dce2be138 configure_motion_touch: Fix unescaped backslash in regex
Since this is inside a string literal, backslashes that are part of
regex syntax have to be escaped.  But that's ugly, so convert to a raw
string instead.
4 years ago
comex 0791082b43 network, sockets: Replace `POLL_IN`, `POLL_OUT`, etc. constants with an `enum class PollEvents`
Actually, two enum classes, since for some reason there are two separate
yet identical `PollFD` types used in the codebase.  I get that one is
ABI-compatible with the Switch while the other is an abstract type used
for the host, but why not use `WSAPOLLFD` directly for the latter?

Anyway, why make this change?  Because on Apple platforms, `POLL_IN`,
`POLL_OUT`, etc. (with an underscore) are defined as macros in
<sys/signal.h>.  (This is inherited from FreeBSD.)  So defining
a variable with the same name causes a compile error.

I could just rename the variables, but while I was at it I thought I
might as well switch to an enum for stronger typing.

Also, change the type used for values copied directly to/from the
`events` and `revents` fields of the host *native*
`pollfd`/`WSASPOLLFD`, from `u32` to `short`, as `short` is the correct
canonical type on both Unix and Windows.
4 years ago
LC 5933667cb8
Merge pull request #5155 from comex/xx-default
Fix "explicitly defaulted but implicitly deleted" warning
4 years ago
comex e31cb50405 Fix "explicitly defaulted but implicitly deleted" warning
`PhysicalCore`'s move assignment operator was declared as `= default`,
but was implicitly deleted because `PhysicalCore` has fields
of reference type.  Switch to explicitly deleting it to avoid a Clang
warning.

The move *constructor* is still defaulted, and is required to exist due
to the use of `std::vector<PhysicalCore>`.
4 years ago
comex 3373149fdc hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cpp
- Add a type check so that calling Push with an invalid type produces a
  compile error rather than a linker error.

- vi.cpp was calling Push with a variable of type `std::size_t`.
  There's no explicit overload for `size_t`, but there is one for `u64`,
  which on most platforms is the same type as `size_t`.  On macOS,
  however, it isn't: both types are 64 bits, but `size_t` is `unsigned
  long` and `u64` is `unsigned long long`.  Regardless, it makes more
  sense to explicitly use `u64` here instead of `size_t`.
4 years ago
comex 0e122c13ad CMakeLists,network: Create YUZU_UNIX macro to replace __unix__
__unix__ is not predefined on Apple platforms even though they are Unix.
4 years ago
comex eea5122d1b renderer_vulkan: Add missing `override` specifier 4 years ago
comex b8fbf6969c map_interval: Change field order to address uninitialized field warning
Clang complains about `new_chunk`'s constructor using the
then-uninitialized `first_chunk` (even though it's just to get a pointer
into it).
4 years ago
comex feac654ba0 core: Mark unused fields as [[maybe_unused]] 4 years ago
comex 5cb1a343d1 boxcat: Avoid unnecessary object copy 4 years ago
LC 0dc234c5ea
Merge pull request #5146 from comex/xx-num
video_core: Adjust `NUM` macro to avoid Clang warning
4 years ago
comex 716ae72aac nvdrv: Remove useless re-declaration of pure virtual methods that were already declared in the superclass 4 years ago
comex d637114c17 video_core: Adjust `NUM` macro to avoid Clang warning
The previous definition was:

    #define NUM(field_name) (sizeof(Maxwell3D::Regs::field_name) / sizeof(u32))

In cases where `field_name` happens to refer to an array, Clang thinks
`sizeof(an array value) / sizeof(a type)` is an instance of the idiom
where `sizeof` is used to compute an array length.  So it thinks the
type in the denominator ought to be the array element type, and warns if
it isn't, assuming this is a mistake.

In reality, `NUM` is not used to get array lengths at all, so there is no
mistake.  Silence the warning by applying Clang's suggested workaround
of parenthesizing the denominator.
4 years ago
Rodrigo Locatti 7e5f595b31
Merge pull request #5143 from comex/xx-users-size
yuzu_cmd: Remove 'users_size'
4 years ago
Rodrigo Locatti 88959b0047
Merge pull request #5141 from comex/xx-true-false
maxwell_dma: Rename RenderEnable::Mode::FALSE and TRUE to avoid name conflict
4 years ago
bunnei dd05c7ec79
Merge pull request #5140 from FearlessTobi/port-5577
Port citra-emu/citra#5577: "Update cubeb and request a persistent stream session"
4 years ago
bunnei 53a04d6b5d
Merge pull request #5132 from lioncash/xbyak-abi
xbyak_abi: Avoid implicit sign conversions
4 years ago
bunnei c67c25db05
Merge pull request #5139 from lioncash/deprecated-qt
game_list_p: Resolve deprecated usage of QVariant operator<
4 years ago
bunnei 1bdb756d28 hle: kernel: Process: Various style fixes based on code review feedback. 4 years ago
bunnei d4ae0ae0e9 core: cpu_manager: Fix a typo in PreemptSingleCore, which broke many games.
- We were reload'ing the old current scheduler, which may have changed.
4 years ago
bunnei 9b492430bb hle: kernel: Thread: Various style fixes based on code review feedback. 4 years ago
bunnei ed4d1e2ade hle: kernel: KScopedSchedulerLockAndSleep: Various style fixes based on code review feedback. 4 years ago
bunnei b1b4f2337e hle: kernel: KScopedLock: Various style fixes based on code review feedback. 4 years ago
bunnei 165d8485f0 hle: kernel: KAbstractSchedulerLock: Various style fixes based on code review feedback. 4 years ago
bunnei 960500cfd2 hle: kernel: KScheduler: Various style fixes based on code review feedback. 4 years ago
bunnei 8fd921557f hle: kernel: KPriorityQueue: Various style fixes based on code review feedback. 4 years ago
bunnei 4d3be1816c hle: kernel: KAffinityMask: Various style fixes based on code review feedback. 4 years ago
bunnei 357d79fb6e hle: kernel: GlobalSchedulerContext: Various style fixes based on code review feedback. 4 years ago
bunnei d2c0c94f0b common: BitSet: Various style fixes based on code review feedback. 4 years ago
bunnei b1326d9230 hle: kernel: Use C++ style comments in KScheduler, etc. 4 years ago
bunnei bc59ca92b6 kernel: KScopedSchedulerLockAndSleep: Remove unused ctor. 4 years ago
bunnei b9b7e4f915 kernel: time_manager: Add missing lock guards. 4 years ago