From 16ed9da0cb81e3972895d846e9bd39353fc87681 Mon Sep 17 00:00:00 2001
From: moonrailgun <moonrailgun@gmail.com>
Date: Tue, 5 Dec 2023 23:17:24 +0800
Subject: [PATCH] refactor: remove error handle continue logic and make it
 throw error

its useful to help react query whether storage return data
---
 client/shared/api/request.ts | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/client/shared/api/request.ts b/client/shared/api/request.ts
index 9d53fe51..d5909450 100644
--- a/client/shared/api/request.ts
+++ b/client/shared/api/request.ts
@@ -72,11 +72,12 @@ function createRequest() {
         }
       }
 
+      // comment it logic because if not throw error, react query will cache `{ data: { result: false, msg: errorMsg, code } }` and has some problem
       if (_isFunction(getErrorHook)) {
         const isContinue = getErrorHook(err);
-        if (isContinue === false) {
-          return { data: { result: false, msg: errorMsg, code } };
-        }
+        // if (isContinue === false) {
+        //   return { data: { result: false, msg: errorMsg, code } };
+        // }
       }
 
       throw new RequestError(errorMsg ?? err.message);