From 4cfc90277eafe773ef5b595fde340c2dcc8eec7f Mon Sep 17 00:00:00 2001
From: zijiren233 <pyh1670605849@gmail.com>
Date: Sun, 18 Feb 2024 23:56:07 +0800
Subject: [PATCH] Opt: auto admin,root middlewares reuse AuthUserMiddleware

---
 server/middlewares/auth.go | 93 +++++++++++++-------------------------
 1 file changed, 31 insertions(+), 62 deletions(-)

diff --git a/server/middlewares/auth.go b/server/middlewares/auth.go
index e11deb6..80728d3 100644
--- a/server/middlewares/auth.go
+++ b/server/middlewares/auth.go
@@ -12,6 +12,7 @@ import (
 	"github.com/synctv-org/synctv/internal/conf"
 	"github.com/synctv-org/synctv/internal/op"
 	"github.com/synctv-org/synctv/server/model"
+	"github.com/zijiren233/gencontainer/synccache"
 	"github.com/zijiren233/stream"
 )
 
@@ -180,18 +181,17 @@ func NewAuthRoomToken(user *op.User, room *op.Room) (string, error) {
 	return jwt.NewWithClaims(jwt.SigningMethodHS256, claims).SignedString(stream.StringToBytes(conf.Conf.Jwt.Secret))
 }
 
-func AuthRoomMiddleware(ctx *gin.Context) {
+func AuthUserMiddleware(ctx *gin.Context) {
 	token, err := GetAuthorizationTokenFromContext(ctx)
 	if err != nil {
 		ctx.AbortWithStatusJSON(http.StatusUnauthorized, model.NewApiErrorResp(err))
 		return
 	}
-	userE, roomE, err := AuthRoom(token)
+	userE, err := AuthUser(token)
 	if err != nil {
 		ctx.AbortWithStatusJSON(http.StatusUnauthorized, model.NewApiErrorResp(err))
 		return
 	}
-
 	user := userE.Value()
 	if user.IsBanned() {
 		ctx.AbortWithStatusJSON(http.StatusForbidden, model.NewApiErrorStringResp("user banned"))
@@ -202,41 +202,28 @@ func AuthRoomMiddleware(ctx *gin.Context) {
 		return
 	}
 
-	room := roomE.Value()
-	if room.IsBanned() {
-		ctx.AbortWithStatusJSON(http.StatusForbidden, model.NewApiErrorStringResp("room banned"))
-		return
-	}
-	if room.IsPending() {
-		ctx.AbortWithStatusJSON(http.StatusForbidden, model.NewApiErrorStringResp("room is pending, need admin to approve"))
-		return
-	}
-
 	ctx.Set("user", userE)
-	ctx.Set("room", roomE)
 	log := ctx.MustGet("log").(*logrus.Entry)
 	if log.Data == nil {
-		log.Data = make(logrus.Fields, 5)
+		log.Data = make(logrus.Fields, 3)
 	}
-	log.Data["rid"] = room.ID
-	log.Data["rnm"] = room.Name
 	log.Data["uid"] = user.ID
 	log.Data["unm"] = user.Username
 	log.Data["uro"] = user.Role.String()
-	ctx.Next()
 }
 
-func AuthUserMiddleware(ctx *gin.Context) {
+func AuthRoomMiddleware(ctx *gin.Context) {
 	token, err := GetAuthorizationTokenFromContext(ctx)
 	if err != nil {
 		ctx.AbortWithStatusJSON(http.StatusUnauthorized, model.NewApiErrorResp(err))
 		return
 	}
-	userE, err := AuthUser(token)
+	userE, roomE, err := AuthRoom(token)
 	if err != nil {
 		ctx.AbortWithStatusJSON(http.StatusUnauthorized, model.NewApiErrorResp(err))
 		return
 	}
+
 	user := userE.Value()
 	if user.IsBanned() {
 		ctx.AbortWithStatusJSON(http.StatusForbidden, model.NewApiErrorStringResp("user banned"))
@@ -247,71 +234,53 @@ func AuthUserMiddleware(ctx *gin.Context) {
 		return
 	}
 
+	room := roomE.Value()
+	if room.IsBanned() {
+		ctx.AbortWithStatusJSON(http.StatusForbidden, model.NewApiErrorStringResp("room banned"))
+		return
+	}
+	if room.IsPending() {
+		ctx.AbortWithStatusJSON(http.StatusForbidden, model.NewApiErrorStringResp("room is pending, need admin to approve"))
+		return
+	}
+
 	ctx.Set("user", userE)
+	ctx.Set("room", roomE)
 	log := ctx.MustGet("log").(*logrus.Entry)
 	if log.Data == nil {
-		log.Data = make(logrus.Fields, 3)
+		log.Data = make(logrus.Fields, 5)
 	}
+	log.Data["rid"] = room.ID
+	log.Data["rnm"] = room.Name
 	log.Data["uid"] = user.ID
 	log.Data["unm"] = user.Username
 	log.Data["uro"] = user.Role.String()
-	ctx.Next()
 }
 
 func AuthAdminMiddleware(ctx *gin.Context) {
-	token, err := GetAuthorizationTokenFromContext(ctx)
-	if err != nil {
-		ctx.AbortWithStatusJSON(http.StatusUnauthorized, model.NewApiErrorResp(err))
-		return
-	}
-	userE, err := AuthUser(token)
-	if err != nil {
-		ctx.AbortWithStatusJSON(http.StatusUnauthorized, model.NewApiErrorResp(err))
+	AuthUserMiddleware(ctx)
+	if ctx.IsAborted() {
 		return
 	}
-	user := userE.Value()
-	if !user.IsAdmin() {
+
+	userE := ctx.MustGet("user").(*synccache.Entry[*op.User])
+	if !userE.Value().IsAdmin() {
 		ctx.AbortWithStatusJSON(http.StatusForbidden, model.NewApiErrorStringResp("user is not admin"))
 		return
 	}
-
-	ctx.Set("user", userE)
-	log := ctx.MustGet("log").(*logrus.Entry)
-	if log.Data == nil {
-		log.Data = make(logrus.Fields, 3)
-	}
-	log.Data["uid"] = user.ID
-	log.Data["unm"] = user.Username
-	log.Data["uro"] = user.Role.String()
-	ctx.Next()
 }
 
 func AuthRootMiddleware(ctx *gin.Context) {
-	token, err := GetAuthorizationTokenFromContext(ctx)
-	if err != nil {
-		ctx.AbortWithStatusJSON(http.StatusUnauthorized, model.NewApiErrorResp(err))
-		return
-	}
-	userE, err := AuthUser(token)
-	if err != nil {
-		ctx.AbortWithStatusJSON(http.StatusUnauthorized, model.NewApiErrorResp(err))
+	AuthUserMiddleware(ctx)
+	if ctx.IsAborted() {
 		return
 	}
-	user := userE.Value()
-	if !user.IsRoot() {
+
+	userE := ctx.MustGet("user").(*synccache.Entry[*op.User])
+	if !userE.Value().IsRoot() {
 		ctx.AbortWithStatusJSON(http.StatusForbidden, model.NewApiErrorStringResp("user is not root"))
 		return
 	}
-
-	ctx.Set("user", userE)
-	log := ctx.MustGet("log").(*logrus.Entry)
-	if log.Data == nil {
-		log.Data = make(logrus.Fields, 3)
-	}
-	log.Data["uid"] = user.ID
-	log.Data["unm"] = user.Username
-	log.Data["uro"] = user.Role.String()
-	ctx.Next()
 }
 
 func GetAuthorizationTokenFromContext(ctx *gin.Context) (string, error) {