You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
suricata/rust
Shivani Bhardwaj 91353fdb61 mqtt: trigger raw stream reassembly
Internals
---------
Suricata's stream engine returns data for inspection to the detection
engine from the stream when the chunk size is reached.

Bug
---
Inspection triggered only in the specified chunk sizes may be too late
when it comes to inspection of smaller protocol specific data which
could result in delayed inspection, incorrect data logged with a transaction
and logs misindicating the pkt that triggered an alert.

Fix
---
Fix this by making an explicit call from all respective applayer parsers to
trigger raw stream reassembly which shall make the data available for inspection
in the following call of the stream engine. This needs to happen per direction
on the completion of an entity like a request or a response.

Important notes
---------------
1. The above mentioned behavior with and without this patch is
affected internally by the following conditions.
- inspection depth
- stream depth
In these special cases, the inspection window will be affected and
Suricata may not consider all the data that could be expected to be
inspected.
2. This only applies to applayer protocols running over TCP.
3. The inspection window is only considered up to the ACK'd data.
4. This entire issue is about IDS mode only.

MQTT creates a transaction per message per direction, so, a call to
trigger raw stream reassembly has been made on completion of each
transaction in the respective direction.

Optimization 7026
Bug 7004
1 year ago
..
.cargo rust: rename .cargo/config to .cargo/config.toml 2 years ago
derive rust: derive for AppLayerState 1 year ago
htp http1: use a tx iterator 1 year ago
src mqtt: trigger raw stream reassembly 1 year ago
suricatactl suricatactl: add description to Cargo.toml 1 year ago
suricatasc rust: pin once_cell to work with Rust 1.67.1 1 year ago
sys detect/xform: Support transform identity data 1 year ago
.gitignore rust: rename .cargo/config to .cargo/config.toml 2 years ago
Cargo.lock.in http1: brotli decompression 1 year ago
Cargo.toml.in rust: use flate2 with C zlib 1 year ago
Makefile.am rust: always update Cargo.lock.in 1 year ago
cbindgen.toml rust: bindgen detect-engine-helper.h 1 year ago
rustfmt.toml rustfmt: replace deprecated fn_args_layout with fn_params_layout 3 years ago