75 Commits (suricata-7.0.7)

Author	SHA1	Message	Date
Philippe Antoine	b556619213	rust/probing: safety check for null input ... Ticket: 7013 Done consistently for all protocols This may change some protocols behaviors which failed early if they found there was not enough data... (cherry picked from commit 37a9003736)	1 year ago
Daniel Olatunji	5c0af0b203	rust/doc: add docstring to rust module files. ... Issue: #4584	2 years ago
Philippe Antoine	7ca43e7e1f	output/snmp: log version from tx ... and not the one from state If a SNMP flow starts with a V2 version transaction, then there is a V3i version transaction, we will now log V3 for the second transaction	2 years ago
Victor Julien	cdd3251982	snmp: fix spelling ... Thanks to Josh Soref.	2 years ago
Jason Ish	0e55307c1d	app-layer: remove APP_LAYER_PARSER_OPT_UNIDIR_TXS ... This flag is no longer needed as a parser can now create a transaction as unidirectional. Setting this flag also doesn't make sense on parsers that may have request/reply and some unidirectional messaging.	2 years ago
Jason Ish	3d9fc3bf1d	rust: update snmp-parser to 0.9.0 ... Updating snmp-parser required directly depending on the asn1-rs crate for the Oid type, as snmp-parser does not re-export this type anymore. Ticket: #5992	2 years ago
Jason Ish	8ef410e284	app-layer: add direction to transaction creation where needed ... Build on Eric's but set the direction on transaction creation when needed. I think this makes it a little more clear, and easier to document when creating single direction transactions. This also somewhat abstracts the inner-workings of a directional transaction from the implementation. Ticket: #4759	2 years ago
Eric Leblond	a82a5aa84b	snmp: add TX orientation ... Set no inspection in the opposite side of the transaction. Ticket: #5799	2 years ago
Jason Ish	e1cffd348f	rust/clippy: fix lint: field_reassign_with_default	3 years ago
Jason Ish	da12b77f18	rust/clippy: fix lint: new_without_default	3 years ago
Jason Ish	f15ffbc869	rust/clippy: fix lint: single_match ... Allow this lint in some cases where a match statement adds clarity.	3 years ago
Philippe Antoine	bc287018e5	rust: cargo clippy --all-features --fix --allow-no-vcs	3 years ago
Jason Ish	b6cc0e25b1	rust: fix clippy lints for clippy::redundant_static_lifetimes	3 years ago
Jason Ish	565da0d0af	rust: fix clippy lints for clippy::redundant_field_names	3 years ago
Jason Ish	f342d4aacd	rust: fix clippy lints for clippy::len_zero	3 years ago
Jason Ish	f60e1b30f6	rust: fix clippy lint for partialeq_to_none ... Use .is_some() and .is_none() instead of comparing against None. Comparing against None requires a value to impl PartialEq, is_none() and is_some() do not and are more idiomatic.	3 years ago
Victor Julien	79499e4769	app-layer: move files into transactions ... Update APIs to store files in transactions instead of the per flow state. Goal is to avoid the overhead of matching up files and transactions in cases where there are many of both. Update all protocol implementations to support this. Update file logging logic to account for having files in transactions. Instead of it acting separately on file containers, it is now tied into the transaction logging. Update the filestore keyword to consider a match if filestore output not enabled.	3 years ago
Victor Julien	c27df6304d	app-layer: introduce common AppLayerStateData API ... Add per state structure for storing flags and other variables.	3 years ago
Pierre Chifflier	beadd090b8	rust: upgrade versions of BER/DER, Kerberos and SNMP parsers	3 years ago
Philippe Antoine	c57052181c	snmp: rustfmt detect.rs	3 years ago
Philippe Antoine	c7214be99b	snmp: adds usm keyword ... as is logged Ticker: #5416	3 years ago
Jason Ish	7b11b4d3a1	app-layer: more generic state trait ... Instead of a method that is required to return a slice of transactions, use 2 methods, one to return the number of transactions in the collection, and another to get a transaction by its index in the collection. This allows for the transaction collection to not be a contiguous array and instead can be a VecDeque, or possibly another collection type that supports retrieval by index. Ticket #5278	3 years ago
Victor Julien	e6f49e5a05	app/frames: implement name to id API for frames	4 years ago
Victor Julien	c073d5cfbf	app-layer: use StreamSlice as input to parsers ... Remove input, input_len and flags in favor of stream slice.	4 years ago
Victor Julien	6466296b32	app-layer: add StreamSlice to pass data to parsers ... Since object to contain relevant pointer, length, offset, flags to make it easy to pass these to the parsers.	4 years ago
Jason Ish	7732efbec2	app-layer: include decoder events in app-layer tx data ... As most parsers use an events structure we can include it in the tx_data structure to reduce some boilerplate/housekeeping code in app-layer parsers.	4 years ago
Jason Ish	9c67c634c1	app-layer: include DetectEngineState in AppLayerTxData ... Every transaction has an existing mandatory field, tx_data. As DetectEngineState is also mandatory, include it in tx_data. This allows us to remove the boilerplate every app-layer has for managing detect engine state.	4 years ago
Jason Ish	3f2d2bc12b	snmp: use generic tx iterator	4 years ago
Shivani Bhardwaj	baf30cfc05	snmp: use Direction enum	4 years ago
Philippe Antoine	28a3181a2d	snmp: fixes leak of de_state ... Bug: #4752.	4 years ago
Sam Muhammed	922a453da5	rust(lint): use is_null() instead of ptr::null_mut() ... Bug: #4594	4 years ago
Jason Ish	18448f6ed6	snmp: use derived app-layer event	4 years ago
Jason Ish	ac3a20b6e0	rust(lint): remove useless conversions and clones ... These add complexity and may not be optimized out by the compiler.	4 years ago
Jason Ish	69cf5c9eea	rust(lint): remove needless borrows ... These are needless borrows (references) as the item is already a reference.	4 years ago
Jason Ish	363b5f99c3	rust: functions that reference raw pointers are unsafe ... Based on the Rust clippy lint that recommends that any public function that dereferences a raw pointer, mark all FFI functions that reference raw pointers with build_slice and cast_pointer as unsafe. This commits starts by removing the unsafe wrapper inside the build_slice and cast_pointer macros then marks all functions that use these macros as unsafe. Then fix all not_unsafe_ptr_arg_deref warnings from clippy. Fixes clippy lint: https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref	4 years ago
Jason Ish	53413f2d7a	rust: remove all usage of transmute ... All cases of our transmute can be replaced with more idiomatic solutions and do no require the power of transmute. When returning an object to C for life-time management, use Box::into_raw to convert the boxed object to pointer and use Box::from_raw to convert back. For cases where we're just returning a pointer to Rust managed data, use a cast.	4 years ago
Philippe Antoine	ef5755338f	rust: SCLogDebug is real nop when built as release ... Before, even if there were no outputs, all the arguments were evaluated, which could turn expensive All variables which are used only in certain build configurations are now prefixed by underscore to avoid warnings	4 years ago
Victor Julien	efc9a7a398	app-layer: remove callback for completion status ... Since the completion status was a constant for all parsers, remove the callback logic and instead register the values themselves. This should avoid a lot of unnecessary callback calls. Update all parsers to take advantage of this.	5 years ago
Jason Ish	fc7d59d92f	snmp: set unidirectional transaction flag	5 years ago
Victor Julien	4da0d9bdea	applayer/rust: expose truncate callback	5 years ago
Philippe Antoine	547d6c2d78	applayer: pass parameter to StateAlloc ... This parameter is NULL or the pointer to the previous state for the previous protocol in the case of a protocol change, for instance from HTTP1 to HTTP2 This way, the new protocol can use the old protocol context. For instance, HTTP2 mimicks the HTTP1 request, to have a HTTP2 transaction with both request and response	5 years ago
Jason Ish	ac93ab281d	rust/logging: allow log macros to be used by plugins ... Fix plugin macros so they can be used by external Rust crates such as plugins.	5 years ago
Shivani Bhardwaj	72dab0a8b7	snmp: convert to jsonbuilder ... Closes redmine ticket 3756.	5 years ago
Jason Ish	53aa967e0b	applayer: add flags to parser registration struct ... This will allow Rust parsers to register for gap handing from Rust (some Rust parsers do handle gaps, but they set the flag from C).	5 years ago
Victor Julien	5dd4d948d9	app-layer: remove unused detect flags API	5 years ago
Victor Julien	c94a5e6392	app-layer/rust: don't use option for GetTxDataFn anymore	5 years ago
Victor Julien	9664f73f75	app-layer: remove logged API calls	5 years ago
Victor Julien	11e2434526	snmp: support AppLayerTxData	5 years ago
Victor Julien	5665fc8301	app-layer: add ApplyTxConfig API ... Optional callback a parser can register for applying configuration to the 'transaction'. Most parsers have a bidirectional tx. For those parsers that have different types of transaction handling, this new callback can be used to properly apply the config.	5 years ago
Victor Julien	411f428a38	app-layer: define AppLayerTxData and AppLayerTxConfig ... AppLayerTxData is a structure each tx should include that will contain the common fields the engine needs for tracking logging, detection and possibly other things. AppLayerTxConfig will be used by the detection engine to configure the transaction.	5 years ago