42 Commits (fbcdd2ec267d49040ca178f8562767d8fb00aa73)

Author	SHA1	Message	Date
Victor Julien	f8aed4ce2d	threading: change local packet queue logic ... Previously each 'TmSlot' had it's own packet queue that was passed to the registered SlotFunc as an argument. This was used mostly for tunnel packets by the decoders and by defrag. This patch removes that in favor of a single queue in the ThreadVars: decode_pq. This is the non-locked version of the queue as this is only a temporary store for handling packets within a thread. This patch removes the PacketQueue pointer argument from the API. The new queue can be accessed directly through the ThreadVars pointer.	6 years ago
Victor Julien	2a55afbd89	decode/pppoe: fix potential crash in debug statement	6 years ago
Victor Julien	579cc9f02b	const: constify decoder, app-layer, detect funcs	6 years ago
Maurizio Abba	55b14f3721	decode: set pktlen of decode handler to uint32 ... Change the decode handler signature to increase the size of its decode handler, from uint16 to uint32. This is necessary to let suricata use interfaces with mtu > 65535 (ex: lo interface has default size 65536). It's necessary to change several primitive for Packet manipulation, to unify the parameter "packet length" whenever we are before IP decoding. Add tests before calling DecodeIPVX function to avoid a possible integer overflow over the len parameter.	7 years ago
Victor Julien	11be9bd971	mingw: add SCNtohl and SCNtohs macro's ... On MinGW the result of ntohl needs to be casted to uint32_t and the result of ntohs to uint16_t. To avoid doing this everywhere add SCNtohl and SCNtohs macros.	8 years ago
Jason Ish	796dd5223b	tests: no longer necessary to provide successful return code ... 1 pass, 0 is fail.	10 years ago
Victor Julien	1c0b4ee0ae	counters: s/SCPerfCounterIncr/StatsIncr/g	11 years ago
Victor Julien	e9b067c1eb	counters: make increment call take threadvars ... This hides the implementation from the caller.	11 years ago
Victor Julien	9a8bff7d96	counters: threadvars s/sc_perf_pca/perf_private_ctx/g	11 years ago
Ken Steele	8f1d75039a	Enforce function coding standard ... Functions should be defined as: int foo(void) { } Rather than: int food(void) { } All functions where changed by a script to match this standard.	11 years ago
Eric Leblond	b2c58b8d14	Set packet invalid flag during decoding. ... This patch set a new value in pkt->flag to signal that a packet is invalid during decoding. The patch has been obtained via a coccinelle transformation.	12 years ago
Eric Leblond	d4b7ecfbe3	decode: update API to return error ... In some cases, the decoding is not possible and some really invalid packet can be created. This is in particular the case of tunnel. In that case, it is more interesting to forget about the tunneled packet and only consider the original packet. DecodeTunnel function is maked as warn_unused_result because it is meaningful for the decoder to know if the underlying data were not correct. And in this case, only focus detection on the content.	12 years ago
Victor Julien	974e86e450	Minor pppoe cleanup ... cppcheck said: [decode-pppoe.c:58] -> [decode-pppoe.c:60]: (performance, inconclusive) Variable 'pppoedh' is reassigned a value before the old one has been used if variable is no semaphore variable.	12 years ago
Anoop Saldanha	619414c59e	Add a /* fall through */ comment for all switch case fall throughs. ... This should server as a message to coverity that the fall through is intentional.	12 years ago
Ken Steele	9c7b411a5d	More PacketGetFromMalloc() to allocate packets.	13 years ago
Eric Leblond	e176be6fcc	Use unlikely for error treatment. ... When handling error case on SCMallog, SCCalloc or SCStrdup we are in an unlikely case. This patch adds the unlikely() expression to indicate this to gcc. This patch has been obtained via coccinelle. The transformation is the following: @istested@ identifier x; statement S1; identifier func =~ "(SCMalloc|SCStrdup|SCCalloc)"; @@ x = func(...) ... when != x - if (x == NULL) S1 + if (unlikely(x == NULL)) S1	13 years ago
Victor Julien	2d16abcf8b	Minor code cleanups fixing all GCC 4.6 compiler warnings for default, debug and unittests mode.	14 years ago
Eric Leblond	acf10525f6	doc: add decode group and related documentation.	14 years ago
Eric Leblond	7425bf5ca6	Rename some decode event structure and macro. ... This patch renames DECODER_SET_EVENT, DECODER_ISSET_EVENT and some other structures to ENGINE equivalent to take into account the fact the event list is now related to all engines and not only to decoder.	14 years ago
Eric Leblond	1db4aadd16	Supress usage of Packet declaration in tests. ... For convenience, a massive usage of 'Packet p;' declaration has been done in the tests function. Although this was completely legal, this is not possible anymore because of the new Packet allocation structure. This massive patch modifies all suricata files to use a SCMalloc allocated pointer to Packet instead. This patch has been done using coccinelle (http://coccinelle.lip6.fr) which is a semantic patching tool. This ensures that things like call to SCFree() should have not been forget because the semantic patch explicitly forces the call to SCFree(p) before each return. With this patch all unittests are running fine with a small and a big default packet size.	15 years ago
Eric Leblond	dd038c1906	Modify files to avoid direct pckt payload access ... This patch implements the needed modification of payload access in a Packet structure to support the abstraction introduced by the extended data system.	15 years ago
William Metcalf	ce01927515	Import of GPLv2 Header 050410	16 years ago
Pablo Rincon	4a351c07a6	Bug 103, bound checks at pppoe, added macros for 4bit fields	16 years ago
Victor Julien	5f5a44b365	PPPoE fixes.	16 years ago
Victor Julien	10cc9d5b6a	Add icmp flow handling.	16 years ago
Victor Julien	ecf86f9c23	Rename to Suricata.	16 years ago
Anoop Saldanha	ceb7e495ae	refactoring perf stats code	16 years ago
Jamie	a914c4e2bf	check that the encapsulated packet is correctly parsed	16 years ago
Breno Silva	c43319c337	Regular expression for UnitTests ... Signed-off-by: Brian Rectanus <brectanu@gmail.com>	16 years ago
Victor Julien	968d8df12b	More logging API usage. Changed logging macro's slightly so the vars inside them won't conflict with vars used by the calling function.	16 years ago
William Metcalf	e95e5cb36a	missing memsets in pppoe unit tests	16 years ago
Jamie	a297225157	victor must be getting sick of PPPoE and ICMP	16 years ago
Jamie	9adfe54620	more unit tests for pppoe - part I	16 years ago
Victor Julien	57f71f7e4b	Pass the DecodeThreadVars to all Decoder functions properly. Improve the error handling.	16 years ago
Anoop Saldanha	244f5d547a	new registration functions for the stats api, with local thread storage for counter ids	16 years ago
Jamie	698e9c0699	fix incorrect offset in decode-ethernet for PPPoE, more debug statements	16 years ago
Victor Julien	f6a8454232	Layout fixes.	16 years ago
Jamie	fdbd09db6c	add perfcounter to pppoe	16 years ago
Jamie	afa8a6766e	test cases for PPPoE, ICMPv4	16 years ago
Brian Rectanus	fa5939ca91	64 bit cleanup part2	16 years ago
Victor Julien	2e4cc2ad3d	Convert tabs to spaces in PPPoE code.	16 years ago
Jamie	8817364ef6	initial PPPoE decoder commit	16 years ago