Jason Ish
							
						 
						
							 
							
							
							
								
							
								bd9adac3ac 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: comments on why we have specific allows  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								dfd7abe185 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: type_complexity  
							
							 
							
							... 
							
							
							
							Convert a DNS sub-parser to use a return type rather than a large
tuple. For mqtt, allow the lint for now, but remove the global allow. 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								e49ce49471 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: allow result_unit_err in http2 only  
							
							 
							
							... 
							
							
							
							Its the only module making use of this pattern, but we shouldn't let
new modules use this pattern. 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								7ba2dadc7f 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: upper_case_acronyms  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								029ac650d7 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: manual_find  
							
							 
							
							... 
							
							
							
							These get_tx methods look like ideal candidates for generic and/or
derived methods. 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								4940dfb3bd 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: len_without_is_empty  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								e1cffd348f 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: field_reassign_with_default  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								9df7c326b9 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: remove allow: collapsible_else_if  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								30ee5fc835 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: remove allow: collapsible_if  
							
							 
							
							... 
							
							
							
							Already clean. 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								da12b77f18 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: new_without_default  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								c4cf062a6f 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: redundant_pattern_matching  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								7c293ff68f 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: never_loop  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								e8823644ec 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: nonminimal_bool  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								53ae0c8a06 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: derive_partial_eq_without_eq  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								5d62995e26 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: explicit_counter_loop  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								f250b92180 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: extra_unused_lifetimes  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								3044565cf4 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: needless_range_loop  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								2ac52d0610 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: remove lint: for_loops_over_fallibles  
							
							 
							
							... 
							
							
							
							Already clean. 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								c026d8531b 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: match_ref_pats  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								359d5fcb7e 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: needless_lifetimes  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								4e001688de 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: remove lint: bool_comparison  
							
							 
							
							... 
							
							
							
							Already clean. 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								f15ffbc869 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: single_match  
							
							 
							
							... 
							
							
							
							Allow this lint in some cases where a match statement adds clarity. 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								925bc74c1f 
								
							
								 
							
						 
						
							
							
								
								rust/clippy: fix lint: while_let_loop  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								cf20fa1e67 
								
							
								 
							
						 
						
							
							
								
								template: import c_void, c_char, c_int  
							
							 
							
							... 
							
							
							
							These are ffi types that are commonly used, import them so they can be
used by their short names instead of a fully qualified name. 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								4220f18258 
								
							
								 
							
						 
						
							
							
								
								template: remove no_mangle and pub where not needed  
							
							 
							
							... 
							
							
							
							Extern functions that are only used as a function pointer do not
require "pub" or "no_mangle". 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								4a7567b3f0 
								
							
								 
							
						 
						
							
							
								
								template: rename template-rust to template  
							
							 
							
							... 
							
							
							
							Remove the distinction between the C template protocol "template" and
the Rust template protocol "template-rust" and make the Rust parser
simply template now that we no longer have support to generate a C
protocol template. 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								38321a213f 
								
							
								 
							
						 
						
							
							
								
								rust/app-layer-template: rustfmt  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								50a787a9a3 
								
							
								 
							
						 
						
							
							
								
								app-layer-template-rust: remove C app-layer stub  
							
							 
							
							... 
							
							
							
							Remove the app-layer-PROTO stub for Rust based parsers.  It is no longer
needed as Rust parsers now contain the registration function in Rust.
Ticket: 4939 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								baa7021ee6 
								
							
								 
							
						 
						
							
							
								
								rust/conf: add fn conf_get_node  
							
							 
							
							... 
							
							
							
							A wrapper around ConfGetNode to get a configuration node by name. 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								64c0459d2d 
								
							
								 
							
						 
						
							
							
								
								rust/lzma: clippy fixup  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								35f99d1af7 
								
							
								 
							
						 
						
							
							
								
								rust/http2: fix clippy lint for is_empty()  
							
							 
							
							... 
							
							
							
							This snuck through as "cargo clippy" check wasn't finding lints that
were fixed by the previous test for fixable lints. 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Todd Mortimer
							
						 
						
							 
							
							
							
								
							
								7d1a8cc335 
								
							
								 
							
						 
						
							
							
								
								file/swf: Use lzma-rs decompression instead of libhtp.  
							
							 
							
							... 
							
							
							
							Use the lzma-rs crate for decompressing swf/lzma files instead of
the lzma decompressor in libhtp. This decouples suricata from libhtp
except for actual http parsing, and means libhtp no longer has to
export a lzma decompression interface.
Ticket: #5638  
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								45eb038e63 
								
							
								 
							
						 
						
							
							
								
								smb: fix file reopening issue  
							
							 
							
							... 
							
							
							
							Fuzzing highlighted an issue where a command sequence on the same file
id triggered a logging issue:
file data for id N
close id N
file data for id N
If this happened in a single blob of data passed to the parser, the
existing file tx would be reused, the file "reopened", confusing the
file logging logic. This would trigger a debug assert.
This patch makes sure a new file tx is created for the file data
coming in after the first file tx is closed.
Bug: #5567 . 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								29f40c9e07 
								
							
								 
							
						 
						
							
							
								
								dcerpc: fix integer underflow  
							
							 
							
							... 
							
							
							
							as input.len() can be 65536, it cannot be directly cast to u16
Ticket: #5557  
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								91617f479a 
								
							
								 
							
						 
						
							
							
								
								rust: sha-1 is now sha1  
							
							 
							
							... 
							
							
							
							This is the same crate, but renamed to be more consistent with the
RustCrypto project naming. Some recent discussion is available here:
    https://github.com/RustCrypto/hashes/issues/438  
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								af44504550 
								
							
								 
							
						 
						
							
							
								
								smb: do not use tree id to match request and response  
							
							 
							
							... 
							
							
							
							Completes commit e94920b49f 
This must be true for access to state ssn2vecoffset_map
Ticket: #5161  
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								cade6046c5 
								
							
								 
							
						 
						
							
							
								
								rust/files: open file without trackid as pointer  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								ad869e1c52 
								
							
								 
							
						 
						
							
							
								
								rust/filecontainer: remove unused declaration  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								086b28da3d 
								
							
								 
							
						 
						
							
							
								
								http2: fix decompression buffering  
							
							 
							
							... 
							
							
							
							It was not enough to set Cursor position to 0,
also its inner Vec should be cleared.
This way, a new input gets written at the beginning of the
Cursor and its inner Vec...
Ticket: #5691  
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								c6349d3cfc 
								
							
								 
							
						 
						
							
							
								
								http2: support padded data frames  
							
							 
							
							... 
							
							
							
							Ticket: #5691  
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								e1ee401a12 
								
							
								 
							
						 
						
							
							
								
								quic: use VecDeque  
							
							 
							
							... 
							
							
							
							Ticket: #5637  
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								286bd2a7ed 
								
							
								 
							
						 
						
							
							
								
								rust: fix cargo clippy --all-features  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								bc287018e5 
								
							
								 
							
						 
						
							
							
								
								rust: cargo clippy --all-features --fix --allow-no-vcs  
							
							 
							
							
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								cd4bf518f3 
								
							
								 
							
						 
						
							
							
								
								rust: fix warnings on rustc 1.67.0-nightly  
							
							 
							
							... 
							
							
							
							warning: for loop over an `Option`. This is more readably written
as an `if let` statement 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Juliana Fajardini
							
						 
						
							 
							
							
							
								
							
								a654ef50de 
								
							
								 
							
						 
						
							
							
								
								pgsql: add test for parameter status parser  
							
							 
							
							... 
							
							
							
							Since we've done some changes to how the parameters are parsed, add one
more test case to check that.
Bug #5579  
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Juliana Fajardini
							
						 
						
							 
							
							
							
								
							
								c4fbd78770 
								
							
								 
							
						 
						
							
							
								
								pgsql: move database into opt parameters list  
							
							 
							
							... 
							
							
							
							For StartupMessages, the database parameter is optional. This moves the
parameter into the optional_parameters list.
Bug #5579  
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								cc68898532 
								
							
								 
							
						 
						
							
							
								
								pgsql: support empty parameter values  
							
							 
							
							... 
							
							
							
							Bug #5579  
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								1e0190bc6b 
								
							
								 
							
						 
						
							
							
								
								pgsql: support out of order parameters for startup message  
							
							 
							
							... 
							
							
							
							As user can be not the first parameter
Bug #5579  
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								1f056f9974 
								
							
								 
							
						 
						
							
							
								
								bittorrent-dht: parse and log node6 lists  
							
							 
							
							... 
							
							
							
							Node6 lists are just like node lists, but for IPv6 addresses. 
							
						 
						
							3 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								86d5ab8644 
								
							
								 
							
						 
						
							
							
								
								bittorrent-dht: remove tests that are no longer valid  
							
							 
							
							
							
						 
						
							3 years ago