Commit Graph

948 Commits (e56afc6d522fbc8e124bf91bb77748b16fa43ae1)

Author SHA1 Message Date
Victor Julien 162ea8f759 doc: fix dcerpc.opnum documentation
Docs were claiming greater than, less than, etc. support even though this was never supported.

Fixes: 51be8f0238 ("doc/dcerpc: add proto keywords")

Ticket: #8330.
(cherry picked from commit 2480f8c038)
2 months ago
Sven Cuyt 3ebe6cd21b doc/userguide: add link to differences-from-snort
Ticket: #8031.
(cherry picked from commit 1246f1cf8c)
2 months ago
Sven Cuyt 77e3876f53 doc/userguide: fix table showing example payload
Ticket: #8031.
(cherry picked from commit a0cc534471)
2 months ago
Sven Cuyt ce533d095b doc/userguide: add example with non-zero offset for relative isdataat
Ticket: #8031.
(cherry picked from commit 2d662538e5)
2 months ago
Victor Julien ab7e871d53 doc/userguide: explain isdataat absolute vs relative difference
Ticket: #8031.
(cherry picked from commit 7c5285e5e6)
2 months ago
Andreas Dolp d2142181c3 doc/userguide: fix within-distance pointer graphics in payload-keywords doc
Redmine ticket: #8261

According to [1], the within pointer (if combined with distance)
includes the distance pointer, which is not clearly visible in the
graphic.

Fixed this in a new graphic by some GIMP arts.

PS: Special thanks to one of our team members Annika C. for initially
spotting this!

[1] https://forum.suricata.io/t/is-within-affected-by-distance/1688

(cherry picked from commit 69eb567dea)
2 months ago
Victor Julien 7759e529de doc/userguide: endswith can be mixed with offset/distance/within
Bug: #5030.
(cherry picked from commit 73a873ecfe)
3 months ago
Jason Ish a6d950315d dnp3: bound the maximum number of objects per tx
Default to 2048, but provide a user configuration value.

Ticket: #8181
(cherry picked from commit 2c95f1ff44)
3 months ago
Jason Ish fdd79bdb14 dnp3: set a bound on the number of points per message
16384 is used as the max, but a configuration parameter has been
provided. The reason for setting an upper bound is that bit flags can
create a memory amplification as we parse them into individual data
structures.

Ticket: #8181
(cherry picked from commit 3a32bb5743)
3 months ago
Jason Ish 635af8dc8b dnp3: reduce flood threshold to 32 and make configurable
Lower the number of unreplied requests from 500 to 32 to consider a
flood. At the very least this is an anomaly given the DNP3 spec mentions
that DNP3 should only have one outstanding request at a time, with an
exception for unsolicited responses, so in practice no more than 2
should be seen.

Additionally make this value configurable by introducing the max-tx
parameter.

Ticket: #8181
(cherry picked from commit a16f087b93)
3 months ago
Shivani Bhardwaj df389f8a43 doc: add dcerpc.max-stub-size config param
(cherry picked from commit 6702791a9c)
3 months ago
Victor Julien ac1e9592ef doc/af-packet: document disable-hwtimestamp option
Ticket: #1954.
(cherry picked from commit be2c40bde7)
4 months ago
Juliana Fajardini 2af9ae4354 devguide: update backports policy for Suricata 7.0
Also remove mentions to `master` and `6.0x`.

Task #7937

(cherry picked from commit 6c06ab6144)
4 months ago
Philippe Antoine 46da609846 detect/ssl: properly handle negation in ssl_version keyword
Ticket: 3220

DetectSslVersionMatch did not handle properly negation.
It could never match on a signatrue with ssl_version: !tls1.3
That is because, if we had such a signature and network traffic
with tls1.1, we were looking into DetectSslVersionData field
for tls1.1, which was not set, instead of looking at field
for tls1.3 which was set with negated flag.

Previous DetectSslVersionData was holding redundant information.
It did not need to have it for each ssl version, but just globally.
Also, it did not need to hold the version as a value in the array,
as it was redundant with the index of the array.

(cherry picked from commit c93e69830a)
4 months ago
Victor Julien 8774212400 exception-policy: rename 'reject-both' to 'rejectboth'
To align it with the rule action.

(cherry picked from commit d3aa4dd85e)
4 months ago
Victor Julien d6577ff5c2 doc/userguide: document reject-both expection policy
Ticket: #5974.
(cherry picked from commit 879561859b)
4 months ago
Juliana Fajardini 82841d614b doc: remove remaining references to pruned flows
These were removed with a5587fec2e but these mentions went under the
radar.

(cherry picked from commit 1647081b29)
5 months ago
Jason Ish 94b5135d26 doc/userguide: add a known issues page
The idea of this page is to track known issues on a release branch
that we do not plan to fix.

(cherry picked from commit a4f722fca0)
6 months ago
Juliana Fajardini a55f3a591e devguide: complement info on branches to work on
With the change from master to main, ensure that we still list examples
of stable branches, as the text also refers to those.
7 months ago
Shivani Bhardwaj df444e3b60 doc: remove outdated GITGUIDE 7 months ago
Shivani Bhardwaj d7cc656c6f doc: adjust for master to main rename 7 months ago
Juliana Fajardini 681cfc95d5 flow/output: make exception policy logging optional
Task #7623
7 months ago
Juliana Fajardini 6186996ba7 flow/output: log triggered exception policies
To accompany the Exception Policy stats, also add information about any
Exception Policy triggered and for which target to the flow log event.

Task #6215

(cherry picked from commit 08e928988f)
7 months ago
Thomas Winter 316627e2f0 doc: Add upgrade note for ppp changes
(cherry picked from commit 0b2dfa2b68)
7 months ago
Juliana Fajardini 9bc1300a31 userguide/exceptions: clarify when stats are logged
The stats for exception policies are only logged/ present when any of
the exception policies are enabled (which means any value other than
"auto" or "ignore" in IDS mode, or "ignore" in IPS mode).

This wasn't clearly stated in the docs.

(cherry picked from commit a9b2a62ee4)
8 months ago
Juliana Fajardini 2f14b17f05 doc/exceptions: change stats counters names
As we've changed them for more search-friendly ones.

Related to
Task #7185

(cherry picked from commit d8c6a56a62)
8 months ago
Juliana Fajardini aa7c0c75f4 userguide: document exception policy stats
Configuration options and defaults, existing counters etc.

Related to
Task #5816

(cherry picked from commit 514e8b8b04)
8 months ago
Juliana Fajardini 19e007404e userguide: highlight exception policy effects
Some exception policies can only be applied to entire flows or
individual packets, for some exception scenarios. Make this easier to
read, in the documentation.

Related to
Task #5816

(cherry picked from commit 94b111283d)
8 months ago
Juliana Fajardini 6cb9a353ec decode/flow: add exception policy stats counters
We will register stats counters for all policies, even though for now
Suri only uses one possible configuration policy at a time. The idea is
that this could change in the near future, so we want to have this
ready.

Task #5816

(cherry picked from commit 657419b53e)
8 months ago
Juliana Fajardini 6c2996ab36 decode/ipv6: set packet flow in ip-in-ip
Based on cherry-picked commit, but adjusted to make changes optional.

Bug #7752

(cherry picked from commit fdf0fa30c6)
8 months ago
Juliana Fajardini 78ece1a7d1 decode: add stats counters for ipv4/ipv6 over ipv4
These existed for ipv6 over ipv6, and ipv4 over ipv6, but not for the
ipv4 counterpart.

Task #7758

(backported from cbe621fb09)
9 months ago
Juliana Fajardini 9939e29f6e decode/ipv4: add missing ip-in-ip case handling
A flow with IPv4 IP in IP traffic won't handle this tunneling case
properly.
This leads to potential malicious traffic not triggering alerts, as well
as other inaccuracies in the logs.

Bug #7725

(cherry-picked from commit e3e24cfb3d)
9 months ago
Juliana Fajardini c02d73f216 docs/exceptions: minor improvements
Add section label and doc reference, add another term to Common terms
section.

Tried to also improve readability for the Midstream behavior tables:
- Highlight key-words when differences are only in `do` vs `no`.
- Change order of sentences in certain descriptions, to align with the
  steps those happen for the engine.

(cherry picked from commit 95560f0966)
9 months ago
Juliana Fajardini c5269e2c26 doc/exceptions: standardize page section markdown
Following the discussion on #7396, use those symbols for to keep the
standard.
Remove the repeting `Exception Policies` section header, too.

Related to
Task #7396

(cherry picked from commit e5c1e5f792)
9 months ago
Juliana Fajardini de5d6df321 doc/exceptions: clarify ambiguous terminology
The terms 'inspection' and 'detection' were being used to signify
different engine actions in this document, while throughout the
documentation and code they're many times interchangeable.

Replace 'inspection' with 'parsing' or even 'decoding and parsing' as
more appropriate.

Add a small glossary to clarify what we mean with those terms.

(cherry picked from commit 0256ce51eb)
9 months ago
Philippe Antoine 7a702031a6 doc: document krb5 event type
Ticket: 6566
(cherry picked from commit 4d4eb84eca)
9 months ago
Philippe Antoine 9fc24564e9 doc: do not have bittorrent in the middle of SMB events
(cherry picked from commit f907216e1a)
9 months ago
Lukas Sismis fce8336c93 pcap-file: document capture method options
(cherry picked from commit eb52e337da)
10 months ago
Lukas Sismis 96b3bc4d9b doc: update available options in the example config
(cherry picked from commit e780a20f82)
10 months ago
Juliana Fajardini f6140df708 upgrade: list inspection recursion default limit
As the yaml indicated before that if no value was specified there were
no limits, and now there will be one.

(cherry picked from commit 3985b24e1b)
1 year ago
Victor Julien d86c5f9f0c datasets: set higher hashsize limits
To avoid possible upgrade issues, allow higher defaults than in the
master branch. Add some upgrade guidance and a note that defaults will
probably be further reduced.
1 year ago
Jason Ish fc6022286c doc/userguide: af-packet upgrade notes
Add note about increased block size and how to change it back to old
defaults if needed.

Ticket: #7458
(cherry picked from commit c6d18fc871)
1 year ago
Philippe Antoine bab716776b detect: limit base64_decode `bytes` to 64KiB
Ticket: 7613

Avoids potential large per-thread memory allocation. A buffer with the
size of the largest decode_base64 buffer size setting would be allocated
per thread. As this was a u32, it could mean a per-thread 4GiB memory
allocation.

64KiB was already the built-in default for cases where bytes size wasn't
specified.

(cherry picked from commit 32d0bd2bbb)
1 year ago
Jeff Lucovsky d56c078193 doc/csum: Stream checksum validation change
Describe the change of behavior between the stream.checksum-validation
setting and checksum-based rule keywords.

(cherry picked from commit cfbf8fda94)
1 year ago
Victor Julien 55b4c1e6fd stream: mark urgent experimental; set safe defaults
Uncomment in default config. This will make the policy "inline",
which is the same behavior as prior to the urgent policy support.

Add line to docs that this is an experimental feature.
1 year ago
Victor Julien faf2613281 doc/userguide: document TCP urgent policy
(cherry picked from commit d11e8a8ee7)
1 year ago
Philippe Antoine a578b0919f doc: improve documentation about guess-applayer-tx
Ticket: 7199
1 year ago
Philippe Antoine 19a638611b detect: log app-layer metadata in alert with single tx
Ticket: 7199

Uses a config parameter detect.guess-applayer-tx to enable
this behavior (off by default)

This feature is requested for use cases with signatures not
using app-layer keywords but still targetting application
layer transactions, such as pass/drop rule combination,
or lua usage.

This overrides the previous behavior of checking if the signature
has a content match, by checking if there is only one live
transaction, in addition to the config parameter being set.

(cherry picked from commit f2c3776314)
1 year ago
Juliana Fajardini cbc0aa57b1 flowint: add isnotset support
Similar keywords use `isnotset`, while `flowint` only accepted `notset`
Opted to change the code, not only the regex, to keep the underlying
code also following the same patterns.

Task #7426

(cherry picked from commit 6e4a501e7c)
1 year ago
Jason Ish ccc61f6294 requires: add option to ignore unknown requirements
The new behavior in 8, and backported is to treat unknown requirements
as unsatisfied requirements.

For 7.0.8, add a configuration option, "ignore-unknown-requirements"
to completely ignore unknown requirements, effectively treating them
as available.

Ticket: #7434
1 year ago