Commit Graph

19043 Commits (dc5185e3555f9c78179df41f0e89c9032f5b302f)
 

Author SHA1 Message Date
Victor Julien bd198231a0 util/port-interval-tree: suppress cppcheck false positives 2 months ago
Victor Julien f138a64ad7 debug/validate: remove redundant checks
Pointed out by cppcheck.
2 months ago
Victor Julien 9869e9b9f5 detect/port: workaround cppcheck warning 2 months ago
Victor Julien 0af57040d9 detect/address: workaround cppcheck warning 2 months ago
Philippe Antoine bcc1e6ae32 rust: format http2 files
Ticket: 3836
2 months ago
Jeff Lucovsky cc6fbcd5dd etc/schema: add missing ftp fields
Add ftp detect keywords to metadata

Issue: 7502, 7503, 7507, 7505, 7508, 7506
2 months ago
Philippe Antoine a35760db9b rust: enforce already formatted directories in CI 2 months ago
Philippe Antoine 1070e733d8 rust: format websocket files
Ticket: 3836
2 months ago
Philippe Antoine 89e5332d88 rust: format utils files
Ticket: 3836
2 months ago
Philippe Antoine edf29b0000 rust: format ssh files
Ticket: 3836
2 months ago
Philippe Antoine fe27a2159c rust: format rfb files
Ticket: 3836
2 months ago
Philippe Antoine 5cca346f16 rust: format quic files
Ticket: 3836
2 months ago
Philippe Antoine 415360d9e8 rust: format ntp files
Ticket: 3836
2 months ago
Philippe Antoine fa864f9c2f rust: format mime files
Ticket: 3836
2 months ago
Philippe Antoine 2cfcaec1b0 rust: format ldap files
Ticket: 3836
2 months ago
Philippe Antoine 64e7c671cc rust: format ftp files
Ticket: 3836
2 months ago
Philippe Antoine f217e249cb rust: format ffi files
Ticket: 3836
2 months ago
Philippe Antoine f7c14809f4 rust: format enip files
Ticket: 3836
2 months ago
Philippe Antoine e526eb8e2b rust: format bittorrent_dht files
Ticket: 3836
2 months ago
Philippe Antoine f5ac0e201c rust: format asn1 files
Ticket: 3836
2 months ago
Philippe Antoine 1ced97bdbb rust: format applayertemplate files
Ticket: 3836
2 months ago
Sergey Pinaev d55114e6d7 detect-engine-analyzer: remove unnecessary check
Always make sure, that smd is not NULL, as we dereference it a few
lines below and base64_data for instance is forbidden as a fast_pattern

Ticket: 8504
2 months ago
Promise Charles 5c9602bcf2 suricata: add error about missing runmode
If a runmode is missing but other params are passed on the commandline,
issue an error.

Ticket: #5711

Signed-off-by: Promise Charles <descencybobby@gmail.com>
2 months ago
Jason Ish 57f76a2462 github-ci: update Fedora builds to Fedora 44 2 months ago
Philippe Antoine 87db89ea4e fuzz: extend fuzz_siginit to do engine-rule-analysis 2 months ago
Philippe Antoine efe3b16aac rust: feature debug in main crate enables feature debug in ffi 2 months ago
Philippe Antoine 5db471500c rust/ffi: remove altemplate plugin last dependency on suricata crate
Ticket: 7666
2 months ago
Philippe Antoine b90adcc2bb rust/ffi: move AppLayerTxData to ffi
Ticket: 7666
2 months ago
Philippe Antoine bce88dd83f rust: build depends on ffi/Cargo.toml.in 2 months ago
Philippe Antoine 0773fba5fd rust/ffi: move txdata flags to ffi
Ticket: 7666
2 months ago
Philippe Antoine 2525ea2e37 rust/ffi: move direction to ffi
Ticket: 7666
2 months ago
Philippe Antoine 5440e41314 rust/ffi: move debug validations macros to ffi
Ticket: 7666
2 months ago
Philippe Antoine 6dff07b631 detect/lua: remove unused macros 2 months ago
Andreas Dolp 2f972b6759 doc: improve manpage of suricatasc
- describe all options
- describe optional socket path

Redmine ticket: #8563
2 months ago
Victor Julien 95b7f2b998 scan-build: support taint filtering
Support scan-build's taint filtering logic. Adds a yaml config to mark
a dedicated debug validation function as filtering a taint.

Use to suppress warnings in reference, threshold and classification file
handling.

Ticket: #3153.
2 months ago
Victor Julien fbaaa9dcae github-actions: update scan-build to clang-22
Run it on Ubuntu 26.04.

Update enabled checkers.

Ticket: #3153.
2 months ago
Victor Julien 524503b572 detect/prefilter: rewrite loop to assist scan-build
Also address a theoretical edge case where memory allocation failure
could lead to overrunning the sids array.
2 months ago
Victor Julien e5650ebcbd scan-build: suppress more warnings 2 months ago
Victor Julien 02f6a4fd87 detect: work around scan-build warning
detect-engine.c:2350:69: warning: Out of bound access to memory after the end of 'new_det_ctx' [security.ArrayBound]
 2350 |             FlowWorkerReplaceDetectCtx(SC_ATOMIC_GET(s->slot_data), new_det_ctx[i]);
      |                                                                     ^~~~~~~~~~~~~~
1 warning generated.
2 months ago
Victor Julien dc6696ac04 bpf: work around scan-build warning
suricata.c:574:5: warning: Potential out of bound access to the heap area with tainted index [security.ArrayBound]
  574 |     bpf_filter[nm] = '\0';
      |     ^~~~~~~~~~~~~~
1 warning generated.
2 months ago
Victor Julien 06dcb5aeb0 detect/flowbits: fix scan-build 0-size alloc warning
detect-flowbits.c:761:29: warning: Call to 'calloc' has an allocation size of 0 bytes [optin.portability.UnixAPI]
  761 |                             SCCalloc(sids_array_size, sizeof(uint32_t));
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./util-mem.h:36:18: note: expanded from macro 'SCCalloc'
   36 | #define SCCalloc calloc
      |                  ^
1 warning generated.
2 months ago
Victor Julien 0c9e17b454 detect/file.data: suppress scan-build false positive 2 months ago
Victor Julien af937f61dc defrag: rearrange Frag struct to save 8 bytes
Avoid large gaps in the layout.
2 months ago
Victor Julien 9d693a72b6 stream: minor code cleanups 2 months ago
Victor Julien 24e7f3439e stream: don't double check pointer
Checked right above it as well.
2 months ago
Victor Julien d17c0bf096 stream: remove error messages in the packet path
Would only happen during allocation failure.
2 months ago
Victor Julien 2bcebe5285 stream: avoid double memset
Already done by StreamTcpThreadCacheGetSegment().
2 months ago
Victor Julien 474788fd49 pool: remove InitData argument
Only used in unittests.

Update Init callback and update callers.
2 months ago
Victor Julien dc05422769 defrag: remove pool Init callback
Built-in callback does the same thing (memset).
2 months ago
Victor Julien a27b9a6c49 defrag: remove unused InitData argument 2 months ago