Commit Graph

14131 Commits (d3675d519701f6a2835109628b1979f44e727c98)
 

Author SHA1 Message Date
Victor Julien 0efdab1f5a membuffer: errno style error reporting 2 years ago
Victor Julien 8ef95c10a8 pool: use errno style error reporting 2 years ago
Victor Julien e621416d80 error: bootstrap errno like error code approach 2 years ago
Victor Julien cdd52dc8cd detect/mpm: output cleanups 2 years ago
Victor Julien cdac0425a8 device: special case handling of dpdk devices 2 years ago
Victor Julien d84bcdfd5c device: output tweak 2 years ago
Victor Julien c78ebd1352 dpdk: set RSS flags for igb driver
Tested on i340.
2 years ago
Victor Julien b08e3e7460 dpdk: ips output cleanups 2 years ago
Victor Julien 62a451a9ab eve/schema: bittorrent format fixup 2 years ago
Victor Julien 70b69a3171 output: minor code cleanups 2 years ago
Victor Julien 10c26bb628 unix-socket: don't print unix socket message twice 2 years ago
Jeff Lucovsky 82158f92c1 general: Correct typos 2 years ago
Victor Julien be895d67b6 runmodes: minor output cleanup 2 years ago
Victor Julien cef0a84bd2 detect: turn cleanup message into debug message 2 years ago
Victor Julien b76f6dfa42 device/mtu: clean up mtu message 2 years ago
Victor Julien 7ccfa9b9a6 device: cleanup stats print 2 years ago
Victor Julien fd4e522038 runmode: log test mode later 2 years ago
Victor Julien 181400bfdd pcap-file: output cleanups 2 years ago
Victor Julien ef881c942b af-packet: output cleanups 2 years ago
Victor Julien 393546af07 mpm/hs: turn cleanup messages in to debug 2 years ago
Victor Julien 892b7021b2 stream: debug message cleanup 2 years ago
Victor Julien d973e1021c threading: memset cpu_set_t to address cppcheck warning
src/tm-threads.c:734:5: error: Uninitialized variable: cs [uninitvar]
    CPU_ZERO(&cs);
2 years ago
Victor Julien 58c28d1778 dpdk: fix cppcheck warnings
src/runmode-dpdk.c:202:11: warning: Size of pointer 'argv' used instead of size of its data. This is likely to lead to a buffer overflow. You probably intend to write 'sizeof(*argv)'. [pointerSize]
    args->argv = SCCalloc(capacity, sizeof(args->argv));
          ^
src/runmode-dpdk.c:777:23: error: Shifting 32-bit value by 63 bits is undefined behaviour [shiftTooManyBits]
        if (bits & (1 << i))
                      ^
src/runmode-dpdk.c:776:23: note: Assuming that condition 'i<64' is not redundant
    for (int i = 0; i < 64; i++) {
                      ^
src/runmode-dpdk.c:777:23: note: Shift
        if (bits & (1 << i))
                      ^
2 years ago
Victor Julien 17cd41c887 frames: suppress cppcheck warning
src/app-layer-frames.c:471:5: warning: Identical condition 'stream_slice->input==NULL', second condition is always false [identicalConditionAfterEarlyExit]
    BUG_ON(stream_slice->input == NULL);
    ^
src/app-layer-frames.c:468:29: note: If condition 'stream_slice->input==NULL' is true, the function will return/exit
    if (stream_slice->input == NULL)
                            ^
src/app-layer-frames.c:471:5: note: Testing identical condition 'stream_slice->input==NULL'
    BUG_ON(stream_slice->input == NULL);
    ^
src/app-layer-frames.c:548:5: warning: Identical condition 'stream_slice->input==NULL', second condition is always false [identicalConditionAfterEarlyExit]
    BUG_ON(stream_slice->input == NULL);
    ^
src/app-layer-frames.c:545:29: note: If condition 'stream_slice->input==NULL' is true, the function will return/exit
    if (stream_slice->input == NULL)
                            ^
src/app-layer-frames.c:548:5: note: Testing identical condition 'stream_slice->input==NULL'
    BUG_ON(stream_slice->input == NULL);
    ^
2 years ago
Victor Julien 16c19bd2f6 capture: remove unnecessary mtu check 2 years ago
Victor Julien f45914cd99 classification: avoid duplicate errors 2 years ago
Victor Julien 7d46d4217f unix-socket: avoid duplicate errors 2 years ago
Victor Julien 4dfb584164 dnp3: no error logging in packet path 2 years ago
dependabot[bot] b4538134fa github-actions: bump actions/checkout from 3.1.0 to 3.2.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.1.0...v3.2.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
Juliana Fajardini 8b56f688a1 github: update contrib guide link in PR template
Even though we have moved the contribution process guide to our read the
docs, the template was still pointing to our redmine link.
2 years ago
Haleema Khan 05e87bf32e detect-detection: Convert unittests to new FAIL/PASS API
Ticket: #4019
2 years ago
Haleema Khan 6094aeee9e detect-detection: Apply clang-format 2 years ago
Victor Julien eb69902719 dpdk: NUMA output adjustments
Reduce verbosity of the NUMA logs; switch them to start with the
iface.

Don't print the cpu number.
2 years ago
Haleema Khan 4a98c4bde6 detect/sigorder: Convert unittests to new FAIL/PASS API
Ticket: #4029
2 years ago
Lukas Sismis 563f8bb56b dpdk: decrease intensity of warnings related to NUMA placement
Ticket: #5617
2 years ago
Victor Julien 991f9fde32 radix: fix ipv6 address parsing warning
The check meant to see if the ip address part of the ip/cidr combo
was more specific than needed wasn't fully implemented, leading to
warnings being issued on completely valid and correct input.

This patch implements the same logic as in IPv4. If the ip address
as specified is different from the ip after the mask has been applied,
a warning is displayed.

Bug: #5747.
2 years ago
Bazzan Don b289030696 detect-engine-tag: convert unittests to new FAIL/PASS API
Ticket: #4030
2 years ago
Bazzan Don 6e4a5cee7a devguide: add page on installing suricata from git
As part of the process of moving documentation from redmine
to "Read the Docs", this commit moves installing Suricata using git
page from redmine wiki into Suricata Developer Guide section.
It also updates the necessary steps.

Ticket: #5585
2 years ago
Philippe Antoine a58ffe5b3e fuzz: do not use timestamps at the end of times
so as not to have integer overflows
2 years ago
Philippe Antoine 190c945e67 ftp: disables debug assertion
Ticket: #5443

Until we decide on the right way to fix this.
2 years ago
Jason Ish 0a4e3d0f82 doc/userguide: ubuntu: install software-properties-common
This package likely needs to be installed when starting with an Ubuntu
container or other minimal Ubuntu install.

Ticket: #5616
2 years ago
Jason Ish bd9adac3ac rust/clippy: comments on why we have specific allows 2 years ago
Jason Ish dfd7abe185 rust/clippy: fix lint: type_complexity
Convert a DNS sub-parser to use a return type rather than a large
tuple. For mqtt, allow the lint for now, but remove the global allow.
2 years ago
Jason Ish e49ce49471 rust/clippy: allow result_unit_err in http2 only
Its the only module making use of this pattern, but we shouldn't let
new modules use this pattern.
2 years ago
Jason Ish 7ba2dadc7f rust/clippy: fix lint: upper_case_acronyms 2 years ago
Jason Ish 029ac650d7 rust/clippy: fix lint: manual_find
These get_tx methods look like ideal candidates for generic and/or
derived methods.
2 years ago
Jason Ish 4940dfb3bd rust/clippy: fix lint: len_without_is_empty 2 years ago
Jason Ish e1cffd348f rust/clippy: fix lint: field_reassign_with_default 2 years ago
Jason Ish 9df7c326b9 rust/clippy: remove allow: collapsible_else_if 2 years ago
Jason Ish 30ee5fc835 rust/clippy: remove allow: collapsible_if
Already clean.
2 years ago