5 Commits (c91546022dc9a2161180ec6efcc62c108eb4f9d4)

Author	SHA1	Message	Date
Ken Steele	8f1d75039a	Enforce function coding standard ... Functions should be defined as: int foo(void) { } Rather than: int food(void) { } All functions where changed by a script to match this standard.	11 years ago
Victor Julien	9abf595122	rohash: fix potential bad shift ... Fix issue detected byCoverity: *** CID 1197756: Bad bit shift operation (BAD_SHIFT) /src/util-rohash.c: 74 in ROHashInit() 68 } 69 if (hash_bits < 4 || hash_bits > 32) { 70 SCLogError(SC_ERR_HASH_TABLE_INIT, "invalid hash_bits setting, valid range is 4-32"); 71 return NULL; 72 } 73 >>> CID 1197756: Bad bit shift operation (BAD_SHIFT) >>> In expression "1U << hash_bits", left shifting by more than 31 bits has undefined behavior. The shift amount, "hash_bits", is as much as 32. 74 uint32_t size = hashsize(hash_bits) * sizeof(ROHashTableOffsets); 75 76 ROHashTable *table = SCMalloc(sizeof(ROHashTable) + size); 77 if (unlikely(table == NULL)) { 78 SCLogError(SC_ERR_HASH_TABLE_INIT, "failed to alloc memory"); 79 return NULL; This was only a potential issue as ROHashInit was only called with hash_bits 16 in the code. Bug #1170.	12 years ago
Eric Leblond	e176be6fcc	Use unlikely for error treatment. ... When handling error case on SCMallog, SCCalloc or SCStrdup we are in an unlikely case. This patch adds the unlikely() expression to indicate this to gcc. This patch has been obtained via coccinelle. The transformation is the following: @istested@ identifier x; statement S1; identifier func =~ "(SCMalloc|SCStrdup|SCCalloc)"; @@ x = func(...) ... when != x - if (x == NULL) S1 + if (unlikely(x == NULL)) S1	13 years ago
Victor Julien	9f7588a756	Add filemd5 keyword that loads a list of md5's to match a file's md5 against.	14 years ago
Victor Julien	8cfc23ee22	Add a new hash datatype to do speedy lookups of read only uniform data, like md5's.	14 years ago