Jason Ish
565da0d0af
rust: fix clippy lints for clippy::redundant_field_names
2 years ago
Jason Ish
5f7ba03e63
rust: fix clippy lints for clippy::needless_bool
2 years ago
Jason Ish
3ec435a703
rust: fix clippy lints for clippy::manual_range_contains
2 years ago
Jason Ish
f342d4aacd
rust: fix clippy lints for clippy::len_zero
2 years ago
Jason Ish
5e5401d3e9
rust: fix clippy lints for clippy::char_lit_as_u8
2 years ago
Jason Ish
29a4a7fddc
rust: fix clippy lints for clippy::assign_op_pattern
2 years ago
Jason Ish
c4034dafa1
rust: fix clippy lints for clippy::derive_partial_eq_without_eq
2 years ago
Jason Ish
5a10fcd2d8
rust: suppress large enum variant lint at location
...
And disable the global lint.
2 years ago
Jason Ish
74b7522b6a
rust/http2: box decompressor variants
...
These variants, in particular the Brotli one can be large at over 2500
bytes which is allocated no matter which decompressor is being used.
Gzip comes in at over 500 bytes. Box deflate for consistency.
2 years ago
Jason Ish
36f8ada305
rust: remove clippy lints that no longer warn
2 years ago
Jason Ish
e8c00dd980
rust: sort clippy allow statements
2 years ago
Haleema Khan
6988168114
src: Use WARN_UNUSED for ByteExtract* functions
...
Add WARN_UNUSED macro for ByteExtract* functions
Fix warning raised in code related to WARN_UNUSED for ByteExtract*
Ticket: #3658
2 years ago
dependabot[bot]
cb8c9d9617
github-actions: bump ossf/scorecard-action from 2.0.4 to 2.0.6
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.0.4 to 2.0.6.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](e363bfca00...99c53751e0
)
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
Alice Akaki
76024f7571
detect-filename: convert unittests to FAIL/PASS APIs
...
Task: #4036
2 years ago
Alice Akaki
8614bff017
detect-filemagic: convert unittests to FAIL/PASS APIs
...
Task: #4034
2 years ago
Lukas Sismis
37cf365e19
docs: remove outdated constraint of negation support for ssl_state
...
Commit 487cdda93d
adds negation support for the SSL state.
2 years ago
Victor Julien
55cf11fdc2
flow/storage: use const for getter
2 years ago
Victor Julien
99fd69ee8c
eve: mac logging code cleanup
2 years ago
Victor Julien
2d79a5206b
eve/drop: log direction if we have a flow
2 years ago
Victor Julien
90f3823cad
eve: log mac addresses in packet direction
2 years ago
Victor Julien
f1068bbb08
dpdk: fix timestamp issues
...
Each thread had its own version of the `machine_start_time`, which
lead to slight time differences. This became apparent mostly in IPS,
where 2 threads each process a side of the flow.
This patch makes the `machine_start_time` global.
2 years ago
Victor Julien
cd2a5ec84f
packet: move action functions to packet files
2 years ago
Victor Julien
0977f40d1c
detect/tag: improve time handling on windows
...
Bug: #5584 .
2 years ago
Victor Julien
410acf226f
detect: unittest guards for ut only function
2 years ago
Victor Julien
60285a629f
detect: remove unused function
2 years ago
Victor Julien
5d6212183b
eve/alert: minor cleanups
2 years ago
Victor Julien
34ee53e5ec
cocci: remove action check as we no longer use macros
2 years ago
Victor Julien
6c200c7793
detect: issue drop to root packet in all cases
...
Update DROP action handling in tunnel packets. DROP/REJECT action is set
to outer (root) and inner packet.
Check action flags both against outer (root) and inner packet.
Remove PACKET_SET_ACTION macro. Replace with RESET for the one reset usecase.
The reason to remove is to make the logic easier to understand.
Reduce scope of RESET macros.
Rename PacketTestAction to PacketCheckAction except in unittests. Keep
PacketTestAction as a wrapper around PacketCheckAction. This makes it
easier to trace the action handling in the real code.
Fix rate_filter setting actions directly.
General code cleanups.
Bug: #5571 .
2 years ago
Victor Julien
79fc8e74cb
packetpool: debug message to assist drop checks
2 years ago
Victor Julien
d1009e295c
packetpool: remove debug validation check
...
Current packet might be the root or a child. Root would have set
drop action set, but Packet::pkt_src might be set in either.
2 years ago
Victor Julien
fe5a8beb50
decode: minor code cleanup
2 years ago
Victor Julien
ba3e0b3155
nfq: set drop reason on verdict error
2 years ago
Victor Julien
a7333a3ea5
napatech: reduce size of Packet structure
...
Put napatech packet vars in the union that is meant for this type of
data.
2 years ago
Juliana Fajardini
e4b46e0763
doc/acknowledgements: add a few more names
...
Added some names of known contributors to the documentation
2 years ago
Juliana Fajardini
3c25185e0b
devguide: add section about stale tickets policy
...
Just to set the right expectations, and to have it registered for us,
too.
2 years ago
Haleema Khan
b31a286952
detect-fileext: convert unittests to FAIL/PASS APIs
...
Fixes Bug: #4033
2 years ago
Haleema Khan
6c922e0b98
rust: fix lint warning for clippy::enum's name
...
Ticket: #4597
2 years ago
Lukas Sismis
5365fdccf7
dpdk: fix mempool cache error message
2 years ago
Shivani Bhardwaj
2a0cb1f3da
doc: update base64_decode notes
2 years ago
Shivani Bhardwaj
7005443b8b
base64: add and clean tests
2 years ago
Shivani Bhardwaj
dad52f133d
base64: add new mode as per RFC 4648
...
As per RFC 4648,
Implementations MUST reject the encoded data if it contains characters
outside the base alphabet when interpreting base-encoded data, unless
the specification referring to this document explicitly states
otherwise.
Add a new mode BASE64_MODE_RFC4648, and handle input strictly as per the
specification.
Bug 5223
2 years ago
Lukas Sismis
e101384e7b
transversal: remove suricata-ids.org references
2 years ago
dependabot[bot]
2158dbf3ba
github-actions: bump actions/checkout from 2 to 3.1.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 2 to 3.1.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v2...v3.1.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
dependabot[bot]
2681d21c11
github-actions: bump actions/cache from 3.0.8 to 3.0.10
...
Bumps [actions/cache](https://github.com/actions/cache ) from 3.0.8 to 3.0.10.
- [Release notes](https://github.com/actions/cache/releases )
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md )
- [Commits](fd5de65bc8...56461b9eb0
)
---
updated-dependencies:
- dependency-name: actions/cache
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
Jason Ish
05900b99cd
github-ci: add workflow for rust clippy
2 years ago
Jason Ish
2a42386c28
rust: fix clippy lint for null comparison
...
Use .is_null() instead of checking for equality against
std::ptr::null().
2 years ago
Jason Ish
45dfea2497
rust/modbus: derive default instead of manual impl
...
Cleans up a clippy lint for a trivial default impl that can be derived.
2 years ago
Jason Ish
9218da0eb8
rust/frames: cleanup clippy lint for unsafe
...
Where possible mark the relevant functions unsafe. Otherwise suppress
the warning for now as this pattern is supposed to be a safe API around
an unsafe one. Might need some further investigation, but in general the
"guarantee" here is provided from the C side.
2 years ago
Jason Ish
105d9a5f02
rust: fix clippy lint for unnecessary_unwrap
...
Avoid check if not none followed by unwrap.
2 years ago
Jason Ish
85cfa7254b
rust: fix clippy lint for single_char_add_str
...
Idiomatic cleanup and a fix automatically done by `cargo clippy --fix`.
2 years ago