Commit Graph

18127 Commits (9a7a30f18e786324534f5711a62815c70390406d)
 

Author SHA1 Message Date
Jeff Lucovsky 9a7a30f18e detect/dbv: Assert MT lock held
Add a DBV assert to validate that the master->lock is held.

Suppress missing master->lock warning

Issue: 7819
4 weeks ago
Jeff Lucovsky 46a53aee73 engine/mt: Ensure master lock held for reload
Issue: 7819

DetectEngineReload must hold the `master->lock`; recent changes changed
the locking usages to avoid deadlock when registering/handling tenants.
These changes added the presumption that the master lock is held at a
higher level. Coverity highlighted that the lock is not held
consistently.
4 weeks ago
David Wharton 9d2d1c4f8f doc: minor verbiage tweaks and reST fix 4 weeks ago
Philippe Antoine dc7874b2ac rust: bindgen more http range functions used in http2
Ticket: 7667
4 weeks ago
Philippe Antoine 842352c190 rust: bindgen SCHttpRangeFreeBlock
Ticket: 7667
4 weeks ago
Philippe Antoine 93785ae357 rust: bindgen SCHTTP2MimicHttp1Request
Ticket: 7667
4 weeks ago
Philippe Antoine a1613fecb4 detect: tcp.flags rejects non-sensical values
ignored flags are only meaningful for equal mode
4 weeks ago
Philippe Antoine 31e9cb55be detect: tcp.flags unit tests improvements
Tests better the ignored flags functionality.
This functionality is only used at detection for default mode,
it is not used for any, plus or not mode.

So, have unit tests about igored flags with default mode with
both matching and non matching cases
4 weeks ago
Philippe Antoine d8cb00e795 detect/tcp: make tcp.flags a generic integer with bitflags
Ticket: 6724

Allows to use numerical values for example

Also fixes some unit tests that were returning 1 after goto error
FlagsTestParse05 especially took this path as
de->ignored_flags != (TH_SYN|TH_RST) was false
we had de->ignored_flags == 0xff ^ (TH_SYN|TH_RST)
And then, we had a match, instead of what the not-run code
was supposing.
4 weeks ago
Philippe Antoine 1f9236a6d8 detect/ipv4: make fragbits a generic uint16 bitflags keyword
Ticket: 6724

Allows to use numerical values
4 weeks ago
Philippe Antoine 633180c93f detect/integers: generalize support for bitflags modifier
Ticket: 6724

Allows sugar syntax for bitflags keywords.
While the expressivity does not increase, because we could already
use numerial values with all generic integer modes, this modifier
prefix is used with the strings, and follows the syntax
that is already used for fragbits and tcp.flags keyword.
4 weeks ago
Olusegun Fajobi 2db1b93332 ippair-bit: Convert unittests to FAIL/PASS APIs
Ticket: #6323
4 weeks ago
Shivani Bhardwaj b090fc61fd applayer/tls: do not free SAN for decoding error
SSL connp maintains all the state and certificate data that was
parsed/decoded successfully and it must retain that for later usage.
There should be just one place to free this object which is SSLStateFree
for both the directions. By freeing the connp data during parsing error,
there is room for memory errors.
This works so far because the field parsed after this cannot error out so
if there's an error parsing this, it anyway does not exist. However, this
is incorrect and leaves scope for mistakes.

Remove this extra free and treat SAN like all other TLS keywords.

Bug 7996
4 weeks ago
Victor Julien 2f633be1a9 pcap-log: fix bpf-filter not set for multi mode
Bug: #8002.
4 weeks ago
Philippe Antoine f25194480c libhtp: fix newer clippy lints with newer MSRV 4 weeks ago
Jason Ish bc33bd49eb quic/crypto: remove use of GenericArray
Its not needed, and gets rid of the deprecation warnings.
4 weeks ago
Jason Ish bdfdf7ff33 rust: update deps with cargo-update
Suppress deprecation warnings in quick/crypto.rs about GenericArray.
4 weeks ago
Jason Ish 6fdf0d736b rust: update aes-gcm to 0.10.3 4 weeks ago
Jason Ish b9517de86e rust: update aes to 0.8.4 4 weeks ago
Philippe Antoine 4b69a31dc3 detect/integers: count argument for multi-integers
Ticket: 7211

Allows to count the number of elements, without matching on
individual elements
4 weeks ago
Philippe Antoine 047f1c5080 doc: fix enip_command name in json schema
enip.command is not a keyword nor an alias
4 weeks ago
Victor Julien 93c0409292 unittests: move http.cookie tests to FAIL/PASS API 1 month ago
Victor Julien 4af5520496 unittests: move http.stat_code tests to FAIL/PASS API 1 month ago
Victor Julien 8fe931e5ff unittests: convert http_raw_header tests to FAIL/PASS api 1 month ago
Victor Julien eb104389b1 unittests: move http.stat_msg tests to FAIL/PASS API 1 month ago
Victor Julien 5e14e4e58c unittests: move http.server_body tests to FAIL/PASS API 1 month ago
Victor Julien e1d3993659 unittests: clean up memory for host storage tests 1 month ago
Victor Julien 4c126a9d6c unittests: clean up memory for ippair storage tests 1 month ago
Victor Julien b7650a45fa output: fix long logline test
Fixes: 023a2fe9ab ("unittests: fix format-truncation warning")
1 month ago
Victor Julien fcbccb0292 github-actions: check for leaks in unittests 1 month ago
Victor Julien f176d2ae63 unittests: clean up memory for icmpv4 tests 1 month ago
Victor Julien 0616aa9532 unittests: clean up memory for nsh tests 1 month ago
Victor Julien 89dea0dce5 unittests: clean up memory for ethernet tests 1 month ago
Victor Julien 4e85bcbb5f unittests: clean up memory for ipv6 tests 1 month ago
Victor Julien 6b5323cf81 unittests: clean up memory for ipv4 tests 1 month ago
Victor Julien cf23586027 unittests: clean up memory for vlan tests 1 month ago
Victor Julien 4d81f74b89 unittests: clean up memory for esp tests 1 month ago
Victor Julien 9e3627e14d unittests: clean up memory for raw tests
Convert to FAIL/PASS api
1 month ago
Victor Julien 385ae2d348 unittests: clean up memory for chdlc tests 1 month ago
Victor Julien 12f54164c6 unittests: clean up memory for pppoe tests 1 month ago
Victor Julien b1f4e06719 unittests: clean up memory for gre tests 1 month ago
Victor Julien fda72e6f83 unittests: clean up memory for ppp tests 1 month ago
Victor Julien 4ef810105a unittests: clean up memory for dnp3 tests 1 month ago
Victor Julien 13c3d2e09c unittests: clean up memory for defrag tests 1 month ago
Victor Julien 854cd9834f unittests: clean up memory for detect stream_size tests
Convert tests to FAIL/PASS api
1 month ago
Victor Julien 8fe513d433 unittests: clean up memory for detect dce payload tests 1 month ago
Victor Julien 1cadbe62bf unittests: clean up memory for detect sameip tests 1 month ago
Victor Julien 37012bf722 unittests: clean up memory for detect reference tests 1 month ago
Victor Julien efc19868c6 unittests: clean up memory for detect rpc tests 1 month ago
Victor Julien 12546621b9 unittests: clean up memory for detect replace tests 1 month ago