Commit Graph

7914 Commits (971ab18b95fad189f863ef7f201c458e43540139)
 

Author SHA1 Message Date
Victor Julien 47c4a8cd28 prefilter: fix -Wshadow warnings 8 years ago
Victor Julien f2f0f84cca detect: fix -Wshadow warning 8 years ago
Victor Julien 070a6caaf3 app engines: fix -Wshadow warning 8 years ago
Victor Julien 691fae6520 address: fix -Wshadow warning 8 years ago
Victor Julien 34b030b45f distance: fix -Wshadow warning 8 years ago
Victor Julien d50b4b8471 content: fix -Wshadow warning 8 years ago
Victor Julien 02df79f67b mem: fix SCStrdup -Wshadow warning 8 years ago
Victor Julien f97e857c02 dns: fix -Wshadow warnings 8 years ago
Victor Julien 6a971a5a02 app-layer-proto-detect: fix -Wshadow warning 8 years ago
Victor Julien 287fd83796 dnp3: fix coverity CID 1374300 8 years ago
Victor Julien 8915f2de38 flow: suppress coverity CID 400600 8 years ago
Victor Julien edcc8e7ec9 stat: suppress CID 1293508 and 1312013 8 years ago
Victor Julien 7021959689 nfq: suppress CID 1374302 and 1374303 8 years ago
Victor Julien da6bf0c1b6 host-info: coverity 1298890 8 years ago
Victor Julien 9904b3f348 ttl: coverity 400560 + minor cleanups 8 years ago
Victor Julien d30f7f6b48 tos: coverity 400559 8 years ago
Victor Julien ad8f9f9334 ssl-state: coverity 400558 8 years ago
Jason Ish c91974e24a issue 1961: depth: fail if numeric value has trailing text
Catches the case where the depth is not terminated with a
semicolon (eg: "depth:17 classtype:trojan-activity") which
is usually a sign the rule has a missing semi-colon.
8 years ago
Jason Ish a1eca40611 log-pcap.c: cleanup scan-build warning
Don't initialize value to a value that is never used.
8 years ago
Jason Ish 553f7ec290 log-pcap.c: fix resource leak found by coverity
Goto the failure label instead of returning which will allow the open
directory to get cleaned up.

Fixes:

*** CID 1394675:  Resource leaks  (RESOURCE_LEAK)
/src/log-pcap.c: 615 in PcapLogInitRingBuffer()
609                  * failure as the file might just not be a pcap log file. */
610                 continue;
611             }
612
613             PcapFileName *pf = SCCalloc(sizeof(*pf), 1);
614             if (unlikely(pf == NULL)) {
>>>     CID 1394675:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "dir" going out of scope leaks the storage it points to.
615                 return TM_ECODE_FAILED;
616             }
617             char path[PATH_MAX];
618             snprintf(path, PATH_MAX - 1, "%s/%s", pattern, entry->d_name);
619             if ((pf->filename = SCStrdup(path)) == NULL) {
620                 goto fail;

This also means that pf can be NULL which should clear up CID
1394676 (REVERSE_INULL).
8 years ago
Jason Ish 0c6c9784a2 doc: document that that ;, \, " need to be escaped in rules 8 years ago
Victor Julien a67c31d4e1 qa: appveyor support 8 years ago
Victor Julien e6ed0d815c qa: update url in libhtp script 8 years ago
Jason Ish bbb93e487e pcap-log: seed ring buffer on start up
On start, look for existing pcap log files and add them to
the ring buffer. This makes pcap-log self maintaining over
restarts removing the need for external tools to clear
orphaned files.
8 years ago
Eric Leblond a2e2f50fb9 documentation: fix list keywords URLs
Update URLs in keyword definition to point to sphinx documentation.
8 years ago
Jason Ish fffdc6e3fd logging: hook the application log file into rotation 8 years ago
Jason Ish 73a1d04779 logging: open application log file in append mode
It was being open in read/write mode, which was likely
a mistake with append mode being the intention.
8 years ago
Jason Ish 666fecc579 dns: accept a data length of 0 without marking as malformed
Addresses issue:
https://redmine.openinfosecfoundation.org/issues/1924
8 years ago
Jason Ish b9ba792279 dns-events: fix direction of malformed events + typo 8 years ago
Jason Ish d5eca41a71 ipfw: disable more code to suppress compiler warnings
Disabled code lead to unused variable warnings, so disable the
variable code as well.
8 years ago
Jason Ish 2b874abada compiler warnings: fix compiler warnings in format strings 8 years ago
Victor Julien 3f8ee2afd3 detect-lua: unify on using 'lua' name vs 'luajit' 8 years ago
Victor Julien 0366d47608 luajit: remove unused instance counter 8 years ago
Victor Julien 3012edae1c luajit: update default yaml and doc for 'states' 8 years ago
Victor Julien 3da7dad514 lua: luajit improvements
Luajit has a strange memory requirement, it's 'states' need to be in the
first 2G of the process' memory.

This patch improves the pool approach by moving it to the front of the
start up.

A new config option 'luajit.states' is added to control how many states
are preallocated. It defaults to 128.

Add a warning when more states are used then preallocated. This may fail
if flow/stream/detect engines use a lot of memory. Add hint at exit that
gives the max states in use if it's higher than the default.
8 years ago
Jason Ish 0792f80909 doc: only build pdf on dist if pdflatex is installed 8 years ago
Jason Ish ee16b86900 doc: fix build pdf on non gnu make platforms
The Makefile generated by sphinx-build is GNU Make specific
causing the PDF phase to fail. Instead call pdflatex directly
based on how the generated Makefile was doing it.
8 years ago
Victor Julien 064c070db7 pcap-file: minor cleanup 8 years ago
Victor Julien f9f5e8a348 changelog: update for 3.2RC1 release 8 years ago
Victor Julien 3973363164 yaml: group ICS protocols together 8 years ago
Victor Julien b231558957 ENIP: add default ports to yaml 8 years ago
Victor Julien 238163bc8d ENIP: disable parser if no config found 8 years ago
Victor Julien 080a2f0cfb DNP3: disable in case of no dnp3 config 8 years ago
Priit Laes 12849fa927 readme: Fix markdown header levels 8 years ago
Priit Laes 6d9733a72b readme: reformat some key points about possible security issues 8 years ago
Priit Laes d709bf49e8 readme: Add link to up-to-date user guide and mark wiki as deprecated. 8 years ago
Jason Ish 65bf06975c dnp3: fix coverity checks; return value not checked 8 years ago
Victor Julien 1f670837ac detect: add missing break (CID 1374301) 8 years ago
Victor Julien c0f25bddaf eve: make payload printing in alerts more robust 8 years ago
Victor Julien 39a23d8d1b flowint: allow / in name 8 years ago