Philippe Antoine
8adf172ab8
nfs: limits the number of active transactions per flow
...
Ticket: 4530
3 years ago
Philippe Antoine
0e85dea3ff
nfs: remove unused events variable
3 years ago
Philippe Antoine
e4f2f8f78d
nfs: derive AppLayerEvent for NFSEvent
3 years ago
Philippe Antoine
5fe9188a95
fuzz: test for too many open txs in a flow
...
so as to avoid performance problems coming from this.
3 years ago
Victor Julien
e1f7c63fa8
swf: fix coverity warnings
...
*** CID 1499365: (UNINIT)
/src/util-file-swf-decompression.c: 98 in FileSwfZlibDecompression()
92 infstream.avail_in = (uInt)compressed_data_len;
93 infstream.next_in = (Bytef *)compressed_data;
94 infstream.avail_out = (uInt)decompressed_data_len;
95 infstream.next_out = (Bytef *)decompressed_data;
96
97 inflateInit(&infstream);
>>> CID 1499365: (UNINIT)
>>> Using uninitialized value "infstream.total_out" when calling "inflate".
98 int result = inflate(&infstream, Z_NO_FLUSH);
99 switch(result) {
100 case Z_STREAM_END:
101 break;
102 case Z_OK:
103 break;
/src/util-file-swf-decompression.c: 98 in FileSwfZlibDecompression()
92 infstream.avail_in = (uInt)compressed_data_len;
93 infstream.next_in = (Bytef *)compressed_data;
94 infstream.avail_out = (uInt)decompressed_data_len;
95 infstream.next_out = (Bytef *)decompressed_data;
96
97 inflateInit(&infstream);
>>> CID 1499365: (UNINIT)
>>> Using uninitialized value "infstream.total_out" when calling "inflate".
98 int result = inflate(&infstream, Z_NO_FLUSH);
99 switch(result) {
100 case Z_STREAM_END:
101 break;
102 case Z_OK:
103 break;
*** CID 1499363: Error handling issues (CHECKED_RETURN)
/src/util-file-swf-decompression.c: 97 in FileSwfZlibDecompression()
91
92 infstream.avail_in = (uInt)compressed_data_len;
93 infstream.next_in = (Bytef *)compressed_data;
94 infstream.avail_out = (uInt)decompressed_data_len;
95 infstream.next_out = (Bytef *)decompressed_data;
96
>>> CID 1499363: Error handling issues (CHECKED_RETURN)
>>> Calling "inflateInit_(&infstream, "1.2.11", 112)" without checking return value. This library function may fail and return an error code.
97 inflateInit(&infstream);
98 int result = inflate(&infstream, Z_NO_FLUSH);
99 switch(result) {
100 case Z_STREAM_END:
101 break;
102 case Z_OK:
Bug: #5079 .
3 years ago
Victor Julien
4312676aed
dnp3/eve: regenerate object logging code
...
To propagate jb_set_string_from_bytes() generator update.
Bug: #5080 .
3 years ago
Victor Julien
08346cb239
dnp3: update gen script to use jb_set_string_from_bytes
...
Bug: #5080 .
3 years ago
Jason Ish
2ebb525f7e
build: remove configure check for cargo vendor
...
cargo vendor has been part of the core cargo command since Rust 1.37,
and are minimum Rust version is not 1.41, so remove the check. Its
always available now.
3 years ago
Jason Ish
62cc813f88
rust/make: fix maintainer-clean-local target
...
Was using the wrong name, so vendored Rust crates were not being
cleaned up on make maintainer-clean.
3 years ago
Pierre Chifflier
8dc3431d86
rust/dcerpc: convert parser to nom7 functions
3 years ago
Jeff Lucovsky
a3443845fb
log/stack: Propagate original signal
...
Issue: 4550
This commit modifies the "stack trace on signal" to propagate the
original signal received instead of always raising SIGABRT.
3 years ago
Pierre Chifflier
b5166bdb93
rust/ntp: upgrade dependency on ntp-parser
3 years ago
Victor Julien
251b52ab07
github: bump MSRV and minimum known version
3 years ago
Victor Julien
c1be27cb45
github: remove xenial build
3 years ago
Pierre Chifflier
fa63945bdc
rust/ike: convert parser to nom7 functions and upgrade dependency
3 years ago
Pierre Chifflier
3493537ec3
rust/rfb: convert parser to nom7 functions
3 years ago
Victor Julien
377ce6b679
codecov: fix informational; disable github annotations
3 years ago
Victor Julien
84d91e2e0d
app-layer: fix counter setup logic
...
Completes 0ccf5b9147
3 years ago
Victor Julien
27cd54dc0d
frames: address coverity issue
...
Minor cleanups to assist coverity.
Bug: #5065 .
3 years ago
Modupe Falodun
786cf41599
detect-bytetest: remove unittests
...
These tests are reimplemented as Suricata-Verify
Task: 4911
3 years ago
Victor Julien
da7eff61cc
codecov: set to informational
3 years ago
Victor Julien
d1071c151c
ci: formatting errors are now fatal
3 years ago
Victor Julien
474e0e3644
sip: enable for 5061/udp
3 years ago
Victor Julien
1203750388
sip: add frames support
...
Frames:
- sip.pdu
- sip.request_line
- sip.response_line
- sip.request_headers
- sip.response_headers
- sip.request_body
- sip.response_body
The `sip.pdu` frame is always created, the rest only if the record
parser succeeded.
Ticket: #5036 .
3 years ago
Victor Julien
c96d22e8a1
frames: support UDP frames
...
UDP frames point to the UDP packet payloads.
The frames are removed after each packet.
Ticket: #4983 .
3 years ago
Victor Julien
97ef60cd9b
output/file: remove 'waldo' code
...
It was no longer used after "file-store v1" was removed.
3 years ago
Victor Julien
f9c04992c3
file/store: warning grammer fixup
3 years ago
Victor Julien
b06bd1a1fe
htp: rearrange tx user data for more efficiency
3 years ago
Victor Julien
39b1f1aca6
output/lua: minor cleanups
3 years ago
Victor Julien
e5fd0d4f76
output/streaming: use unique thread data name
3 years ago
Victor Julien
b36683e04f
output/stats: use unique thread data name
3 years ago
Victor Julien
008f4aee69
output/packet: use unique thread data name
3 years ago
Victor Julien
dd1dc88c65
output/filedata: use unique thread data name
3 years ago
Victor Julien
c7db9aa50d
output/file: use unique thread data name
3 years ago
Victor Julien
45f13b3d01
output/tx: use unique thread data name
3 years ago
Victor Julien
0be99f3e35
output: minor header cleanups
3 years ago
Victor Julien
645a04c233
output: declare OutputLoggerThreadStore once
3 years ago
Victor Julien
0ccf5b9147
app-layer: fix error counter logic
3 years ago
Victor Julien
b0cad24705
github: enable dependabot for Rust/cargo
3 years ago
Modupe Falodun
cf5c58c075
detect-uricontent: convert unittests to FAIL/PASS APIs
3 years ago
Modupe Falodun
dc8908b282
detect-uricontent: remove unittests
...
These tests are reimplemented as Suricata-verify
Task: 4911
3 years ago
Modupe Falodun
26c9e66586
detect-engine-enip: remove unittests
...
These test is reimplemented in Suricata-Verify
Task: 4911
3 years ago
Victor Julien
609a7eaab2
app-layer: error counters
...
Per app-layer error counters for:
gap, parser, internal (AppLayerResult issues), alloc
3 years ago
Victor Julien
ae0b8d92da
flow/manager: remove dead code
3 years ago
Victor Julien
5618886aa9
stream: remove unused defines
3 years ago
Victor Julien
811b2cd334
doc: refresh main README; more accurate CI description
3 years ago
Modupe Falodun
d2dad66a2b
detect-dce-opnum: remove unittests
...
These tests are reimplemented in Suricata-Verify
Task: 4911
3 years ago
Jason Ish
b9a429e6ce
devguide: move image generation into sphinx setup
...
While ReadTheDocs can't execute arbitrary scripts, we can install
mscgen in the container that builds the docs (see .readthedocs.yaml).
Then instead of calling generate-images.sh from the Makefile, move this
into the setup function defined on conf.yaml, which will generate the
scripts as part of a normal Sphinx workflow.
This should give us an image generation solution that works on
ReadTheDocs, and locally within anyones build system provided they have
mscgen installed.
3 years ago
Philippe Antoine
4247605d87
smtp: check if we have a current transaction
...
Ticket: 4948
This is not the perfect solution, but it prevents to trigger
the assert, and keep the assert.
A better solution would need to create transaction from
the reponse parsing, in case a later command was buffered and
not answered. But this would not be enough as NoNewTx prevents
the creation of a new transaction for RSET...
3 years ago
Philippe Antoine
11d3af551b
doc: suricata.yaml fields about maximum transactions
...
For HTTP2, MQTT and FTP.
3 years ago