Victor Julien
6381b1a643
detect/iponly: cleanups
3 years ago
Victor Julien
de4354abcb
detect/iponly: minor debug 'Print' improvements
3 years ago
Victor Julien
3ca3c9dfbe
radix: minor debug 'Print' improvements
3 years ago
Victor Julien
e04d378e58
util/cidr: simplify IPv4 CIDR handling; add IPv6
...
Instead of building a table at init just calculate it on demand.
Callsites are all during init, so its not performance critical.
Add similar function for IPv6.
3 years ago
Victor Julien
e04fcfcf2f
doc/userguide: minor rewording and reformatting for runmodes
3 years ago
Juliana Fajardini
28b5f4a555
devguide: add page about app-layer frame support
...
This explains the frame support from the perspective of a developer,
with introductory explanation on how to add frame support to an
applayer proto.
Doc #4697
3 years ago
Juliana Fajardini
e0b9f0e175
http: add comment tags to support documentation
...
With these, the portion of code within the tags should be included
in the related code-snippets (for frame support documentation) w/o
errors, even if the code within changes. The tags can also work as
a reminder that the existing code is being shown elsewhere, so folks
know documentation might need updates, in case of major changes.
3 years ago
Juliana Fajardini
5a7645fac1
rust: add comment tags to support documentation
...
With these, the portion of code within the tags should be included
in the related code-snippets (for frame support documentation) w/o
errors, even if the code within changes. The tags can also work as
a reminder that the existing code is being shown elsewhere, so folks
know documentation might need updates, in case of major changes.
3 years ago
Juliana Fajardini
e0dd1820c2
sip: apply rustfmt to a few functions
...
Our current rust code isn't always documentation friendly when it
comes to using code snippets. Used rustfmt to apply rust default
formatting on functions that we wanted to show in our documentation
for Frame support
3 years ago
Juliana Fajardini
71cbd2bf0e
telnet: apply rustfmt to parse_request
...
When we want to share our code in our documentation pages, the current
rust formatting isn't so nice to read. Formatted just the portion of
the code that will be shown, for now.
3 years ago
Philippe Antoine
8adf172ab8
nfs: limits the number of active transactions per flow
...
Ticket: 4530
3 years ago
Philippe Antoine
0e85dea3ff
nfs: remove unused events variable
3 years ago
Philippe Antoine
e4f2f8f78d
nfs: derive AppLayerEvent for NFSEvent
3 years ago
Philippe Antoine
5fe9188a95
fuzz: test for too many open txs in a flow
...
so as to avoid performance problems coming from this.
3 years ago
Victor Julien
e1f7c63fa8
swf: fix coverity warnings
...
*** CID 1499365: (UNINIT)
/src/util-file-swf-decompression.c: 98 in FileSwfZlibDecompression()
92 infstream.avail_in = (uInt)compressed_data_len;
93 infstream.next_in = (Bytef *)compressed_data;
94 infstream.avail_out = (uInt)decompressed_data_len;
95 infstream.next_out = (Bytef *)decompressed_data;
96
97 inflateInit(&infstream);
>>> CID 1499365: (UNINIT)
>>> Using uninitialized value "infstream.total_out" when calling "inflate".
98 int result = inflate(&infstream, Z_NO_FLUSH);
99 switch(result) {
100 case Z_STREAM_END:
101 break;
102 case Z_OK:
103 break;
/src/util-file-swf-decompression.c: 98 in FileSwfZlibDecompression()
92 infstream.avail_in = (uInt)compressed_data_len;
93 infstream.next_in = (Bytef *)compressed_data;
94 infstream.avail_out = (uInt)decompressed_data_len;
95 infstream.next_out = (Bytef *)decompressed_data;
96
97 inflateInit(&infstream);
>>> CID 1499365: (UNINIT)
>>> Using uninitialized value "infstream.total_out" when calling "inflate".
98 int result = inflate(&infstream, Z_NO_FLUSH);
99 switch(result) {
100 case Z_STREAM_END:
101 break;
102 case Z_OK:
103 break;
*** CID 1499363: Error handling issues (CHECKED_RETURN)
/src/util-file-swf-decompression.c: 97 in FileSwfZlibDecompression()
91
92 infstream.avail_in = (uInt)compressed_data_len;
93 infstream.next_in = (Bytef *)compressed_data;
94 infstream.avail_out = (uInt)decompressed_data_len;
95 infstream.next_out = (Bytef *)decompressed_data;
96
>>> CID 1499363: Error handling issues (CHECKED_RETURN)
>>> Calling "inflateInit_(&infstream, "1.2.11", 112)" without checking return value. This library function may fail and return an error code.
97 inflateInit(&infstream);
98 int result = inflate(&infstream, Z_NO_FLUSH);
99 switch(result) {
100 case Z_STREAM_END:
101 break;
102 case Z_OK:
Bug: #5079 .
3 years ago
Victor Julien
4312676aed
dnp3/eve: regenerate object logging code
...
To propagate jb_set_string_from_bytes() generator update.
Bug: #5080 .
3 years ago
Victor Julien
08346cb239
dnp3: update gen script to use jb_set_string_from_bytes
...
Bug: #5080 .
3 years ago
Jason Ish
2ebb525f7e
build: remove configure check for cargo vendor
...
cargo vendor has been part of the core cargo command since Rust 1.37,
and are minimum Rust version is not 1.41, so remove the check. Its
always available now.
3 years ago
Jason Ish
62cc813f88
rust/make: fix maintainer-clean-local target
...
Was using the wrong name, so vendored Rust crates were not being
cleaned up on make maintainer-clean.
3 years ago
Pierre Chifflier
8dc3431d86
rust/dcerpc: convert parser to nom7 functions
3 years ago
Jeff Lucovsky
a3443845fb
log/stack: Propagate original signal
...
Issue: 4550
This commit modifies the "stack trace on signal" to propagate the
original signal received instead of always raising SIGABRT.
3 years ago
Pierre Chifflier
b5166bdb93
rust/ntp: upgrade dependency on ntp-parser
3 years ago
Victor Julien
251b52ab07
github: bump MSRV and minimum known version
3 years ago
Victor Julien
c1be27cb45
github: remove xenial build
3 years ago
Pierre Chifflier
fa63945bdc
rust/ike: convert parser to nom7 functions and upgrade dependency
3 years ago
Pierre Chifflier
3493537ec3
rust/rfb: convert parser to nom7 functions
3 years ago
Victor Julien
377ce6b679
codecov: fix informational; disable github annotations
3 years ago
Victor Julien
84d91e2e0d
app-layer: fix counter setup logic
...
Completes 0ccf5b9147
3 years ago
Victor Julien
27cd54dc0d
frames: address coverity issue
...
Minor cleanups to assist coverity.
Bug: #5065 .
3 years ago
Modupe Falodun
786cf41599
detect-bytetest: remove unittests
...
These tests are reimplemented as Suricata-Verify
Task: 4911
3 years ago
Victor Julien
da7eff61cc
codecov: set to informational
3 years ago
Victor Julien
d1071c151c
ci: formatting errors are now fatal
3 years ago
Victor Julien
474e0e3644
sip: enable for 5061/udp
3 years ago
Victor Julien
1203750388
sip: add frames support
...
Frames:
- sip.pdu
- sip.request_line
- sip.response_line
- sip.request_headers
- sip.response_headers
- sip.request_body
- sip.response_body
The `sip.pdu` frame is always created, the rest only if the record
parser succeeded.
Ticket: #5036 .
3 years ago
Victor Julien
c96d22e8a1
frames: support UDP frames
...
UDP frames point to the UDP packet payloads.
The frames are removed after each packet.
Ticket: #4983 .
3 years ago
Victor Julien
97ef60cd9b
output/file: remove 'waldo' code
...
It was no longer used after "file-store v1" was removed.
3 years ago
Victor Julien
f9c04992c3
file/store: warning grammer fixup
3 years ago
Victor Julien
b06bd1a1fe
htp: rearrange tx user data for more efficiency
3 years ago
Victor Julien
39b1f1aca6
output/lua: minor cleanups
3 years ago
Victor Julien
e5fd0d4f76
output/streaming: use unique thread data name
3 years ago
Victor Julien
b36683e04f
output/stats: use unique thread data name
3 years ago
Victor Julien
008f4aee69
output/packet: use unique thread data name
3 years ago
Victor Julien
dd1dc88c65
output/filedata: use unique thread data name
3 years ago
Victor Julien
c7db9aa50d
output/file: use unique thread data name
3 years ago
Victor Julien
45f13b3d01
output/tx: use unique thread data name
3 years ago
Victor Julien
0be99f3e35
output: minor header cleanups
3 years ago
Victor Julien
645a04c233
output: declare OutputLoggerThreadStore once
3 years ago
Victor Julien
0ccf5b9147
app-layer: fix error counter logic
3 years ago
Victor Julien
b0cad24705
github: enable dependabot for Rust/cargo
3 years ago
Modupe Falodun
cf5c58c075
detect-uricontent: convert unittests to FAIL/PASS APIs
3 years ago