Commit Graph

13451 Commits (1b24f4d357fd922a5c3202fce2904da29a04ed12)
 

Author SHA1 Message Date
Philippe Antoine 1621f5e453 detect/nfs: use inclusive ranges 2 years ago
Philippe Antoine 8dbb07e4fe detect: use generic integer functions for itype
Ticket: #4112
2 years ago
Philippe Antoine 2817f1a6ed detect: use generic integer functions for snmp.version
Ticket: #4112
2 years ago
Philippe Antoine c72571ea28 detect: use generic integer functions for rfb.sectype
Ticket: #4112
2 years ago
Philippe Antoine 6c9091c86f detect: use generic integer functions for nfs.version
Ticket: #4112
2 years ago
Philippe Antoine ddac6165c9 detect: use generic integer functions for nfs.procedure
Ticket: #4112
2 years ago
Philippe Antoine ed6955ee98 detect: use generic integer functions for iprep
Ticket: #4112
2 years ago
Philippe Antoine bdc359bed3 detect: use generic integer functions for bsize
Ticket: #4112
2 years ago
Philippe Antoine cfb60d0fce detect: use generic integer functions for urilen
Ticket: #4112
2 years ago
Philippe Antoine e87c53bb55 defrag: use util function for timeout
To fix timestamp overflow as found by oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=44608

fixu
2 years ago
jason taylor d600a1603c detect: update text for nocase used with http.host
Signed-off-by: jason taylor <jtfas90@gmail.com>
2 years ago
jason taylor 34e0a384ad doc: update to include additional rule references
Signed-off-by: jason taylor <jtfas90@gmail.com>
2 years ago
jason taylor 4405704372 doc: update intro direction content
Signed-off-by: jason taylor <jtfas90@gmail.com>
2 years ago
jason taylor 3eeacf8a3d doc: fixed HOME_NET/EXTERNAL example formatting
Signed-off-by: jason taylor <jtfas90@gmail.com>
2 years ago
jason taylor f2c7998903 doc: add clarity around HOME_NET/EXTERNAL_NET
Signed-off-by: jason taylor <jtfas90@gmail.com>
2 years ago
jason taylor 76cca8b08a doc: minor example rule description update
Signed-off-by: jason taylor <jtfas90@gmail.com>
2 years ago
jason taylor 4f61a35fe7 doc: minor wording restructure
Signed-off-by: jason taylor <jtfas90@gmail.com>
2 years ago
jason taylor 845ba154a6 doc: add tcp-pkt/tcp-stream to intro
Signed-off-by: jason taylor <jtfas90@gmail.com>
2 years ago
jason taylor 56f49bfe8e doc: minor punctuation update
Signed-off-by: jason taylor <jtfas90@gmail.com>
2 years ago
jason taylor ab300ab0ae doc: intro example rule update to simpler example
Signed-off-by: jason taylor <jtfas90@gmail.com>
2 years ago
jason taylor 2f240230f0 doc: minor intro wording update
Signed-off-by: jason taylor <jtfas90@gmail.com>
2 years ago
Philippe Antoine c57052181c snmp: rustfmt detect.rs 2 years ago
Philippe Antoine c7214be99b snmp: adds usm keyword
as is logged

Ticker: #5416
2 years ago
Victor Julien 4adab8f271 github/codeowners: update 2 years ago
Philippe Antoine 5a31b3508d ftp: optimized tx iterator
To be more efficient with larger number of transactions.

Ticket: #5314
2 years ago
Victor Julien 6d3140bc01 mime: remove unused length fields 2 years ago
Victor Julien 816bbeb7dc fuzz/mime: fix call conditions and args
The SMTP parser should not supply lines w/o EOL chars to the mime
parser unless its in the BODY parsing stage. Mimic this in the fuzz
target by testing the state for inputs that have no EOL.

Additionally, make sure the delim cnt reflects the missing EOL.
2 years ago
Victor Julien d81582c4a2 mime: fix corner case
Fix a corner case where a base64 sequence including a space was followed
by a newline in the input data.
2 years ago
Victor Julien 5805ed47f5 mime: add base64 related debug messages 2 years ago
Victor Julien 41c2c1ed5a mime: improved empty line handling
Make sure a new body is not set up on empty lines unless it is
a body that is not encoded as base64/quoted printable.
2 years ago
Victor Julien 074cfb5c68 mime: fix and cleanup tests
Line count check was failing after recent delim handling updates.
2 years ago
Victor Julien 6e2c066ce1 smtp: fix passing a wrong delim len around 2 years ago
Victor Julien b82b8825e7 mime: properly pass full lines to non-decoded body
Use actual delim count and make sure we also pass on empty lines
(so delim(s) only).
2 years ago
Victor Julien 0d6ab727c5 mime/base64: fix final data not getting processed
If the last data of the body was not a multple of 4 and not padded
to be a multiple of 4, it would not be processed.
2 years ago
Victor Julien 100d821a9f stream: fix GAP check
Gap check would consider a GAP when the current data was in fact
exactly not a gap, but next segment(s) were already available.
2 years ago
Victor Julien 29ec1b1e7b mime: minor code cleanup 2 years ago
Victor Julien 0871029d17 mime: remove unused 'linerem' logic 2 years ago
Victor Julien 5953a7d2eb smtp/mime: fix parsing edge case
Correctly track "remaining" bytes after partial base64 decoding.

Add comment clarifications and debug validation checks.
2 years ago
Victor Julien a38f2f2a52 smtp: skip preprocessing for mime headers
Mime parser doesn't expect partial lines, which preprocessing can
provide. Add a check to let mime headers be handled by regular line
parsing.
2 years ago
Victor Julien 929faae6d4 eve/schema: add drop.udplen, email fields 2 years ago
Juliana Fajardini 2544be4672 source/pcap: fix infinite loop if interface goes down
When in live-pcap mode, if the sniffed interface went down and up again,
Suri would enter an infinite and keep running, while not registering new
events. This fixes that behavior by allowing Suri to retry to open the
pcap in case of a retry on an already activated capture
('PCAP_ERROR_ACTIVATED').

This change is based on Zhiyuan Liao's work.

Bug #3846
2 years ago
dependabot[bot] dc6fff2cca github-actions: bump ossf/scorecard-action from 1.1.1 to 1.1.2
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](3e15ea8318...ce330fde6b)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
Philippe Antoine 585e5e0d3c detect: impose limits on pcrexform
As is done for pcre keyword

Ticket: #5409
2 years ago
Juliana Fajardini 45b7aad2b5 devguide: incorporate contribution process page
That page existed only in our redmine. Updated and added a few things,
like a paragraph about our expectations for feature contributors.

Also updated links, contacts and some other processes that may have
changed since last edition.

Added some section labels in related documents, for ease of referencing.

Task #4929
2 years ago
Victor Julien a89840929b detect: set drop reason for rule based drops
Call `PacketDrop` with drop reason for drops, keep old logic
in place for the rest.
2 years ago
Victor Julien ad14e71efe stream: suppress exception policy debug message 2 years ago
Victor Julien 046287c2b5 detect/filestore: clean up stream flag handling 2 years ago
Victor Julien 7ced8de6c4 github/workflows: add cargo for all Ubuntu jobs 2 years ago
Victor Julien 3617be326c eve/schema: add pcap_filename field 2 years ago
Victor Julien 71ef62bfc5 file: consistently track size of gaps
Until now only the size of gaps counted in the regular append, not
close and open.

Bug: #5392.
2 years ago