From f41646a012400d8afe049ceee6139f224422fb76 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Wed, 25 Jan 2023 11:58:11 +0100 Subject: [PATCH] streaming: remove dead code As reported by Coverity Scan. --- src/util-streaming-buffer.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/util-streaming-buffer.c b/src/util-streaming-buffer.c index c1cc515028..b704a62ef9 100644 --- a/src/util-streaming-buffer.c +++ b/src/util-streaming-buffer.c @@ -1063,10 +1063,7 @@ static StreamingBufferRegion *FindLargestRegionForOffset(const StreamingBuffer * if (!RegionsIntersect(sb, cfg, r, offset, data_re)) return candidate; - if (candidate == NULL) { - candidate = r; - SCLogDebug("candidate %p", candidate); - } else if (r->buf_size > candidate->buf_size) { + if (r->buf_size > candidate->buf_size) { SCLogDebug("candidate %p as size %u > %u", candidate, r->buf_size, candidate->buf_size); candidate = r; }