Minor cleanups

Remove useless checks: coverity 1038130, 1038131, 1038132
Small other fixes: coverity 1164817
pull/851/head
Victor Julien 11 years ago
parent 2b734b8d8a
commit e82c6efaca

@ -796,10 +796,7 @@ static void DCERPCUDPStateFree(void *s) {
sstate->dcerpc.dcerpcresponse.stub_data_buffer = NULL;
sstate->dcerpc.dcerpcresponse.stub_data_buffer_len = 0;
}
if (s) {
SCFree(s);
s = NULL;
}
SCFree(s);
}
static int DCERPCUDPRegisterPatternsForProtocolDetection(void)

@ -1976,10 +1976,7 @@ static void DCERPCStateFree(void *s) {
sstate->dcerpc.dcerpcresponse.stub_data_buffer_len = 0;
}
if (s) {
SCFree(s);
s = NULL;
}
SCFree(s);
}
static int DCERPCRegisterPatternsForProtocolDetection(void)

@ -76,7 +76,7 @@ void DNSDecrMemcap(uint32_t size, DNSState *state) {
}
BUG_ON(size > SC_ATOMIC_GET(dns_memuse)); /**< TODO remove later */
SC_ATOMIC_SUB(dns_memuse, size);
(void)SC_ATOMIC_SUB(dns_memuse, size);
}
int DNSCheckMemcap(uint32_t want, DNSState *state) {

@ -1455,11 +1455,7 @@ static void SMBStateFree(void *s) {
sstate->dcerpc.dcerpcresponse.stub_data_buffer_len = 0;
}
if (s) {
SCFree(s);
s = NULL;
}
SCFree(s);
SCReturn;
}

Loading…
Cancel
Save