mirror of https://github.com/OISF/suricata
Fix DetectReplaceAddToList
I see two problems: 1) If allocating a newlist fails, the function returns NULL, which then leaks any existing list elements. 2) The code to add the new value to the list works for the first two, but for not the third. For example, replist=A, A->next=B, B->next=NULL, then adding C results in replist=A, A->next=C, C->next=NULL, B is lost. The fix pushes new values onto the head of the list, which might not be what is needed, but there are no comments on what the function does, so I made an assumption.pull/1470/head
parent
d44eab82c1
commit
cf9da2be15
Loading…
Reference in New Issue