From b73634497535ceb66954829a01a67ec4b9365269 Mon Sep 17 00:00:00 2001 From: Eric Leblond Date: Sun, 17 Mar 2019 20:00:04 +0100 Subject: [PATCH] flow-bypass: clock_gettime error handling Only reason clock_gettime could fail is a permission so let's error and leave the flow bypass manager if it is the case. Also let's suppress the error message if ever the error appear in the middle of a run (which is unlikely). --- src/flow-bypass.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/flow-bypass.c b/src/flow-bypass.c index 23bc8b99a7..7bd9100940 100644 --- a/src/flow-bypass.c +++ b/src/flow-bypass.c @@ -64,8 +64,9 @@ static TmEcode BypassedFlowManager(ThreadVars *th_v, void *thread_data) struct timespec curtime = {0, 0}; if (clock_gettime(CLOCK_REALTIME, &curtime) != 0) { - SCLogWarning(SC_ERR_INVALID_VALUE, "Can't get time: %s (%d)", + SCLogError(SC_ERR_INVALID_VALUE, "Can't get time: %s (%d)", strerror(errno), errno); + return TM_ECODE_FAILED; } for (i = 0; i < g_bypassed_func_max_index; i++) { if (BypassedFuncList[i].FuncInit) { @@ -76,8 +77,6 @@ static TmEcode BypassedFlowManager(ThreadVars *th_v, void *thread_data) while (1) { SCLogDebug("Dumping the table"); if (clock_gettime(CLOCK_REALTIME, &curtime) != 0) { - SCLogWarning(SC_ERR_INVALID_VALUE, "Can't get time: %s (%d)", - strerror(errno), errno); usleep(10000); continue; }