mpm: fix minor scan-build warning

6 years ago · b5669c1775
parent b09fa8f088
commit b5669c1775
1 changed files with 3 additions and 2 deletions
--- a/src/util-mpm.c
+++ b/src/util-mpm.c
@ -600,7 +600,7 @@ static inline int MpmInitHashAdd(MpmCtx *ctx, MpmPattern *p)
    uint32_t hash = MpmInitHash(p);

    if (ctx->init_hash == NULL) {
-        return 0;
+        return -1;
    }

    if (ctx->init_hash[hash] == NULL) {
@ -699,7 +699,8 @@ int MpmAddPattern(MpmCtx *mpm_ctx, uint8_t *pat, uint16_t patlen,
        }

        /* put in the pattern hash */
-        MpmInitHashAdd(mpm_ctx, p);
+        if (MpmInitHashAdd(mpm_ctx, p) != 0)
+            goto error;

        mpm_ctx->pattern_cnt++;