mirror of https://github.com/OISF/suricata
applayer/tls: do not free SAN for decoding error
SSL connp maintains all the state and certificate data that was parsed/decoded successfully and it must retain that for later usage. There should be just one place to free this object which is SSLStateFree for both the directions. By freeing the connp data during parsing error, there is room for memory errors. This works so far because the field parsed after this cannot error out so if there's an error parsing this, it anyway does not exist. However, this is incorrect and leaves scope for mistakes. Remove this extra free and treat SAN like all other TLS keywords. Bug 7996pull/14067/head
parent
2f633be1a9
commit
b090fc61fd
Loading…
Reference in New Issue