From 875b6039d124d7a98eb4f8801686dbdfa99cd871 Mon Sep 17 00:00:00 2001 From: Gerardo Iglesias Galvan Date: Wed, 1 Jun 2011 12:06:19 -0500 Subject: [PATCH] Remove dead code from flowbits parsing --- src/detect-flowbits.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/detect-flowbits.c b/src/detect-flowbits.c index 81d89aa3cf..673ee7ba94 100644 --- a/src/detect-flowbits.c +++ b/src/detect-flowbits.c @@ -217,6 +217,7 @@ int DetectFlowbitSetup (DetectEngineCtx *de_ctx, Signature *s, char *rawstr) case DETECT_FLOWBITS_CMD_SET: case DETECT_FLOWBITS_CMD_UNSET: case DETECT_FLOWBITS_CMD_TOGGLE: + default: if(fb_name == NULL) goto error; break; @@ -226,11 +227,7 @@ int DetectFlowbitSetup (DetectEngineCtx *de_ctx, Signature *s, char *rawstr) if (cd == NULL) goto error; - if (fb_name != NULL) { - cd->idx = VariableNameGetIdx(fb_name,DETECT_FLOWBITS); - } else { - cd->idx = 0; - } + cd->idx = VariableNameGetIdx(fb_name,DETECT_FLOWBITS); cd->cmd = fb_cmd; SCLogDebug("idx %" PRIu32 ", cmd %s, name %s",