detect/pcre: assist code analyzer around pointer logic

cppcheck:

src/detect-pcre.c:381:27: warning: Either the condition 'pcap' is redundant or there is overflow in pointer subtraction. [nullPointerArithmeticRedundantCheck]
            cut_capture = MIN((pcap - regexstr), (fcap - regexstr));
                          ^
src/detect-pcre.c:378:18: note: Assuming that condition 'pcap' is not redundant
        else if (pcap && !fcap)
                 ^
src/detect-pcre.c:381:27: note: Null pointer subtraction
            cut_capture = MIN((pcap - regexstr), (fcap - regexstr));
                          ^

Bug: #5291.
pull/7321/head
Victor Julien 4 years ago
parent 3bc50df9c3
commit 69b8b48b94

@ -377,8 +377,11 @@ static DetectPcreData *DetectPcreParse (DetectEngineCtx *de_ctx,
cut_capture = fcap - regexstr;
else if (pcap && !fcap)
cut_capture = pcap - regexstr;
else
else {
BUG_ON(pcap == NULL); // added to assist cppcheck
BUG_ON(fcap == NULL);
cut_capture = MIN((pcap - regexstr), (fcap - regexstr));
}
SCLogDebug("cut_capture %d", cut_capture);

Loading…
Cancel
Save