lua: remove luajit pushlstring workaround

81ee6f5aad ("lua: push correct length back through ScFlowvarGet, work around valgrind warning")
added a workaround for valgrind warnings in pushing a string buffer
into the lua state. This is no longer needed as tested with both
address sanitizer and valgrind.
pull/14238/head
Victor Julien 5 days ago
parent 1106323ae1
commit 52fd61dffd

@ -318,22 +318,7 @@ void LuaPrintStack(lua_State *state) {
int LuaPushStringBuffer(lua_State *luastate, const uint8_t *input, size_t input_len)
{
if (input_len % 4 != 0) {
/* we're using a buffer sized at a multiple of 4 as lua_pushlstring generates
* invalid read errors in valgrind otherwise. Adding in a nul to be sure.
*
* Buffer size = len + 1 (for nul) + whatever makes it a multiple of 4 */
size_t buflen = input_len + 1 + ((input_len + 1) % 4);
uint8_t buf[buflen];
memset(buf, 0x00, buflen);
memcpy(buf, input, input_len);
buf[input_len] = '\0';
/* return value through luastate, as a luastring */
lua_pushlstring(luastate, (char *)buf, input_len);
} else {
lua_pushlstring(luastate, (char *)input, input_len);
}
lua_pushlstring(luastate, (char *)input, input_len);
return 1;
}

Loading…
Cancel
Save