file: make fileext, filename and filemagic use the same rule parsing function as others. This has as a side effect that we enforce doubly qouted values now.

src/detect-fileext.c

@@ -146,7 +146,7 @@ static DetectFileextData *DetectFileextParse (char *str)
 
     memset(fileext, 0x00, sizeof(DetectFileextData));
 
-    if (DetectParseContentString (str, &fileext->ext, &fileext->len, &fileext->flags) == -1) {
+    if (DetectContentDataParse("fileext", str, (char **)&fileext->ext, &fileext->len, (int *)&fileext->flags) == -1) {
         goto error;
     }
 
@@ -246,7 +246,7 @@ static void DetectFileextFree(void *ptr) {
  * \test DetectFileextTestParse01
  */
 int DetectFileextTestParse01 (void) {
-    DetectFileextData *dfd = DetectFileextParse("doc");
+    DetectFileextData *dfd = DetectFileextParse("\"doc\"");
     if (dfd != NULL) {
         DetectFileextFree(dfd);
         return 1;

src/detect-filemagic.c

@@ -265,7 +265,7 @@ static DetectFilemagicData *DetectFilemagicParse (char *str)
 
     memset(filemagic, 0x00, sizeof(DetectFilemagicData));
 
-    if (DetectParseContentString (str, &filemagic->name, &filemagic->len, &filemagic->flags) == -1) {
+    if (DetectContentDataParse ("filemagic", str, (char **)&filemagic->name, &filemagic->len, (int *)&filemagic->flags) == -1) {
         goto error;
     }
 
@@ -433,7 +433,7 @@ static void DetectFilemagicFree(void *ptr) {
  * \test DetectFilemagicTestParse01
  */
 int DetectFilemagicTestParse01 (void) {
-    DetectFilemagicData *dnd = DetectFilemagicParse("secret.pdf");
+    DetectFilemagicData *dnd = DetectFilemagicParse("\"secret.pdf\"");
     if (dnd != NULL) {
         DetectFilemagicFree(dnd);
         return 1;
@@ -465,7 +465,7 @@ int DetectFilemagicTestParse02 (void) {
 int DetectFilemagicTestParse03 (void) {
     int result = 0;
 
-    DetectFilemagicData *dnd = DetectFilemagicParse("cmd.exe");
+    DetectFilemagicData *dnd = DetectFilemagicParse("\"cmd.exe\"");
     if (dnd != NULL) {
         if (dnd->len == 7 && memcmp(dnd->name, "cmd.exe", 7) == 0) {
             result = 1;

src/detect-filename.c

@@ -151,7 +151,7 @@ static DetectFilenameData *DetectFilenameParse (char *str)
 
     memset(filename, 0x00, sizeof(DetectFilenameData));
 
-    if (DetectParseContentString (str, &filename->name, &filename->len, &filename->flags) == -1) {
+    if (DetectContentDataParse ("filename", str, (char **)&filename->name, &filename->len, (int *)&filename->flags) == -1) {
         goto error;
     }
 
@@ -259,7 +259,7 @@ static void DetectFilenameFree(void *ptr) {
  * \test DetectFilenameTestParse01
  */
 int DetectFilenameTestParse01 (void) {
-    DetectFilenameData *dnd = DetectFilenameParse("secret.pdf");
+    DetectFilenameData *dnd = DetectFilenameParse("\"secret.pdf\"");
     if (dnd != NULL) {
         DetectFilenameFree(dnd);
         return 1;
@@ -291,7 +291,7 @@ int DetectFilenameTestParse02 (void) {
 int DetectFilenameTestParse03 (void) {
     int result = 0;
 
-    DetectFilenameData *dnd = DetectFilenameParse("cmd.exe");
+    DetectFilenameData *dnd = DetectFilenameParse("\"cmd.exe\"");
     if (dnd != NULL) {
         if (dnd->len == 7 && memcmp(dnd->name, "cmd.exe", 7) == 0) {
             result = 1;