From 4c6595f4379eafe81f1232c4cf4306cdc1d3a793 Mon Sep 17 00:00:00 2001 From: Eric Leblond Date: Wed, 26 Jun 2013 09:56:11 +0200 Subject: [PATCH] Coverity 1038106: fix FP out-of-bond access A cast during the reading of a configuration variable was invalid because a 16 bit integer was cast to a 32 bit integer. The called function is only setting the pointer value to 1 or 0 so there is no real issue there. --- src/runmode-af-packet.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/runmode-af-packet.c b/src/runmode-af-packet.c index bfaf832c1c..1c9d2ad3da 100644 --- a/src/runmode-af-packet.c +++ b/src/runmode-af-packet.c @@ -252,10 +252,11 @@ void *ParseAFPConfig(const char *iface) /* In hash mode, we also ask for defragmentation needed to * compute the hash */ uint16_t defrag = 0; + int conf_val = 0; SCLogInfo("Using flow cluster mode for AF_PACKET (iface %s)", aconf->iface); - ConfGetChildValueBoolWithDefault(if_root, if_default, "defrag", (int *)&defrag); - if (defrag) { + ConfGetChildValueBoolWithDefault(if_root, if_default, "defrag", &conf_val); + if (conf_val) { SCLogInfo("Using defrag kernel functionality for AF_PACKET (iface %s)", aconf->iface); defrag = PACKET_FANOUT_FLAG_DEFRAG;