Improve depth and offset setup error reporting

src/detect-depth.c

@@ -38,13 +38,13 @@ int DetectDepthSetup (DetectEngineCtx *de_ctx, Signature *s, SigMatch *m, char *
      * SigMatch (it can be the same as this one) */
     SigMatch *pm = DetectContentFindPrevApplicableSM(m);
     if (pm == NULL) {
-        printf("DetectDepthSetup: Unknown previous keyword!\n");
+        SCLogError(SC_ERR_DEPTH_MISSING_CONTENT, "depth needs a preceeding content option");
         return -1;
     }
 
     DetectContentData *cd = (DetectContentData *)pm->ctx;
     if (cd == NULL) {
-        printf("DetectDepthSetup: Unknown previous keyword!\n");
+        SCLogError(SC_INVALID_ARGUMENT, "invalid argument");
         return -1;
     }
 

src/detect-offset.c

@@ -41,13 +41,13 @@ int DetectOffsetSetup (DetectEngineCtx *de_ctx, Signature *s, SigMatch *m, char
      * SigMatch (it can be the same as this one) */
     SigMatch *pm = DetectContentFindPrevApplicableSM(m);
     if (pm == NULL) {
-        printf("DetectOffsetSetup: Unknown previous keyword!\n");
+        SCLogError(SC_ERR_OFFSET_MISSING_CONTENT, "offset needs a preceeding content option");
         return -1;
     }
 
     DetectContentData *cd = (DetectContentData *)pm->ctx;
     if (cd == NULL) {
-        printf("DetectOffsetSetup: Unknown previous keyword!\n");
+        SCLogError(SC_INVALID_ARGUMENT, "invalid argument");
         return -1;
     }
 

src/util-error.c

@@ -68,6 +68,8 @@ const char * SCErrorToString(SCError err)
         CASE_CODE (SC_ERR_FLAGS_MODIFIER);
         CASE_CODE (SC_ERR_DISTANCE_MISSING_CONTENT);
         CASE_CODE (SC_ERR_WITHIN_MISSING_CONTENT);
+        CASE_CODE (SC_ERR_DEPTH_MISSING_CONTENT);
+        CASE_CODE (SC_ERR_OFFSET_MISSING_CONTENT);
         CASE_CODE (SC_ERR_NO_URICONTENT_NEGATION);
         default:
             return "UNKNOWN_ERROR";

src/util-error.h

@@ -79,6 +79,8 @@ typedef enum {
     SC_ERR_FLAGS_MODIFIER,
     SC_ERR_DISTANCE_MISSING_CONTENT,
     SC_ERR_WITHIN_MISSING_CONTENT,
+    SC_ERR_OFFSET_MISSING_CONTENT,
+    SC_ERR_DEPTH_MISSING_CONTENT,
     SC_ERR_NO_URICONTENT_NEGATION,
 } SCError;