diff --git a/src/detect-ssl-state.c b/src/detect-ssl-state.c index 5fd5b225c4..2af5db1a4b 100644 --- a/src/detect-ssl-state.c +++ b/src/detect-ssl-state.c @@ -66,11 +66,9 @@ static void DetectSslStateRegisterTests(void); #endif static void DetectSslStateFree(DetectEngineCtx *, void *); -static int InspectTlsGeneric(ThreadVars *tv, - DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, - const Signature *s, const SigMatchData *smd, - Flow *f, uint8_t flags, void *alstate, - void *txv, uint64_t tx_id); +static int InspectTlsGeneric(DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, + const struct DetectEngineAppInspectionEngine_ *engine, const Signature *s, Flow *f, + uint8_t flags, void *alstate, void *txv, uint64_t tx_id); static int g_tls_generic_list_id = 0; @@ -96,22 +94,18 @@ void DetectSslStateRegister(void) DetectBufferTypeSetDescriptionByName("tls_generic", "generic ssl/tls inspection"); - DetectAppLayerInspectEngineRegister("tls_generic", - ALPROTO_TLS, SIG_FLAG_TOSERVER, 0, - InspectTlsGeneric); - DetectAppLayerInspectEngineRegister("tls_generic", - ALPROTO_TLS, SIG_FLAG_TOCLIENT, 0, - InspectTlsGeneric); + DetectAppLayerInspectEngineRegister2( + "tls_generic", ALPROTO_TLS, SIG_FLAG_TOSERVER, 0, InspectTlsGeneric, NULL); + DetectAppLayerInspectEngineRegister2( + "tls_generic", ALPROTO_TLS, SIG_FLAG_TOCLIENT, 0, InspectTlsGeneric, NULL); } -static int InspectTlsGeneric(ThreadVars *tv, - DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, - const Signature *s, const SigMatchData *smd, - Flow *f, uint8_t flags, void *alstate, - void *txv, uint64_t tx_id) +static int InspectTlsGeneric(DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, + const struct DetectEngineAppInspectionEngine_ *engine, const Signature *s, Flow *f, + uint8_t flags, void *alstate, void *txv, uint64_t tx_id) { - return DetectEngineInspectGenericList(tv, de_ctx, det_ctx, s, smd, - f, flags, alstate, txv, tx_id); + return DetectEngineInspectGenericList( + NULL, de_ctx, det_ctx, s, engine->smd, f, flags, alstate, txv, tx_id); } /** diff --git a/src/detect-tls-cert-validity.c b/src/detect-tls-cert-validity.c index 8d64db9a48..8d4fb44660 100644 --- a/src/detect-tls-cert-validity.c +++ b/src/detect-tls-cert-validity.c @@ -75,11 +75,9 @@ static void TlsValidRegisterTests(void); static void DetectTlsValidityFree(DetectEngineCtx *, void *); static int g_tls_validity_buffer_id = 0; -static int DetectEngineInspectTlsValidity(ThreadVars *tv, - DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, - const Signature *s, const SigMatchData *smd, - Flow *f, uint8_t flags, void *alstate, - void *txv, uint64_t tx_id); +static int DetectEngineInspectTlsValidity(DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, + const struct DetectEngineAppInspectionEngine_ *engine, const Signature *s, Flow *f, + uint8_t flags, void *alstate, void *txv, uint64_t tx_id); /** * \brief Registration function for tls validity keywords. @@ -130,21 +128,18 @@ void DetectTlsValidityRegister (void) DetectSetupParseRegexes(PARSE_REGEX, &parse_regex); - DetectAppLayerInspectEngineRegister("tls_validity", - ALPROTO_TLS, SIG_FLAG_TOCLIENT, TLS_STATE_CERT_READY, - DetectEngineInspectTlsValidity); + DetectAppLayerInspectEngineRegister2("tls_validity", ALPROTO_TLS, SIG_FLAG_TOCLIENT, + TLS_STATE_CERT_READY, DetectEngineInspectTlsValidity, NULL); g_tls_validity_buffer_id = DetectBufferTypeGetByName("tls_validity"); } -static int DetectEngineInspectTlsValidity(ThreadVars *tv, - DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, - const Signature *s, const SigMatchData *smd, - Flow *f, uint8_t flags, void *alstate, - void *txv, uint64_t tx_id) +static int DetectEngineInspectTlsValidity(DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, + const struct DetectEngineAppInspectionEngine_ *engine, const Signature *s, Flow *f, + uint8_t flags, void *alstate, void *txv, uint64_t tx_id) { - return DetectEngineInspectGenericList(tv, de_ctx, det_ctx, s, smd, - f, flags, alstate, txv, tx_id); + return DetectEngineInspectGenericList( + NULL, de_ctx, det_ctx, s, engine->smd, f, flags, alstate, txv, tx_id); } /** * \internal diff --git a/src/detect-tls.c b/src/detect-tls.c index 3465ca07d4..4585d9f4fa 100644 --- a/src/detect-tls.c +++ b/src/detect-tls.c @@ -95,14 +95,12 @@ static int DetectTlsStorePostMatch (DetectEngineThreadCtx *det_ctx, static int g_tls_cert_list_id = 0; -static int InspectTlsCert(ThreadVars *tv, - DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, - const Signature *s, const SigMatchData *smd, - Flow *f, uint8_t flags, void *alstate, - void *txv, uint64_t tx_id) +static int InspectTlsCert(DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, + const struct DetectEngineAppInspectionEngine_ *engine, const Signature *s, Flow *f, + uint8_t flags, void *alstate, void *txv, uint64_t tx_id) { - return DetectEngineInspectGenericList(tv, de_ctx, det_ctx, s, smd, - f, flags, alstate, txv, tx_id); + return DetectEngineInspectGenericList( + NULL, de_ctx, det_ctx, s, engine->smd, f, flags, alstate, txv, tx_id); } /** @@ -151,9 +149,8 @@ void DetectTlsRegister (void) g_tls_cert_list_id = DetectBufferTypeRegister("tls_cert"); - DetectAppLayerInspectEngineRegister("tls_cert", - ALPROTO_TLS, SIG_FLAG_TOCLIENT, TLS_STATE_CERT_READY, - InspectTlsCert); + DetectAppLayerInspectEngineRegister2( + "tls_cert", ALPROTO_TLS, SIG_FLAG_TOCLIENT, TLS_STATE_CERT_READY, InspectTlsCert, NULL); } /** @@ -772,4 +769,4 @@ static int DetectTlsStorePostMatch (DetectEngineThreadCtx *det_ctx, ssl_state->server_connp.cert_log_flag |= SSL_TLS_LOG_PEM; SCReturnInt(1); -} \ No newline at end of file +}