Coverity 400477: pcre_get_substring retval

Add missing return code check to pcre_get_substring call.
12 years ago · 4827a4dcef
parent 790866656b
commit 4827a4dcef
1 changed files with 2 additions and 1 deletions
--- a/src/detect-parse.c
+++ b/src/detect-parse.c
@ -768,7 +768,8 @@ static int SigParseBasics(Signature *s, char *sigstr, char ***result, uint8_t ad
    }

    for (i = 1; i <= ret - 1; i++) {
-        pcre_get_substring(sigstr, ov, MAX_SUBSTRINGS, i, &arr[i - 1]);
+        if (pcre_get_substring(sigstr, ov, MAX_SUBSTRINGS, i, &arr[i - 1]) < 0)
+            goto error;
        //printf("SigParseBasics: arr[%" PRId32 "] = \"%s\"\n", i-1, arr[i-1]);
    }
    arr[i - 1] = NULL;