From 367e3e1895c6852530bb2f5b17ebf3153989f946 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Wed, 26 Jun 2019 14:42:55 +0200 Subject: [PATCH] detect/tcp/udp: minor cleanups --- src/detect-tcphdr.c | 8 ++++---- src/detect-udphdr.c | 9 ++++----- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/detect-tcphdr.c b/src/detect-tcphdr.c index 7474c9a0f7..5d42957104 100644 --- a/src/detect-tcphdr.c +++ b/src/detect-tcphdr.c @@ -45,7 +45,7 @@ static InspectionBuffer *GetData(DetectEngineThreadCtx *det_ctx, const DetectEngineTransforms *transforms, Packet *p, const int list_id); /** - * \brief Registration function for tcphdr: keyword + * \brief Registration function for tcp.hdr: keyword */ void DetectTcphdrRegister(void) { @@ -72,16 +72,16 @@ void DetectTcphdrRegister(void) } /** - * \brief this function is used to atcphdrd the parsed tcphdr data into the current signature + * \brief setup tcp.hdr sticky buffer * * \param de_ctx pointer to the Detection Engine Context * \param s pointer to the Current Signature - * \param tcphdrstr pointer to the user provided tcphdr options + * \param _unused unused * * \retval 0 on Success * \retval -1 on Failure */ -static int DetectTcphdrSetup (DetectEngineCtx *de_ctx, Signature *s, const char *tcphdrstr) +static int DetectTcphdrSetup (DetectEngineCtx *de_ctx, Signature *s, const char *_unused) { if (!(DetectProtoContainsProto(&s->proto, IPPROTO_TCP))) return -1; diff --git a/src/detect-udphdr.c b/src/detect-udphdr.c index 36c7805109..9059510b21 100644 --- a/src/detect-udphdr.c +++ b/src/detect-udphdr.c @@ -44,9 +44,8 @@ static int g_udphdr_buffer_id = 0; static InspectionBuffer *GetData(DetectEngineThreadCtx *det_ctx, const DetectEngineTransforms *transforms, Packet *p, const int list_id); /** - * \brief Registration function for udphdr: keyword + * \brief Registration function for udp.hdr: keyword */ - void DetectUdphdrRegister(void) { sigmatch_table[DETECT_UDPHDR].name = "udp.hdr"; @@ -71,16 +70,16 @@ void DetectUdphdrRegister(void) } /** - * \brief this function is used to atcphdrd the parsed tcphdr data into the current signature + * \brief set up the udp.hdr sticky buffer * * \param de_ctx pointer to the Detection Engine Context * \param s pointer to the Current Signature - * \param tcphdrstr pointer to the user provided tcphdr options + * \param _unused unused * * \retval 0 on Success * \retval -1 on Failure */ -static int DetectUdphdrSetup (DetectEngineCtx *de_ctx, Signature *s, const char *tcphdrstr) +static int DetectUdphdrSetup (DetectEngineCtx *de_ctx, Signature *s, const char *_unused) { if (!(DetectProtoContainsProto(&s->proto, IPPROTO_UDP))) return -1;